[PATCH] D44609: [Clang-Format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style)

lichray added a comment. In https://reviews.llvm.org/D44609#1059675, @Wawha wrote: > In my case, the main requirement is to be able **avoid** a lambda in one line. That doesn't work for me. I would like short lambdas still be formatted in one line, when `AllowShortFunctionsOnASingleLine` or a

[PATCH] D52401: Remove redundant null pointer check in operator delete

lichray reopened this revision. lichray added a comment. This revision is now accepted and ready to land. LGTM as well, unless @mclow.lists can tell us some history like interactions with K&R libc :) Repository: rL LLVM https://reviews.llvm.org/D52401 _

[PATCH] D51714: CMake: Deprecate using llvm-config to detect llvm installation

tstellar added a comment. In https://reviews.llvm.org/D51714#1248643, @smeenai wrote: > Is there anything holding this up? No hold up, I just wanted to address the review comment. I'll commit on Monday if there are no other comments. Repository: rC Clang https://reviews.llvm.org/D51714

[PATCH] D50403: [clang-format]AlignConsecutiveAssignments

kristina added subscribers: djasper, klimek, kristina. kristina added a comment. Please upload your diffs with full context (use `-U9` when doing the diff) and update them. I don't think there is a code owner for this part but @klimek and @djasper do most reviews to do with clang-format, so

[PATCH] D52673: [HIP] Remove disabled irif library

kristina added a comment. If you don't mind, can you please do another revision with full context (`-U9`), makes it easier to review and makes it less likely that `svn patch` screws up. Repository: rC Clang https://reviews.llvm.org/D52673 _

Re: r343285 - [cxx2a] P0641R2: (Some) type mismatches on defaulted functions only

https://reviews.llvm.org/rL343369 On Fri, Sep 28, 2018 at 4:51 PM Galina Kistanova via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hello Richard, > > This commit broke couple of our builders: > > http://lab.llvm.org:8011/builders/clang-with-thin-lto-ubuntu/builds/12924 > http://lab.llvm.or

r343369 - [cxx2a] Fix warning triggered by r343285

Author: vitalybuka Date: Fri Sep 28 19:17:12 2018 New Revision: 343369 URL: http://llvm.org/viewvc/llvm-project?rev=343369&view=rev Log: [cxx2a] Fix warning triggered by r343285 Modified: cfe/trunk/include/clang/AST/DeclBase.h Modified: cfe/trunk/include/clang/AST/DeclBase.h URL: http://llv

[clang-tools-extra] r343369 - [cxx2a] Fix warning triggered by r343285

Author: vitalybuka Date: Fri Sep 28 19:17:12 2018 New Revision: 343369 URL: http://llvm.org/viewvc/llvm-project?rev=343369&view=rev Log: [cxx2a] Fix warning triggered by r343285 Modified: clang-tools-extra/trunk/clang-doc/BitcodeWriter.h Modified: clang-tools-extra/trunk/clang-doc/BitcodeWri

[PATCH] D52660: [CMake][Fuchsia] Use libc++ ABIv2 for Fuchsia toolchain

kristina added a comment. My misunderstanding then, I was eventually hoping for a feature freeze of ABIv2 to a point where it's considered stable so any alterations to things like internal layout of std::string (ie. like SBO that came with ABIv2) happen in `unstable/std::__3` as this allows for

[PATCH] D52675: [clang] Properly apply attributes on explicit instantiations of static data members

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. This seems reasonable to me, but I'd feel most comfortable if @rsmith also signed off on it. Repository: rC Clang https://reviews.llvm.org/D52675 _

Buildbot numbers for the week of 9/16/2018 - 9/22/2018

Hello everyone, Below are some buildbot numbers for the last week of 9/16/2018 - 9/22/2018. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed

Buildbot numbers for the week of 9/09/2018 - 9/15/2018

Hello everyone, Below are some buildbot numbers for the week of 9/09/2018 - 9/15/2018. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed to r

[PATCH] D52675: [clang] Properly apply attributes on explicit instantiations of static data members

erik.pilkington added reviewers: rsmith, rjmccall. erik.pilkington added a comment. Add some reviewers. Repository: rC Clang https://reviews.llvm.org/D52675 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mai

Re: [PATCH] D52660: [CMake][Fuchsia] Use libc++ ABIv2 for Fuchsia toolchain

We have no such desire. I think we're fine being the test subjects for ABIv2 however. On Fri, Sep 28, 2018, 4:51 PM Louis Dionne via Phabricator < revi...@reviews.llvm.org> wrote: > ldionne added a comment. > > In https://reviews.llvm.org/D52660#1249709, @kristina wrote: > > > LGTM. Can we formal

[PATCH] D52660: [CMake][Fuchsia] Use libc++ ABIv2 for Fuchsia toolchain

ldionne added a comment. In https://reviews.llvm.org/D52660#1249709, @kristina wrote: > LGTM. Can we formalize ABIv2 as stable and make it distinct from unstable > (soon to be ABIv3) or are there are any rough corners still left before ABIv2 > and unstable can split in a feature freeze? I'm not

Re: r343285 - [cxx2a] P0641R2: (Some) type mismatches on defaulted functions only

Hello Richard, This commit broke couple of our builders: http://lab.llvm.org:8011/builders/clang-with-thin-lto-ubuntu/builds/12924 http://lab.llvm.org:8011/builders/clang-with-lto-ubuntu/builds/10475 . . . FAILED: lib/Transforms/Instrumentation/CMakeFiles/LLVMInstrumentation.dir/DataFlowSanitizer

[PATCH] D52248: [SEMA] ignore duplicate declaration specifiers from typeof exprs

nickdesaulniers added inline comments. Comment at: test/FixIt/fixit.c:50 -// CHECK: const typedef int int_t; -const typedef typedef int int_t; // expected-warning {{duplicate 'typedef'}} - Ah, this was a case I should add one last test for. I think reviewers can

[PATCH] D52248: [SEMA] ignore duplicate declaration specifiers from typeof exprs

nickdesaulniers added a comment. Ok, I think this is ready for rereview. Comment at: test/Parser/atomic.c:5 typedef _Atomic int atomic_int; -typedef _Atomic _Atomic _Atomic(int) atomic_int; // expected-warning {{duplicate '_Atomic' declaration specifier}} N

[PATCH] D52248: [SEMA] ignore duplicate declaration specifiers from typeof exprs

nickdesaulniers updated this revision to Diff 167565. nickdesaulniers added a comment. Herald added a subscriber: jfb. - split duplicate_declspec into Extension and Extwarn from Extwarn. - rename ext_duplicate_declspec to be the Extension, not the Extwarn. - Fix C++ case. - Use tablegen'd Extensio

[PATCH] D52320: AMDGPU: add __builtin_amdgcn_update_dpp

b-sumner added inline comments. Comment at: lib/CodeGen/CGBuiltin.cpp:11313-11315 + case AMDGPU::BI__builtin_amdgcn_update_dpp: { +llvm::SmallVector Args; +for (unsigned I = 0; I != 6; ++I) arsenm wrote: > The only difference between this and mov_dpp is

[PATCH] D52660: [CMake][Fuchsia] Use libc++ ABIv2 for Fuchsia toolchain

kristina added a comment. LGTM. Can we formalize ABIv2 as stable and make it distinct from unstable (soon to be ABIv3) or are there are any rough corners still left before ABIv2 and unstable can split in a feature freeze? Repository: rC Clang https://reviews.llvm.org/D52660 _

[PATCH] D52674: [AST] Add Obj-C discriminator to MS ABI RTTI

smeenai updated this revision to Diff 167555. smeenai added a comment. arc fail Repository: rC Clang https://reviews.llvm.org/D52674 Files: lib/AST/MicrosoftMangle.cpp test/CodeGenObjCXX/msabi-objc-exceptions-gnustep.mm Index: test/CodeGenObjCXX/msabi-objc-exceptions-gnustep.mm ===

[PATCH] D52581: [AST] Revert mangling changes from r339428

smeenai added a comment. https://reviews.llvm.org/D52674 adds the RTTI Obj-C discriminator. I put it up as a separate change so it could be reviewed independently and more thoroughly. Repository: rC Clang https://reviews.llvm.org/D52581 ___ cfe-

[PATCH] D52674: [AST] Add Obj-C discriminator to MS ABI RTTI

smeenai created this revision. smeenai added reviewers: compnerd, DHowett-MSFT, rjmccall, rnk, theraven. Herald added a subscriber: erik.pilkington. Obj-C classes are mangled as C++ structs with the same name (in both the Itanium and the Microsoft ABIs), but we want to be able to distinguish them

[PATCH] D52334: [clang-tidy] Build it even without static analyzer

aaron.ballman added a comment. I think that we need some sort of developer documentation change that explains 1) that this option exists when configuring clang-tidy, and 2) that this impacts the MPI module as well as the static analyzer. Comment at: clang-tidy/CMakeLists.txt:

[PATCH] D52670: [clang-tidy] Add new 'readability-uppercase-literal-suffix' check (CERT DCL16-C, MISRA C:2012, 7.3, MISRA C++:2008, 2-13-4)

lebedev.ri updated this revision to Diff 167552. lebedev.ri added a comment. - Deduplicate one test. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52670 Files: clang-tidy/cert/CERTTidyModule.cpp clang-tidy/cert/CMakeLists.txt clang-tidy/readability/CMakeLists.txt clang

[PATCH] D52670: [clang-tidy] Add new 'readability-uppercase-literal-suffix' check (CERT DCL16-C, MISRA C:2012, 7.3, MISRA C++:2008, 2-13-4)

lebedev.ri added inline comments. Comment at: docs/ReleaseNotes.rst:96 +- New alias :doc:`cert-dcl16-c + ` to :doc:`readability-uppercase-literal-suffix Eugene.Zelenko wrote: > Please move alias after new checks. BTW, is there some tool to actually add this a

[PATCH] D52670: [clang-tidy] Add new 'readability-uppercase-literal-suffix' check (CERT DCL16-C, MISRA C:2012, 7.3, MISRA C++:2008, 2-13-4)

lebedev.ri updated this revision to Diff 167547. lebedev.ri marked an inline comment as done. lebedev.ri added a comment. Move alias to after the new check, Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52670 Files: clang-tidy/cert/CERTTidyModule.cpp clang-tidy/cert/CMakeL

[PATCH] D52670: [clang-tidy] Add new 'readability-uppercase-literal-suffix' check (CERT DCL16-C, MISRA C:2012, 7.3, MISRA C++:2008, 2-13-4)

Eugene.Zelenko added a comment. May be we should also create MISRA module? Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52670 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/c

[PATCH] D52670: [clang-tidy] Add new 'readability-uppercase-literal-suffix' check (CERT DCL16-C, MISRA C:2012, 7.3, MISRA C++:2008, 2-13-4)

Eugene.Zelenko added inline comments. Comment at: docs/ReleaseNotes.rst:96 +- New alias :doc:`cert-dcl16-c + ` to :doc:`readability-uppercase-literal-suffix Please move alias after new checks. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D

[PATCH] D52673: [HIP] Remove disabled irif library

ashi1 created this revision. ashi1 added reviewers: yaxunl, b-sumner, scchan. Herald added a subscriber: cfe-commits. Device Libraries has removed irif.amdgcn.bc, so we need to remove this requirement from HIP Toolchains. Also a few header functions need to be updated. Repository: rC Clang h

LLVM buildmaster will be restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 7PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D52650: [clangd] NFC: Migrate to LLVM STLExtras API where possible

kbobyrev added a comment. In https://reviews.llvm.org/D52650#1249556, @sammccall wrote: > I think it's fine to update others too, this is a trivially-safe change and > a nice readability improvement. > No need to put everything in the same patch though. Great, thanks! I'll submit the patch on

[PATCH] D52670: [clang-tidy] Add new 'readability-uppercase-literal-suffix' check (CERT DCL16-C, MISRA C:2012, 7.3, MISRA C++:2008, 2-13-4)

lebedev.ri created this revision. lebedev.ri added reviewers: JonasToth, aaron.ballman, alexfh, hokein, xazax.hun. lebedev.ri added a project: clang-tools-extra. Herald added subscribers: rnkovacs, mgorny. Detects when the integral literal or floating point (decimal or hexadecimal) literal has non

[PATCH] D52339: Support enums with a fixed underlying type in all language modes

erik.pilkington added a comment. In https://reviews.llvm.org/D52339#1249457, @aaron.ballman wrote: > However, short of that concern, this LGTM. I've spoken with the paper author > for the WG14 paper and I think this approach fits their general proposal, so > I don't think we'll have divergence

r343360 - Support enums with a fixed underlying type in all language modes.

Author: epilk Date: Fri Sep 28 13:24:58 2018 New Revision: 343360 URL: http://llvm.org/viewvc/llvm-project?rev=343360&view=rev Log: Support enums with a fixed underlying type in all language modes. Previously we supported these in C++, ObjC, and C with -fms-extensions. rdar://43831380 Different

[PATCH] D52339: Support enums with a fixed underlying type in all language modes

This revision was automatically updated to reflect the committed changes. Closed by commit rC343360: Support enums with a fixed underlying type in all language modes. (authored by epilk, committed by ). Changed prior to commit: https://reviews.llvm.org/D52339?vs=166397&id=167538#toc Repository

[PATCH] D52339: Support enums with a fixed underlying type in all language modes

aaron.ballman added a comment. In https://reviews.llvm.org/D52339#1249531, @rsmith wrote: > In https://reviews.llvm.org/D52339#1249457, @aaron.ballman wrote: > > > In https://reviews.llvm.org/D52339#1249432, @erik.pilkington wrote: > > > > > Ping! This doesn't really affect CUDA or OpenCL more th

r343356 - [OPENMP]Fix PR39084: Check datasharing attributes of reduction variables only.

Author: abataev Date: Fri Sep 28 12:33:14 2018 New Revision: 343356 URL: http://llvm.org/viewvc/llvm-project?rev=343356&view=rev Log: [OPENMP]Fix PR39084: Check datasharing attributes of reduction variables only. According to OpenMP, the reduction item must be shared in parent region. But the ite

[PATCH] D52650: [clangd] NFC: Migrate to LLVM STLExtras API where possible

sammccall added subscribers: ioeric, kbobyrev. sammccall added a comment. I think it's fine to update others too, this is a trivially-safe change and a nice readability improvement. No need to put everything in the same patch though. https://reviews.llvm.org/D52650 ___

Re: [PATCH] D52650: [clangd] NFC: Migrate to LLVM STLExtras API where possible

I think it's fine to update others too, this is a trivially-safe change and a nice readability improvement. No need to put everything in the same patch though. On Fri, Sep 28, 2018, 16:23 Kirill Bobyrev via Phabricator < revi...@reviews.llvm.org> wrote: > kbobyrev added a comment. > > Also, I'm n

[PATCH] D52664: Update CMakeLists.txt snippet so that example compiles

smeenai added a comment. Yep, that's my doing (https://reviews.llvm.org/rL319840). I didn't think about the documentation, whoops. Repository: rC Clang https://reviews.llvm.org/D52664 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http:

[PATCH] D52538: [MinGW] Allow using ASan

mstorsjo added a comment. Ping @rnk in case you have time to look at it despite CppCon Repository: rC Clang https://reviews.llvm.org/D52538 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

[PATCH] D52640: [analyzer] [NFC] Remove unused parameters, as found by -Wunused-parameter

This revision was automatically updated to reflect the committed changes. Closed by commit rC343353: [analyzer] [NFC] Remove unused parameters, as found by -Wunused-parameter (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: https://

[PATCH] D52637: [analyzer] Provide an option to dump generated exploded graphs to a given file.

This revision was automatically updated to reflect the committed changes. Closed by commit rC343352: [analyzer] Provide an option to dump generated exploded graphs to a given file. (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: ht

[PATCH] D52339: Support enums with a fixed underlying type in all language modes

rsmith added a comment. In https://reviews.llvm.org/D52339#1249457, @aaron.ballman wrote: > In https://reviews.llvm.org/D52339#1249432, @erik.pilkington wrote: > > > Ping! This doesn't really affect CUDA or OpenCL more than any change to the > > compiler, so I don't think it makes sense to block

r343353 - [analyzer] [NFC] Remove unused parameters, as found by -Wunused-parameter

Author: george.karpenkov Date: Fri Sep 28 11:49:41 2018 New Revision: 343353 URL: http://llvm.org/viewvc/llvm-project?rev=343353&view=rev Log: [analyzer] [NFC] Remove unused parameters, as found by -Wunused-parameter Differential Revision: https://reviews.llvm.org/D52640 Modified: cfe/trunk

r343352 - [analyzer] Provide an option to dump generated exploded graphs to a given file.

Author: george.karpenkov Date: Fri Sep 28 11:49:21 2018 New Revision: 343352 URL: http://llvm.org/viewvc/llvm-project?rev=343352&view=rev Log: [analyzer] Provide an option to dump generated exploded graphs to a given file. Dumping graphs instead of opening them is often very useful, e.g. for tran

[PATCH] D52667: [analyzer] Fix conversion from LocAsInteger to Loc symbol.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet, rnkovacs. Herald added subscribers: cfe-commits, Szelethus, mikhail.ramalho, baloghadamsoftware. The thing i promised to fix in the last bullet of https://reviews.llvm.org/D44347: > `Symb

r343350 - [cxx2a] P0614R1: Support init-statements in range-based for loops.

Author: rsmith Date: Fri Sep 28 11:44:09 2018 New Revision: 343350 URL: http://llvm.org/viewvc/llvm-project?rev=343350&view=rev Log: [cxx2a] P0614R1: Support init-statements in range-based for loops. We don't yet support this for the case where a range-based for loop is implicitly rewritten to an

[PATCH] D52664: Update CMakeLists.txt snippet so that example compiles

steveire accepted this revision. steveire added a comment. This revision is now accepted and ready to land. Yes, `add_llvm_executable` uses `target_link_libraries` with `PRIVATE` for `LLVM_PTHREAD_LIB`. It is designed so that if you use the `PUBLIC|PRIVATE|INTERFACE` keyword with a target once,

[PATCH] D51949: [clang-tidy] new check 'readability-isolate-declaration'

JonasToth updated this revision to Diff 167523. JonasToth added a comment. - simplify matcher slighty, as initStmt in if/switch don't have a compundstmt as parent, add suggested tests Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51949 Files: clang-tidy/bugprone/ArgumentCom

[PATCH] D51949: [clang-tidy] new check 'readability-isolate-declaration'

Eugene.Zelenko added a comment. How about creating CERT alias? Comment at: clang-tidy/readability/IsolateDeclarationCheck.cpp:58 + // number of transformations. + while (Indirections--) { +Start = findPreviousAnyTokenKind(Start, SM, LangOpts, tok::star, tok::amp); ---

[PATCH] D52664: Update CMakeLists.txt snippet so that example compiles

danzimm created this revision. danzimm added a reviewer: modocache. Herald added a subscriber: cfe-commits. Previous to this the example didn't work out of the box, it seems some cmake config changed between when this was written and now. Repository: rC Clang https://reviews.llvm.org/D52664

[PATCH] D52665: [X86] Add more of the icc unaligned load/store to/from 128 bit vector intrinsics

craig.topper created this revision. craig.topper added reviewers: spatel, RKSimon. This patch adds _mm_loadu_si32 _mm_loadu_si16 _mm_storeu_si64 _mm_storeu_si32 _mm_storeu_si16 We already had _mm_load_si64. https://reviews.llvm.org/D52665 Files: lib/Headers/emmintrin.h test/CodeGen/sse2-bu

[PATCH] D52339: Support enums with a fixed underlying type in all language modes

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In https://reviews.llvm.org/D52339#1249432, @erik.pilkington wrote: > Ping! This doesn't really affect CUDA or OpenCL more than any change to the > compiler, so I don't think it

[PATCH] D51949: [clang-tidy] new check 'readability-isolate-declaration'

aaron.ballman added a comment. Can you add some tests for cases like: // C code void (*signal(int sig, void (*func)(int)))(int); // One decl int i = sizeof(struct S { int i;}); // One decl int j = sizeof(struct T { int i;}), k; // Two decls void g(struct U { int i; } s); // One decl v

[PATCH] D52339: Support enums with a fixed underlying type in all language modes

erik.pilkington added a comment. Ping! This doesn't really affect CUDA or OpenCL more than any change to the compiler, so I don't think it makes sense to block this until we hear from them. Repository: rC Clang https://reviews.llvm.org/D52339 __

[PATCH] D52434: [OpenMP] Make default distribute schedule for NVPTX target regions in SPMD mode achieve coalescing

gtbercea added a comment. In https://reviews.llvm.org/D52434#1249186, @Hahnfeld wrote: > In https://reviews.llvm.org/D52434#1249102, @gtbercea wrote: > > > You report a slow down which I am not able to reproduce actually. Do you > > use any additional clauses not present in your previous post? >

[PATCH] D52660: [CMake][Fuchsia] Use libc++ ABIv2 for Fuchsia toolchain

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. lgtm Repository: rC Clang https://reviews.llvm.org/D52660 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cg

[PATCH] D52660: [CMake][Fuchsia] Use libc++ ABIv2 for Fuchsia toolchain

phosek created this revision. phosek added reviewers: mcgrathr, jakehehrlich. Herald added subscribers: cfe-commits, mgorny. Herald added a reviewer: EricWF. We don't need to support legacy ABI and hence we can use the new one. Repository: rC Clang https://reviews.llvm.org/D52660 Files: cl

[PATCH] D52400: Improve -Wshadow warnings with enumerators

aaron.ballman added inline comments. Comment at: lib/Sema/SemaDecl.cpp:16320 +// Check for other kinds of shadowing not already handled. +CheckShadow(New, PrevDecl, R); + erik.pilkington wrote: > I don't think we should do this for scoped enums in C++, i.

[PATCH] D52400: Improve -Wshadow warnings with enumerators

aaron.ballman updated this revision to Diff 167507. aaron.ballman marked an inline comment as done. aaron.ballman added a comment. Updating based on review feedback. https://reviews.llvm.org/D52400 Files: lib/Sema/SemaDecl.cpp test/Sema/warn-shadow.c test/SemaCXX/warn-shadow.cpp Index:

r343343 - [X86] Add the movbe instruction intrinsics from icc.

Author: ctopper Date: Fri Sep 28 10:09:51 2018 New Revision: 343343 URL: http://llvm.org/viewvc/llvm-project?rev=343343&view=rev Log: [X86] Add the movbe instruction intrinsics from icc. These intrinsics exist in icc. They can be found on the Intel Intrinsics Guide website. All the backend supp

[PATCH] D52586: [X86] Add the movbe instruction intrinsics from icc.

This revision was automatically updated to reflect the committed changes. Closed by commit rL343343: [X86] Add the movbe instruction intrinsics from icc. (authored by ctopper, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D52586?vs=16

[PATCH] D52586: [X86] Add the movbe instruction intrinsics from icc.

This revision was automatically updated to reflect the committed changes. Closed by commit rC343343: [X86] Add the movbe instruction intrinsics from icc. (authored by ctopper, committed by ). Repository: rC Clang https://reviews.llvm.org/D52586 Files: lib/Basic/Targets/X86.cpp lib/Headers

r343338 - AST: add missing ObjC extensions to MS style name decoration

Author: compnerd Date: Fri Sep 28 09:47:53 2018 New Revision: 343338 URL: http://llvm.org/viewvc/llvm-project?rev=343338&view=rev Log: AST: add missing ObjC extensions to MS style name decoration Add support for encoding type arguments for lightweight generics in Objective-C++ mode. Additionally

[PATCH] D52400: Improve -Wshadow warnings with enumerators

erik.pilkington added inline comments. Comment at: lib/Sema/SemaDecl.cpp:16320 +// Check for other kinds of shadowing not already handled. +CheckShadow(New, PrevDecl, R); + I don't think we should do this for scoped enums in C++, i.e. this should be fine

[PATCH] D52384: [Sema] Fix redeclaration contexts for enumerators in C

aaron.ballman added inline comments. Comment at: lib/AST/DeclBase.cpp:1711-1712 + // contexts are always skipped. + while (SkipRecords ? Ctx->isTransparentContext() || Ctx->isRecord() + : Ctx->isTransparentContext()) Ctx = Ctx->getParent();

r343335 - [DRIVER][OFFLOAD] Do not invoke unbundler on unsupported file types.

Author: abataev Date: Fri Sep 28 09:17:59 2018 New Revision: 343335 URL: http://llvm.org/viewvc/llvm-project?rev=343335&view=rev Log: [DRIVER][OFFLOAD] Do not invoke unbundler on unsupported file types. clang-offload-bundler should not be invoked with the unbundling action when the input file typ

[PATCH] D52658: [OpenCL] Remove PIPE_RESERVE_ID_VALID_BIT from the common header

sidorovd created this revision. sidorovd added reviewers: Anastasia, yaxunl. Herald added a subscriber: cfe-commits. PIPE_RESERVE_ID_VALID_BIT is implementation defined, so lets not keep it in the header. Previously the topic was discussed here: https://reviews.llvm.org/D32896 Repository: rC

[PATCH] D52384: [Sema] Fix redeclaration contexts for enumerators in C

aaron.ballman updated this revision to Diff 167496. aaron.ballman marked an inline comment as done. aaron.ballman added a comment. Herald added a subscriber: jsji. Updated based on review feedback. https://reviews.llvm.org/D52384 Files: lib/AST/DeclBase.cpp test/Sema/enum.c Index: test/Se

[PATCH] D51949: [clang-tidy] new check 'readability-isolate-declaration'

JonasToth added inline comments. Comment at: docs/clang-tidy/checks/readability-isolate-declaration.rst:33 + for (int Begin = 0, End = 100; Begin < End; ++Begin); + it (int Begin = 42, Result = some_function(Begin); Begin == Result); + typo mention `if () int i

[PATCH] D51949: [clang-tidy] new check 'readability-isolate-declaration'

JonasToth added a comment. llvm and clang look fine as well. No miscompilation after fixing, tests run as well. (i do exclude all targets except x86 for build-speed) F7327680: cfe_isolated_decl.patch F7327681: llvm_isolated_decl.patch

[PATCH] D51949: [clang-tidy] new check 'readability-isolate-declaration'

JonasToth updated this revision to Diff 167491. JonasToth added a comment. Herald added subscribers: jsji, kbarton, nemanjai. - fix paren issue, introduced non-local changes i will extract and post in a separate patch - remove debug output for paren search Repository: rCTE Clang Tools Extra

[PATCH] D52434: [OpenMP] Make default distribute schedule for NVPTX target regions in SPMD mode achieve coalescing

Hahnfeld added a comment. In https://reviews.llvm.org/D52434#1249102, @gtbercea wrote: > You report a slow down which I am not able to reproduce actually. Do you use > any additional clauses not present in your previous post? No, only `dist_schedule(static)` which is faster. Tested on a `Tesla

[PATCH] D52654: [OpenCL][NFC] Unify ZeroToOCL* cast types

AlexeySachkov added a comment. This is an initial version. I guess there are some other enums related to CK_ZeroToOCL* which also can be merged. Also, I'm not sure that `CK_ZeroToOCLOpaqueType` is a good name. Thoughts? Repository: rC Clang https://reviews.llvm.org/D52654 ___

[PATCH] D51949: [clang-tidy] new check 'readability-isolate-declaration'

JonasToth added a comment. Blender looks better now, code compiles after full transformation F7327473: blender_isolated_decls.patch Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51949 ___ cfe-co

[PATCH] D52654: [OpenCL][NFC] Unify ZeroToOCL* cast types

AlexeySachkov created this revision. AlexeySachkov added reviewers: Anastasia, yaxunl. Repository: rC Clang https://reviews.llvm.org/D52654 Files: include/clang/AST/OperationKinds.def lib/AST/Expr.cpp lib/AST/ExprConstant.cpp lib/CodeGen/CGExpr.cpp lib/CodeGen/CGExprAgg.cpp lib/Cod

[PATCH] D52434: [OpenMP] Make default distribute schedule for NVPTX target regions in SPMD mode achieve coalescing

gtbercea added a comment. In https://reviews.llvm.org/D52434#1248975, @Hahnfeld wrote: > In https://reviews.llvm.org/D52434#1248974, @gtbercea wrote: > > > One big problem your code has is that the trip count is incredibly small, > > especially for STREAM and especially on GPUs. You need a much

r343305 - [ClangFormat] 'try' of function-try-block doesn't obey BraceWrapping

Author: owenpan Date: Fri Sep 28 02:17:00 2018 New Revision: 343305 URL: http://llvm.org/viewvc/llvm-project?rev=343305&view=rev Log: [ClangFormat] 'try' of function-try-block doesn't obey BraceWrapping It should respond to AfterFunction, not AfterControlStatement. Fixes PR39067 Modified: c

[PATCH] D52650: [clangd] NFC: Migrate to LLVM STLExtras API where possible

kbobyrev added a comment. Also, I'm not sure whether I should update Clang-Tidy and other tools in the scope of this patch. It makes sense to me, but I don't know whether the maintainers of these projects are happy with the change. WDYT? https://reviews.llvm.org/D52650 _

[PATCH] D52650: [clangd] NFC: Migrate to LLVM STLExtras API where possible

kbobyrev created this revision. kbobyrev added reviewers: ioeric, sammccall. kbobyrev added a project: clang-tools-extra. Herald added subscribers: kadircet, arphaman, dexonsmith, mgrang, jkorous, MaskRay, javed.absar, ilya-biryukov. This patch improves readability by migrating `std::function(For

[PATCH] D51464: clang: fix MIPS/N32 triple and paths

atanasyan added inline comments. Comment at: lib/Driver/ToolChains/Arch/Mips.cpp:85 if (ABIName.empty() && (Triple.getVendor() == llvm::Triple::MipsTechnologies || Is possible to rewrite this piece of code (lines 85-114) as follows? ``` if (ABIName.

[PATCH] D52586: [X86] Add the movbe instruction intrinsics from icc.

spatel accepted this revision. spatel added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D52586 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D50850: clang: Add triples support for MIPS r6

atanasyan added a comment. Fine. Now this patch has modifications for LLVM (not Clang) and all these changes were applied at https://reviews.llvm.org/rL343185 already. Could you attach an actual patch brings https://reviews.llvm.org/source/compiler-rt/ support to the Clang driver? https://rev

[PATCH] D52625: [OPENMP] Add 'unified_shared_memory' clause to OMP5 'requires' directive

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D52625 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D52625: [OPENMP] Add 'unified_shared_memory' clause to OMP5 'requires' directive

patricklyster updated this revision to Diff 167459. patricklyster added a comment. Added AST print test for `unified_shared_memory https://reviews.llvm.org/D52625 Files: clang/include/clang/AST/OpenMPClause.h clang/include/clang/AST/RecursiveASTVisitor.h clang/include/clang/Basic/OpenMPKi

[PATCH] D52625: [OPENMP] Add 'unified_shared_memory' clause to OMP5 'requires' directive

patricklyster added a comment. In https://reviews.llvm.org/D52625#1248436, @ABataev wrote: > I forgot to mention that you need an ast print test (the positive test) Thanks for the reminder. I will add that Repository: rC Clang https://reviews.llvm.org/D52625

Re: r337453 - [CodeComplete] Fix accessibilty of protected members from base class.

PTAL: https://reviews.llvm.org/D52647 On Fri, Sep 28, 2018 at 2:13 PM Eric Liu wrote: > (Oops, forgot there was this thread. Pasting my response to r338255 here). > > > The code seemed obviously wrong there (calling accessibility checking, > passing a possibly unrelated class) and the tests didn

[PATCH] D52620: Added Support for StatOnly Files in VFS.

usaxena95 added inline comments. Comment at: lib/Basic/VirtualFileSystem.cpp:2097 void YAMLVFSWriter::write(llvm::raw_ostream &OS) { - llvm::sort(Mappings, [](const YAMLVFSEntry &LHS, const YAMLVFSEntry &RHS) { + llvm::sort(Mappings.begin(), Mappings.end(), + [](co

[PATCH] D52647: [CodeComplete] Re-fix accessibilty of protected members from base class.

ioeric created this revision. ioeric added a reviewer: ilya-biryukov. Herald added a subscriber: cfe-commits. The initial fix (r337453) had bug and was partially reverted (r338255). This simplies the original fix by explicitly passing the naming class to the completion consumer. Repository: rC

[PATCH] D52620: Added Support for StatOnly Files in VFS.

usaxena95 added a comment. > it sounds like this is for record-replay. Yes this is for record-replay purpose. > What are these files in practice? During loading a modules the files that were required to make the module are stat()ed and their sizes are used to verify that the module is still va

[PATCH] D52434: [OpenMP] Make default distribute schedule for NVPTX target regions in SPMD mode achieve coalescing

gtbercea added a comment. In https://reviews.llvm.org/D52434#1248975, @Hahnfeld wrote: > In https://reviews.llvm.org/D52434#1248974, @gtbercea wrote: > > > One big problem your code has is that the trip count is incredibly small, > > especially for STREAM and especially on GPUs. You need a much

[PATCH] D52434: [OpenMP] Make default distribute schedule for NVPTX target regions in SPMD mode achieve coalescing

Hahnfeld added a comment. In https://reviews.llvm.org/D52434#1248974, @gtbercea wrote: > One big problem your code has is that the trip count is incredibly small, > especially for STREAM and especially on GPUs. You need a much larger loop > size otherwise the timings will be dominated by OpenMP

[PATCH] D52434: [OpenMP] Make default distribute schedule for NVPTX target regions in SPMD mode achieve coalescing

gtbercea added a comment. In https://reviews.llvm.org/D52434#1248844, @Hahnfeld wrote: > Just tested this and got very weird results for register usage: > > void func(double *a) { > #pragma omp target teams distribute parallel for map(a[0:100]) // > dist_schedule(static) > for (int i =

Re: r337453 - [CodeComplete] Fix accessibilty of protected members from base class.

(Oops, forgot there was this thread. Pasting my response to r338255 here). > The code seemed obviously wrong there (calling accessibility checking, passing a possibly unrelated class) and the tests didn't break after reverting it. It turns out that this was due to my lacking LIT test skill. LIT d

[PATCH] D51949: [clang-tidy] new check 'readability-isolate-declaration'

JonasToth added a comment. LLVM works, Blender doesn't, the offending piece is `float (((*f_ptr2)))[42], *f_ptr3, f_value2 = 42.f;` (parens around the pointer). I am trying to fix that. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51949

[PATCH] D52644: [ARM] Prevent DSP and SIM32 being set for v6m

This revision was automatically updated to reflect the committed changes. Closed by commit rC343309: [ARM] Prevent DSP and SIM32 being set for v6m (authored by sam_parker, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.org/D52644?vs=167444&

r343309 - [ARM] Prevent DSP and SIM32 being set for v6m

Author: sam_parker Date: Fri Sep 28 03:18:02 2018 New Revision: 343309 URL: http://llvm.org/viewvc/llvm-project?rev=343309&view=rev Log: [ARM] Prevent DSP and SIM32 being set for v6m My previous change (rL340911) set the two features for architectures >= 6, which wrongly includes v6m. Now set to

  1   2   >