aaron.ballman added a comment. I think that we need some sort of developer documentation change that explains 1) that this option exists when configuring clang-tidy, and 2) that this impacts the MPI module as well as the static analyzer.
================ Comment at: clang-tidy/CMakeLists.txt:29 +if(CLANG_ENABLE_STATIC_ANALYZER) +target_link_libraries(clangTidy PRIVATE + clangStaticAnalyzerCore ---------------- Indentation looks off here, same below. ================ Comment at: clang-tidy/ClangTidy.cpp:93 }; +#endif ---------------- Please add comments to the end of the endif so that it's easier to know what the guarding condition is. Same elsewhere. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52334 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
