chandlerc marked an inline comment as done.
chandlerc added inline comments.
Comment at: llvm/docs/LangRef.rst:1659-1661
+that hardening. It should also be possible to *not* harden a hot and/or
safe
+function and have code inlined there *not* be hardened (even if the gen
chandlerc updated this revision to Diff 162325.
chandlerc added a comment.
Move to a more conservative model suggested by Kristof.
Repository:
rL LLVM
https://reviews.llvm.org/D51157
Files:
clang/include/clang/Driver/Options.td
clang/include/clang/Frontend/CodeGenOptions.def
clang/lib/
a_sidorin accepted this revision.
a_sidorin added inline comments.
This revision is now accepted and ready to land.
Comment at: test/Import/cxx-anon-namespace/test.cpp:10
+// This is for the nested anonymous namespace.
+// CHECK-NEXT: UsingDirectiveDecl
+// CHECK-SAME: ''
---
kristof.beyls added inline comments.
Comment at: llvm/docs/LangRef.rst:1659-1661
+that hardening. It should also be possible to *not* harden a hot and/or
safe
+function and have code inlined there *not* be hardened (even if the generic
+form is hardened).
---
kristina added a comment.
I'd say LGTM since it's an introduction of any sort of **runtime** within the
LLVM project scope that deals with SEH specifically. So far all the published
code is pretty much exclusively related to Clang/LLVM IR and MC support for
codegen of SEH related code, but with
This was due to r340519. I've fixed it in r340596 to clean things up.
On Thu, Aug 23, 2018 at 8:20 PM Chandler Carruth
wrote:
> Trying new address again...
>
>
> On Thu, Aug 23, 2018 at 8:17 PM Chandler Carruth
> wrote:
>
>> Sorry for ancient thread revival, but...
>>
>> On Mon, Feb 6, 2017 at
Author: chandlerc
Date: Thu Aug 23 21:45:04 2018
New Revision: 340596
URL: http://llvm.org/viewvc/llvm-project?rev=340596&view=rev
Log:
[AVR] Fix inline asm calls now that the addrspace(0) there is explicit.
This updates the test case for r340519 so it should pass again. r340522
only got some of
rsmith accepted this revision.
rsmith added inline comments.
Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1150
+ Opts.SpeculativeLoadHardening =
+ Args.hasFlag(OPT_mspeculative_load_hardening,
You can just use `hasArg(OPT_mspeculative_load_harden
Trying new address again...
On Thu, Aug 23, 2018 at 8:17 PM Chandler Carruth
wrote:
> Sorry for ancient thread revival, but...
>
> On Mon, Feb 6, 2017 at 2:10 AM Dylan McKay via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: dylanmckay
>> Date: Mon Feb 6 03:01:59 2017
>> New Re
Sorry for ancient thread revival, but...
On Mon, Feb 6, 2017 at 2:10 AM Dylan McKay via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: dylanmckay
> Date: Mon Feb 6 03:01:59 2017
> New Revision: 294176
>
> URL: http://llvm.org/viewvc/llvm-project?rev=294176&view=rev
> Log:
> [AVR] Add
chandlerc updated this revision to Diff 162322.
chandlerc added a comment.
Add a test file that I somehow missed earlier (sorry about that).
Repository:
rL LLVM
https://reviews.llvm.org/D51157
Files:
clang/include/clang/Driver/Options.td
clang/include/clang/Frontend/CodeGenOptions.def
This revision was automatically updated to reflect the committed changes.
Closed by commit rL340595: [RISCV] RISC-V using -fuse-init-array by default
(authored by kito, committed by ).
Herald added subscribers: llvm-commits, jrtc27.
Changed prior to commit:
https://reviews.llvm.org/D50043?vs=16
chandlerc added a comment.
Thanks, should all be addressed now.
Comment at: clang/lib/Driver/ToolChains/Arch/X86.cpp:169-170
options::OPT_mno_retpoline_external_thunk, false)) {
// FIXME: Add a warning about failing to specify `-mretpoline` and
chandlerc updated this revision to Diff 162319.
chandlerc marked 3 inline comments as done.
chandlerc added a comment.
Address review comments.
Repository:
rL LLVM
https://reviews.llvm.org/D51157
Files:
clang/include/clang/Driver/Options.td
clang/include/clang/Frontend/CodeGenOptions.def
MTC added a comment.
In https://reviews.llvm.org/D48027#1209844, @NoQ wrote:
> So i believe that one of the important remaining problems with
> `CallDescription` is to teach it to discriminate between global functions and
> methods. We can do it in a number of ways:
>
> 1. Make a special sub-cl
steven_wu added a comment.
I feel like this is a much tricky situation than just new and init. Following
example is the same situation.
__attribute__((objc_root_class))
@interface NSObject
- (void) foo;
- (void) bar;
@end
@implementation NSObject
- (void) foo {}
- (void) bar {
ributzka added a comment.
TAPI mostly cares about linkable symbols, so this shouldn't be a problem.
Repository:
rC Clang
https://reviews.llvm.org/D51189
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
mgrang created this revision.
mgrang added reviewers: rnk, compnerd, mstorsjo, haripul, TomTan.
Herald added a reviewer: javed.absar.
Herald added subscribers: chrib, kristof.beyls.
Added declarations for the intrinsics in arm64intr.h. These are defined in MSVC
libs and are needed for
certain spe
tejohnson accepted this revision.
tejohnson added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rC Clang
https://reviews.llvm.org/D51198
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/
arphaman added a subscriber: ributzka.
arphaman added a comment.
In https://reviews.llvm.org/D51189#1211763, @erik.pilkington wrote:
> In https://reviews.llvm.org/D51189#1211754, @arphaman wrote:
>
> > Hmm, I don't think this solution is ideal, we'd rather have an attribute
> > somewhere for oth
kuhar added a comment.
Disclaimer: I'm a Clang newbie and I'm not sure if that's a good way to
implement these intrinsics. I'm not sure about the following things:
- The new enum CallInlineKind may not be in the right place
- Not sure if adding the extra parameter to EmitSomething methods is the
efriedma updated this revision to Diff 162308.
efriedma added a comment.
Fix new pass manager.
Repository:
rC Clang
https://reviews.llvm.org/D51198
Files:
lib/CodeGen/BackendUtil.cpp
test/CodeGen/summary-index-unnamed-global.ll
Index: test/CodeGen/summary-index-unnamed-global.ll
==
kuhar created this revision.
kuhar added reviewers: rsmith, pcc, Prazek, sanjoy.
kuhar added a project: clang.
Herald added a subscriber: eraman.
Herald added a reviewer: grosser.
Traditionally, to force some inlining decisions one has to annotate function
declarations with `__attribute__((always
michaelwu added a comment.
Review ping
Repository:
rC Clang
https://reviews.llvm.org/D50318
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tejohnson added a comment.
Thanks. Can you fix the same code in EmitAssemblyWithNewPassManager?
Repository:
rC Clang
https://reviews.llvm.org/D51198
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
pcc added a comment.
https://reviews.llvm.org/D51199 fixes the above breakage as well as
crbug.com/877235. Once it lands, I'll reland this change.
Repository:
rC Clang
https://reviews.llvm.org/D51049
___
cfe-commits mailing list
cfe-commits@list
efriedma created this revision.
efriedma added reviewers: tejohnson, tobiasvk.
Herald added subscribers: dexonsmith, inglorion.
If all LLVM passes are disabled, we can't emit a summary because there could be
unnamed globals in the IR.
Repository:
rC Clang
https://reviews.llvm.org/D51198
Fil
erik.pilkington added a comment.
In https://reviews.llvm.org/D51189#1211754, @arphaman wrote:
> Hmm, I don't think this solution is ideal, we'd rather have an attribute
> somewhere for other consumers of availability annotations. Does MyObject have
> an implicit decl of `new`, or are we referri
arphaman added a comment.
Hmm, I don't think this solution is ideal, we'd rather have an attribute
somewhere for other consumers of availability annotations. Does MyObject have
an implicit decl of `new`, or are we referring to `NSObject`s `new`? Ideally we
would an attribute on a particular `ne
jfb accepted this revision.
jfb added inline comments.
This revision is now accepted and ready to land.
Comment at: libcxx/include/future:556
bool __has_value() const
{return (__state_ & __constructed) || (__exception_ != nullptr);}
I'm not auditi
apazos added a comment.
Herald added a subscriber: erik.pilkington.
Hello folks, is there a plan to merge this feature still?
https://reviews.llvm.org/D37624
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
ahatanak added a comment.
In https://reviews.llvm.org/D47757#1211276, @tra wrote:
> I've confirmed that the patch does not break anything in our CUDA code, so
> it's good to go as far as CUDA is concerned.
Thanks. @rsmith, do you have any other comments about the patch?
Repository:
rC Clan
nickdesaulniers updated this revision to Diff 162291.
nickdesaulniers added a comment.
- link to correct doc
Repository:
rC Clang
https://reviews.llvm.org/D51190
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
Index: include/clang/Basic/AttrDocs.td
==
steveire updated this revision to Diff 162288.
steveire added a comment.
Fix reported range of partial token replacement
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51192
Files:
clang-tidy/ClangTidy.cpp
Index: clang-tidy/ClangTidy.cpp
steveire created this revision.
steveire added reviewers: klimek, rsmith.
Herald added a subscriber: cfe-commits.
Fixes bug: 38678
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51192
Files:
clang-tidy/ClangTidy.cpp
Index: clang-tidy/ClangTidy.cpp
==
Author: steveire
Date: Thu Aug 23 15:41:52 2018
New Revision: 340586
URL: http://llvm.org/viewvc/llvm-project?rev=340586&view=rev
Log:
Fix typo
Modified:
cfe/trunk/utils/TableGen/ClangCommentHTMLNamedCharacterReferenceEmitter.cpp
Modified:
cfe/trunk/utils/TableGen/ClangCommentHTMLNamedChara
steveire updated this revision to Diff 162283.
steveire added a comment.
Remove vestiges of configure buildsystem
Repository:
rC Clang
https://reviews.llvm.org/D50738
Files:
CMakeLists.txt
Index: CMakeLists.txt
===
--- CMake
steveire added inline comments.
Comment at: unittests/Basic/SourceManagerTest.cpp:189
+
+ // TODO: How do I get a loc in another file?
+ auto headerLoc =
SourceMgr.getSpellingLoc(SourceMgr.translateLineCol(MainFileID, 3, 5));
I don't know how to resolve this T
steveire updated this revision to Diff 162282.
steveire marked 3 inline comments as done.
steveire added a comment.
Add dump() and supporting methods to SourceRange
Repository:
rC Clang
https://reviews.llvm.org/D50662
Files:
include/clang/Basic/SourceLocation.h
lib/Basic/SourceLocation.c
steveire updated this revision to Diff 162280.
steveire added a comment.
Add dump() and supporting methods to SourceRange
Repository:
rC Clang
https://reviews.llvm.org/D50662
Files:
include/clang/Basic/SourceLocation.h
lib/Basic/SourceLocation.cpp
unittests/Basic/SourceManagerTest.cpp
nickdesaulniers created this revision.
nickdesaulniers added a reviewer: rsmith.
Herald added a subscriber: cfe-commits.
This wasn't documented https://clang.llvm.org/docs/AttributeReference.html, and
briefly mentioned
https://clang.llvm.org/docs/UsersManual.html#differences-between-various-stan
erik.pilkington created this revision.
erik.pilkington added a reviewer: arphaman.
Herald added a subscriber: dexonsmith.
rdar://18335828
Thanks!
Erik
Repository:
rC Clang
https://reviews.llvm.org/D51189
Files:
clang/include/clang/AST/ASTContext.h
clang/include/clang/AST/DeclObjC.h
cl
nickdesaulniers added a comment.
Kernel patch:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=815f0ddb346c196018d4d8f8f55c12b83da1de3f
Thanks Eli and Richard, I appreciate it.
Repository:
rC Clang
https://reviews.llvm.org/D51011
aaronpuchert created this revision.
aaronpuchert added reviewers: delesley, aaron.ballman.
Herald added a subscriber: cfe-commits.
We now warn when acquiring or releasing a scoped capability a second
time, not just if the underlying mutexes have been acquired or released
a second time. It's debata
Author: aaronpuchert
Date: Thu Aug 23 14:53:04 2018
New Revision: 340580
URL: http://llvm.org/viewvc/llvm-project?rev=340580&view=rev
Log:
Remove more const_casts by using ConstStmtVisitor [NFC]
Again, this required adding some const specifiers.
Modified:
cfe/trunk/lib/Analysis/ThreadSafety.
pcc reopened this revision.
pcc added a comment.
This revision is now accepted and ready to land.
I received another report of breakage so I reverted in
https://reviews.llvm.org/rC340579.
Repository:
rC Clang
https://reviews.llvm.org/D51049
___
Author: pcc
Date: Thu Aug 23 14:34:57 2018
New Revision: 340579
URL: http://llvm.org/viewvc/llvm-project?rev=340579&view=rev
Log:
Revert r340552, "Driver: Enable address-significance tables by default when
targeting COFF."
Received multiple reports of breakage due to undefined symbols
suspected
pcc added a comment.
Thanks, I'll take a look.
Repository:
rC Clang
https://reviews.llvm.org/D51049
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vitalybuka added a comment.
This breaks Windows bot
http://lab.llvm.org:8011/builders/sanitizer-windows/builds/33846/steps/run%20check-asan/logs/stdio
742542.065 [0/1/37] Running the AddressSanitizer tests
-- Testing: 607 tests, 16 threads --
Testing: 0 .. 10.. 20.. 30.. 40.. 50
FAIL: A
Author: aaronpuchert
Date: Thu Aug 23 14:13:32 2018
New Revision: 340575
URL: http://llvm.org/viewvc/llvm-project?rev=340575&view=rev
Log:
Remove unnecessary const_cast [NFC]
This required adding a few const specifiers on functions.
Also a minor formatting fix suggested in D49885.
Modified:
mstorsjo added a comment.
Not much more comments from me. The implementation seems reasonable, and works
for one simple test I did (with an earlier revision of the patch at least), and
further refinement can happen in-tree I guess.
I'd like to have someone else (@rnk @compnerd?) give it a more
Hahnfeld planned changes to this revision.
Hahnfeld added a comment.
This patch breaks C++ and CUDA compilation at the moment, sorry. I need to find
and add more macros that turn out to be needed.
Repository:
rC Clang
https://reviews.llvm.org/D50845
___
Hahnfeld added a comment.
In https://reviews.llvm.org/D50845#1211463, @gregrodgers wrote:
> What am I missing?
As discussed above this patch doesn't fix this problem. However we need
`__x86_64__` because `bits/wordsize.h` will use it to determine if we are 64-
or 32-bit.
Repository:
rC Cl
gregrodgers added a comment.
I have a longer comment on header files, but let me first understand this
patch.
IIUC,the concept of this patch is to fake the macros to think it is seeing
a host on the device patch.
if ((LangOpts.CUDA || LangOpts.OpenMPIsDevice) && PP.getAuxTargetInfo())
Initi
rsmith added inline comments.
Comment at: clang/include/clang/Driver/Options.td:2004-2007
+def mspeculative_load_hardening : Flag<["-"], "mspeculative-load-hardening">,
+ Group, Flags<[CoreOption,CC1Option]>;
+def mno_speculative_load_hardening : Flag<["-"],
"mno-speculative-lo
hugoeg updated this revision to Diff 162256.
hugoeg added a comment.
minor fixes and style improvement
https://reviews.llvm.org/D51132
Files:
clang-tidy/abseil/AbseilTidyModule.cpp
clang-tidy/abseil/CMakeLists.txt
clang-tidy/abseil/RedundantStrcatCallsCheck.cpp
clang-tidy/abseil/Redunda
ioeric added inline comments.
Comment at: lib/Basic/FileManager.cpp:319
- SmallString<128> RealPathName;
- if (!FS->getRealPath(InterndFileName, RealPathName))
-UFE.RealPathName = RealPathName.str();
+ if (UFE.File) {
+if (auto Path = UFE.File->getName()) {
-
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
It makes sense to me to do this all in one go and defer the clang
`__attribute__` until later.
Comment at: llvm/include/llvm/IR/Attributes.td:249
def : MergeRule<"adjustNullPoint
On Thu, 23 Aug 2018 at 02:52, Anastasia Stulova via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Hi Richard,
>
>
> There was a change in the spec to disallow unprototyped functions, which
> was made this year. Unfortunately it seems it didn't make into the Khronos
> registry yet to appear pu
simark added inline comments.
Comment at: lib/Basic/FileManager.cpp:319
- SmallString<128> RealPathName;
- if (!FS->getRealPath(InterndFileName, RealPathName))
-UFE.RealPathName = RealPathName.str();
+ if (UFE.File) {
+if (auto Path = UFE.File->getName()) {
-
ioeric added inline comments.
Herald added a subscriber: kadircet.
Comment at: clangd/SourceCode.cpp:209
+ llvm::SmallString<128> RealPath;
+ if (SourceMgr.getFileManager().getVirtualFileSystem()->getRealPath(
+ Path, RealPath)) {
With the recent perfo
hugoeg updated this revision to Diff 162253.
hugoeg added a comment.
minor fixes, style improvements
https://reviews.llvm.org/D51061
Files:
clang-tidy/abseil/AbseilTidyModule.cpp
clang-tidy/abseil/CMakeLists.txt
clang-tidy/abseil/StrCatAppendCheck.cpp
clang-tidy/abseil/StrCatAppendCheck
ioeric added inline comments.
Comment at: lib/Basic/FileManager.cpp:319
- SmallString<128> RealPathName;
- if (!FS->getRealPath(InterndFileName, RealPathName))
-UFE.RealPathName = RealPathName.str();
+ if (UFE.File) {
+if (auto Path = UFE.File->getName()) {
-
cdavis5x marked 2 inline comments as done.
cdavis5x added inline comments.
Comment at: src/Unwind-seh.cpp:163
+#ifdef __x86_64__
+unw_get_reg(&cursor, UNW_X86_64_RAX, &retval);
+unw_get_reg(&cursor, UNW_X86_64_RDX, &exc->private_[3]);
mstorsjo wrote:
> Wi
cdavis5x updated this revision to Diff 162250.
cdavis5x marked 7 inline comments as done.
cdavis5x added a comment.
- Remove unnecessary code.
- Guard against rogue personality functions returning wrong values.
- Add a comment clarifying the purpose of the `new_ctx` variable.
Repository:
rUNW
ioeric added a comment.
Do we plan to expose an API in `ClangdServer` to allow C++ API users to track
index memory usages?
Comment at: clang-tools-extra/clangd/index/FileIndex.cpp:123
+ size_t Bytes = Index.estimateMemoryUsage();
+ for (const auto &Scheme : URISchemes) {
+
simark added inline comments.
Comment at: lib/Basic/FileManager.cpp:319
- SmallString<128> RealPathName;
- if (!FS->getRealPath(InterndFileName, RealPathName))
-UFE.RealPathName = RealPathName.str();
+ if (UFE.File) {
+if (auto Path = UFE.File->getName()) {
-
ioeric added inline comments.
Comment at: lib/Basic/FileManager.cpp:319
- SmallString<128> RealPathName;
- if (!FS->getRealPath(InterndFileName, RealPathName))
-UFE.RealPathName = RealPathName.str();
+ if (UFE.File) {
+if (auto Path = UFE.File->getName()) {
-
teemperor created this revision.
Herald added subscribers: cfe-commits, martong.
Herald added a reviewer: a.sidorin.
Repository:
rC Clang
https://reviews.llvm.org/D51178
Files:
test/Import/cxx-anon-namespace/Inputs/F.cpp
test/Import/cxx-anon-namespace/test.cpp
Index: test/Import/cxx-anon
ABataev created this revision.
ABataev added a reviewer: echristo.
Herald added subscribers: JDevlieghere, fedor.sergeev, aprantl.
Added option -glineinfo-only to support emission of the debug directives
only. It behaves very similar to -gline-tables-only, except that it sets
llvm debug info emiss
simark added inline comments.
Comment at: lib/Basic/FileManager.cpp:319
- SmallString<128> RealPathName;
- if (!FS->getRealPath(InterndFileName, RealPathName))
-UFE.RealPathName = RealPathName.str();
+ if (UFE.File) {
+if (auto Path = UFE.File->getName()) {
-
tra added a comment.
I've confirmed that the patch does not break anything in our CUDA code, so it's
good to go as far as CUDA is concerned.
I'll fix the exposed CUDA issue in a separate patch.
Repository:
rC Clang
https://reviews.llvm.org/D47757
_
Author: vedantk
Date: Thu Aug 23 10:55:03 2018
New Revision: 340559
URL: http://llvm.org/viewvc/llvm-project?rev=340559&view=rev
Log:
[docs] Regenerate ClangCommandLineReference.rst
Modified:
cfe/trunk/docs/ClangCommandLineReference.rst
Modified: cfe/trunk/docs/ClangCommandLineReference.rst
Author: vedantk
Date: Thu Aug 23 10:54:48 2018
New Revision: 340558
URL: http://llvm.org/viewvc/llvm-project?rev=340558&view=rev
Log:
[options] Document -(static|shared)-libsan
Modified:
cfe/trunk/include/clang/Driver/Options.td
Modified: cfe/trunk/include/clang/Driver/Options.td
URL:
http:
ioeric added inline comments.
Comment at: lib/Basic/FileManager.cpp:319
- SmallString<128> RealPathName;
- if (!FS->getRealPath(InterndFileName, RealPathName))
-UFE.RealPathName = RealPathName.str();
+ if (UFE.File) {
+if (auto Path = UFE.File->getName()) {
-
Author: pcc
Date: Thu Aug 23 10:43:29 2018
New Revision: 340552
URL: http://llvm.org/viewvc/llvm-project?rev=340552&view=rev
Log:
Driver: Enable address-significance tables by default when targeting COFF.
Differential Revision: https://reviews.llvm.org/D51049
Modified:
cfe/trunk/lib/Driver/T
This revision was automatically updated to reflect the committed changes.
Closed by commit rC340552: Driver: Enable address-significance tables by
default when targeting COFF. (authored by pcc, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D51049?vs=161763&id=162232#toc
Rep
hugoeg updated this revision to Diff 162231.
https://reviews.llvm.org/D51061
Files:
clang-tidy/abseil/AbseilTidyModule.cpp
clang-tidy/abseil/CMakeLists.txt
clang-tidy/abseil/StrCatAppendCheck.cpp
clang-tidy/abseil/StrCatAppendCheck.h
docs/ReleaseNotes.rst
docs/clang-tidy/checks/abseil
Eugene.Zelenko added inline comments.
Comment at: docs/clang-tidy/checks/abseil-str-cat-append.rst:11
+
+ a = StrCat(a, b); // Use StrAppend(&a, b) instead.
+
Please add namespace.
https://reviews.llvm.org/D51061
hugoeg added a comment.
Let me know if there's anything else I can fix to move the process along.
https://reviews.llvm.org/D51061
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
simark added inline comments.
Comment at: lib/Basic/FileManager.cpp:319
- SmallString<128> RealPathName;
- if (!FS->getRealPath(InterndFileName, RealPathName))
-UFE.RealPathName = RealPathName.str();
+ if (UFE.File) {
+if (auto Path = UFE.File->getName()) {
-
ioeric updated this revision to Diff 162224.
ioeric added a comment.
- another minior cleanup
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50962
Files:
clangd/ClangdServer.cpp
clangd/ClangdServer.h
clangd/CodeComplete.cpp
clangd/CodeComplete.h
clangd/TUScheduler.h
ioeric added inline comments.
Comment at: clangd/ClangdServer.cpp:159
+ }
+ if (SpecFuzzyReq) {
+if (auto Filter = speculateCompletionFilter(Content, Pos)) {
ilya-biryukov wrote:
> NIT: maybe invert condition to reduce nesting?
It would become something lik
ioeric updated this revision to Diff 16.
ioeric added a comment.
- minor cleanup
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50962
Files:
clangd/ClangdServer.cpp
clangd/ClangdServer.h
clangd/CodeComplete.cpp
clangd/CodeComplete.h
clangd/TUScheduler.h
clangd/i
hugoeg updated this revision to Diff 162223.
https://reviews.llvm.org/D51132
Files:
clang-tidy/abseil/AbseilTidyModule.cpp
clang-tidy/abseil/CMakeLists.txt
clang-tidy/abseil/RedundantStrcatCallsCheck.cpp
clang-tidy/abseil/RedundantStrcatCallsCheck.h
docs/ReleaseNotes.rst
docs/clang-ti
ioeric updated this revision to Diff 162221.
ioeric marked 5 inline comments as done.
ioeric added a comment.
Herald added subscribers: jfb, javed.absar.
- Moved most logic into CodeComplete.cc
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50962
Files:
clangd/ClangdServer.cp
Eugene.Zelenko added inline comments.
Comment at: docs/clang-tidy/checks/abseil-redundant-strcat-calls.rst:16
+
+ string s = absl::StrCat("A", absl::StrCat("B", absll::StrCat("C",
"D")));
+ string s = absl::StrCat("A", "B", "C", "D");
std::string
hugoeg updated this revision to Diff 162219.
https://reviews.llvm.org/D51132
Files:
clang-tidy/abseil/AbseilTidyModule.cpp
clang-tidy/abseil/CMakeLists.txt
clang-tidy/abseil/RedundantStrcatCallsCheck.cpp
clang-tidy/abseil/RedundantStrcatCallsCheck.h
docs/ReleaseNotes.rst
docs/clang-ti
Szelethus added inline comments.
Comment at:
lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedPointee.cpp:187-191
// If FR is a pointer pointing to a non-primitive type.
if (Optional RecordV =
DerefdV.getAs()) {
const TypedValueRegion *R = Rec
This revision was automatically updated to reflect the committed changes.
Closed by commit rC340547: [ASTMatchers] Let hasObjectExpression also support
UnresolvedMemberExpr… (authored by shuaiwang, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D50617?vs=161830&id=162218#toc
Author: shuaiwang
Date: Thu Aug 23 10:16:06 2018
New Revision: 340547
URL: http://llvm.org/viewvc/llvm-project?rev=340547&view=rev
Log:
[ASTMatchers] Let hasObjectExpression also support UnresolvedMemberExpr,
CXXDependentScopeMemberExpr
Reviewers: aaron.ballman
Subscribers: cfe-commits
Differe
Eugene.Zelenko added inline comments.
Comment at: docs/clang-tidy/checks/abseil-redundant-strcat-calls.rst:16
+
+ string s = StrCat("A", StrCat("B", StrCat("C", "D")));
+ ==> string s = StrCat("A", "B", "C", "D");
Please add namespaces and use empty l
erik.pilkington added a comment.
Landed as r340544. @hans: Can you cherry-pick?
Repository:
rCXX libc++
https://reviews.llvm.org/D51172
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
rjmccall added inline comments.
Comment at: lib/Sema/SemaChecking.cpp:4924
+<< Callee->getSourceRange();
+ }
+
Why is the diagnostic at the end location? And why are you separately checking
whether it's ignored at the begin location?
This revision was automatically updated to reflect the committed changes.
Closed by commit rCXX340544: Comment out #define __cpp_lib_node_extract, we
only support half of that… (authored by epilk, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D51172?vs=162208&id=162215#toc
Author: epilk
Date: Thu Aug 23 10:08:02 2018
New Revision: 340544
URL: http://llvm.org/viewvc/llvm-project?rev=340544&view=rev
Log:
Comment out #define __cpp_lib_node_extract, we only support half of that
functionality
Differential revision: https://reviews.llvm.org/D51172
Modified:
libcxx/
ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.
LGTM. Don't forget to update https://reviews.llvm.org/D48896 so it uncomments
this. Also, this should be merged into LLVM 7.
Repository:
rCXX libc++
https://reviews.llvm.org/D51172
__
erik.pilkington created this revision.
erik.pilkington added reviewers: ldionne, mclow.lists, hans.
Herald added a reviewer: EricWF.
Herald added subscribers: dexonsmith, christof.
The other half of this is in https://reviews.llvm.org/D48896, so we shouldn't
claim that we support this feature. Th
Hahnfeld added a comment.
The discussion kind of moved away from the original patch, probably because the
problem is larger than the defition of some host macros. However I still think
that this patch improves the situation.
Repository:
rC Clang
https://reviews.llvm.org/D50845
__
Szelethus updated this revision to Diff 162205.
Szelethus added a comment.
Rebased to https://reviews.llvm.org/D51057.
https://reviews.llvm.org/D50892
Files:
lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedPointee.cpp
test/Analysis/cxx-uninitialized-object-inheritance.cpp
Ind
1 - 100 of 178 matches
Mail list logo
