gregrodgers added a comment.

I have a longer comment on header files,  but let me first understand this 
patch.

IIUC,the concept of this patch is to fake the macros to think it is seeing
a host on the device patch.

if ((LangOpts.CUDA || LangOpts.OpenMPIsDevice) && PP.getAuxTargetInfo())

  InitializePredefinedAuxMacros(*PP.getAuxTargetInfo(), Builder);

That would be counterproductive because well-behaved headers that only
provide optized asm definitions would wrap that asm with

#ifdef __x86_64__

  do some x86 asm function definition

#else

  just provide the function declaration to be implemented somewhere else.

#endif

What am I missing?


Repository:
  rC Clang

https://reviews.llvm.org/D50845



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to