rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land.
It makes sense to me to do this all in one go and defer the clang `__attribute__` until later. ================ Comment at: llvm/include/llvm/IR/Attributes.td:249 def : MergeRule<"adjustNullPointerValidAttr">; + ---------------- I can't tell if this is just vim fixing the lack of a proper trailing newline, but revert any whitespace change if possible. ================ Comment at: llvm/lib/Bitcode/Reader/BitcodeReader.cpp:1169 + case Attribute::SpeculativeLoadHardening: + return 1ULL << 60; case Attribute::Dereferenceable: ---------------- These appear to repeat LLVMBitcodes.h, unless I am mistaken. Weird. Anyway, fixing that is out of scope. Repository: rL LLVM https://reviews.llvm.org/D51157 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits