djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good.
Comment at: lib/Format/UnwrappedLineParser.cpp:2099
+ // After a protocol list, we can have a category (Obj-C generic
+ // category).
nit:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL311874: [X86] Add support for __builtin_cpu_init (authored
by ctopper).
Changed prior to commit:
https://reviews.llvm.org/D36336?vs=109800&id=112851#toc
Repository:
rL LLVM
https://reviews.llvm.org/
Author: ctopper
Date: Sun Aug 27 22:43:23 2017
New Revision: 311874
URL: http://llvm.org/viewvc/llvm-project?rev=311874&view=rev
Log:
[X86] Add support for __builtin_cpu_init
This adds builtin_cpu_init which will emit a call to cpu_indicator_init in
libgcc or compiler-rt.
This is needed to supp
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
One inline comment, but go ahead and commit after fixing that up.
Comment at: lib/CodeGen/CGBuiltin.cpp:7292
const CallExpr *E
mclow.lists added a comment.
Note: I suspect that the proposed change to `` fixes the problem,
but the new tests don't check that.
https://reviews.llvm.org/D32788
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
mclow.lists added a comment.
I applied the test change, but not the algorithm change, and the tests passed.
https://reviews.llvm.org/D32788
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
rsmith added inline comments.
Comment at: lib/Parse/ParseExprCXX.cpp:638
/// lambda-introducer lambda-declarator[opt] compound-statement
+/// lambda-introducer lambda-declarator[opt]
+/// compound-statement
We generally put terminals
Author: rsmith
Date: Sun Aug 27 17:31:35 2017
New Revision: 311868
URL: http://llvm.org/viewvc/llvm-project?rev=311868&view=rev
Log:
Add test for -Wc++17-compat warning for P0683R1.
Modified:
cfe/trunk/test/SemaCXX/cxx17-compat.cpp
Modified: cfe/trunk/test/SemaCXX/cxx17-compat.cpp
URL:
http
Author: rsmith
Date: Sun Aug 27 17:28:14 2017
New Revision: 311867
URL: http://llvm.org/viewvc/llvm-project?rev=311867&view=rev
Log:
[c++2a] P0683R1: Permit default member initializers for bit-fields.
This would be trivial, except that our in-memory and serialized representations
for FieldDecls a
johannes updated this revision to Diff 112845.
johannes retitled this revision from "Add
include/clang/Tooling/ASTDiff/ASTPatch.h" to "[clang-diff] Initial
implementation of patching".
johannes edited the summary of this revision.
johannes added a comment.
use rewriter to patch a third AST
htt
johannes created this revision.
Herald added a subscriber: klimek.
This way the variable name of a declaration is not included
https://reviews.llvm.org/D37201
Files:
test/Tooling/Inputs/clang-diff-basic-src.cpp
test/Tooling/clang-diff-basic.cpp
test/Tooling/clang-diff-html.test
Index: t
johannes created this revision.
Herald added a subscriber: klimek.
This affects overloaded operators, which are represented by a
CXXOperatorCallExpr whose first child is always a DeclRefExpr referring to the
operator. For infix, postfix and call operators we want the first argument
to be traversed
This revision was automatically updated to reflect the committed changes.
Closed by commit rL311865: [clang-diff] Treat CXXCtorInitializer as a node
(authored by krobelus).
Changed prior to commit:
https://reviews.llvm.org/D37002?vs=112134&id=112841#toc
Repository:
rL LLVM
https://reviews.l
Author: krobelus
Date: Sun Aug 27 15:52:20 2017
New Revision: 311865
URL: http://llvm.org/viewvc/llvm-project?rev=311865&view=rev
Log:
[clang-diff] Treat CXXCtorInitializer as a node
Reviewers: arphaman
Subscribers: cfe-commits, klimek
Differential Revision: https://reviews.llvm.org/D37002
Mod
EricWF added a comment.
@arphaman Do you mind if I commit my own version of this?
Repository:
rL LLVM
https://reviews.llvm.org/D37104
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
mgorny reopened this revision.
mgorny added a comment.
This revision is now accepted and ready to land.
I have reverted the changes for now to fix Android.
Repository:
rL LLVM
https://reviews.llvm.org/D26796
___
cfe-commits mailing list
cfe-commi
mgorny reopened this revision.
mgorny added a comment.
This revision is now accepted and ready to land.
I have reverted the changes for now to fix Android.
Repository:
rL LLVM
https://reviews.llvm.org/D26764
___
cfe-commits mailing list
cfe-commi
rsmith added inline comments.
Comment at: lib/AST/TemplateBase.cpp:64
} else {
Out << Val;
+// Handle cases where the value is too large to fit into the underlying
type
If `Val` is `LLONG_MIN`, this will still produce an integer too large for any
si
mehdi_amini added a comment.
> I'd like to also see a testcase for the situation where we trigger the
> emission of a declaration with an available_externally definition and then
> find we need to promote it to a "full" definition:
Added!
Comment at: clang/lib/CodeGen/CodeGe
Author: mgorny
Date: Sun Aug 27 13:38:43 2017
New Revision: 311861
URL: http://llvm.org/viewvc/llvm-project?rev=311861&view=rev
Log:
Revert r311836 - [Driver] Use arch type to find compiler-rt libraries (on Linux)
This causes a breakage on the Android build bot. Let's revert it until
we figure ou
Author: mehdi_amini
Date: Sun Aug 27 13:24:23 2017
New Revision: 311858
URL: http://llvm.org/viewvc/llvm-project?rev=311858&view=rev
Log:
CMake: only try to find the Z3 package when `CLANG_ANALYZER_BUILD_Z3` is ON
This avoids the spurious message:
Could NOT find Z3 (missing: Z3_LIBRARIES Z3_IN
This revision was automatically updated to reflect the committed changes.
Closed by commit rL311857: Emit static constexpr member as available_externally
definition (authored by mehdi_amini).
Changed prior to commit:
https://reviews.llvm.org/D34992?vs=109694&id=112836#toc
Repository:
rL LLVM
Author: mehdi_amini
Date: Sun Aug 27 13:24:09 2017
New Revision: 311857
URL: http://llvm.org/viewvc/llvm-project?rev=311857&view=rev
Log:
Emit static constexpr member as available_externally definition
By exposing the constant initializer, the optimizer can fold many
of these constructs.
Differe
v.g.vassilev updated this revision to Diff 112835.
v.g.vassilev added a comment.
Add a test case.
https://reviews.llvm.org/D34984
Files:
include/clang/Serialization/ASTReader.h
lib/Serialization/ASTReader.cpp
lib/Serialization/ASTWriter.cpp
test/PCH/token-literal-data.c
Index: test/PC
Author: faisalv
Date: Sun Aug 27 12:00:08 2017
New Revision: 311855
URL: http://llvm.org/viewvc/llvm-project?rev=311855&view=rev
Log:
revert changes from r311851.
The right answers here (and how clang needs to be tweaked) require further
analysis (ongoing cwg thread).
sorry.
Modified:
cfe/
v.g.vassilev added a comment.
@bruno, what's the fate of this?
https://reviews.llvm.org/D22638
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
v.g.vassilev added a comment.
@rsmith ping...
https://reviews.llvm.org/D34912
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
v.g.vassilev added a comment.
Sorry, undo ping... we have a test case.
https://reviews.llvm.org/D34912
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
v.g.vassilev added a comment.
ping...
https://reviews.llvm.org/D34912
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: sylvestre
Date: Sun Aug 27 10:34:06 2017
New Revision: 311854
URL: http://llvm.org/viewvc/llvm-project?rev=311854&view=rev
Log:
Fix two typos in the doc. Patch by kamleshbhalui on github
Modified:
cfe/trunk/docs/UsersManual.rst
Modified: cfe/trunk/docs/UsersManual.rst
URL:
http://ll
Author: faisalv
Date: Sun Aug 27 09:49:47 2017
New Revision: 311851
URL: http://llvm.org/viewvc/llvm-project?rev=311851&view=rev
Log:
Don't see through 'using member-declarations' when determining the relation of
any potential implicit object expression to the parent class of the member
function
vivekvpandya created this revision.
Herald added a subscriber: fhahn.
Clang changes related to Bug 32352 - Provide a way for
OptimizationRemarkEmitter::allowExtraAnalysis to check if (specific) remarks
are enabled
https://reviews.llvm.org/D37196
Files:
lib/CodeGen/CodeGenAction.cpp
Index:
v.g.vassilev accepted this revision.
v.g.vassilev added a comment.
This revision is now accepted and ready to land.
LGTM! I'd reword the commit message, saying that we intended to add a fast path
in `DeclContext::removeDecl` which checks if the decl is hidden to avoid
addition in the lookup tabl
szepet updated this revision to Diff 112824.
szepet added a comment.
Update based on comments.
https://reviews.llvm.org/D37103
Files:
lib/StaticAnalyzer/Core/AnalysisManager.cpp
lib/StaticAnalyzer/Core/ExprEngine.cpp
lib/StaticAnalyzer/Core/LoopUnrolling.cpp
test/Analysis/loop-unrolling
danielmartin created this revision.
Herald added a subscriber: klimek.
Objective C supports lightweight generics in categories. This patch
adds support for that in clang-format.
https://reviews.llvm.org/D37192
Files:
lib/Format/UnwrappedLineParser.cpp
unittests/Format/FormatTestObjC.cpp
I
rwols added a comment.
After digging into VSCode, I now think that presenting snippets is the wrong
way forward, and I believe the right way is to implement the
`signatureHelpProvider` protocol for method/function parameters. See:
https://github.com/Microsoft/vscode-docs/blob/master/docs/extens
Author: chapuni
Date: Sun Aug 27 04:46:05 2017
New Revision: 311846
URL: http://llvm.org/viewvc/llvm-project?rev=311846&view=rev
Log:
ClangCodeGenTests: Update libdeps.
Modified:
cfe/trunk/unittests/CodeGen/CMakeLists.txt
Modified: cfe/trunk/unittests/CodeGen/CMakeLists.txt
URL:
http://llvm
Author: vvassilev
Date: Sun Aug 27 04:31:01 2017
New Revision: 311845
URL: http://llvm.org/viewvc/llvm-project?rev=311845&view=rev
Log:
Add forgotten file in r311844.
Added:
cfe/trunk/unittests/CodeGen/IncrementalProcessingTest.cpp
Added: cfe/trunk/unittests/CodeGen/IncrementalProcessingTest
v.g.vassilev accepted this revision.
v.g.vassilev added a comment.
LGTM +ping!
https://reviews.llvm.org/D36820
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
v.g.vassilev closed this revision.
v.g.vassilev added a comment.
Landed in r311844.
https://reviews.llvm.org/D34059
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: vvassilev
Date: Sun Aug 27 04:27:30 2017
New Revision: 311844
URL: http://llvm.org/viewvc/llvm-project?rev=311844&view=rev
Log:
D34059: Get the file name for the symbol from the Module, not the SourceManager.
This allows multi-module / incremental compilation environments to have unique
i
v.g.vassilev added a comment.
A version of this landed in r311843. I am keeping in mind this discussion and
I'd like to follow up with @rjmccall once I open the more major review item
(libInterpreter).
https://reviews.llvm.org/D3
___
cfe-commi
Author: vvassilev
Date: Sun Aug 27 03:58:03 2017
New Revision: 311843
URL: http://llvm.org/viewvc/llvm-project?rev=311843&view=rev
Log:
D3: Teach codegen to work in incremental processing mode.
When isIncrementalProcessingEnabled is on we might want to produce multiple
llvm::Modules. This pat
v.g.vassilev updated this revision to Diff 112813.
v.g.vassilev added a comment.
Type& name -> Type &name.
https://reviews.llvm.org/D3
Files:
include/clang/CodeGen/ModuleBuilder.h
lib/CodeGen/ModuleBuilder.cpp
Index: lib/CodeGen/ModuleBuilder.cpp
==
mgorny added inline comments.
Comment at: test/include-fixer/yamldb_plugin.cpp:7
-// CHECK: yamldb_plugin.cpp:3:1: error: unknown type name 'foo'; did you mean
'foo'?
-// CHECK: Number FIX-ITs = 1
Differential is showing this a bit weird, all that's changed he
mgorny created this revision.
Support running the extra clang tool tests when the static analyzer
is disabled. Disable the relevant clang-tidy tests and one include-fixer
test that require it to work.
Previously, the tests were disabled entirely with
CLANG_ENABLE_STATIC_ANALYZER being false. Now,
v.g.vassilev updated this revision to Diff 112812.
v.g.vassilev marked an inline comment as done.
v.g.vassilev added a comment.
std::string& -> llvm::StringRef.
https://reviews.llvm.org/D3
Files:
include/clang/CodeGen/ModuleBuilder.h
lib/CodeGen/ModuleBuilder.cpp
Index: lib/CodeGen/Mo
mgorny resigned from this revision.
mgorny added a comment.
This revision is now accepted and ready to land.
I'm not going to block this but I agree with others that the PPC changes look
like they belong in a separate commit.
https://reviews.llvm.org/D36555
__
mgorny added a comment.
The problems:
1.
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-android/builds/2140/steps/annotate/logs/stdio
-- purely this change,
2.
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-android/builds/2146/steps/run%20instrumented%20asan%20tests%20%5Bi6
mgorny added a comment.
@eugenis, it seems that this broke the Android buildbot. Could you suggest an
appropriate course of action? I suppose we either have to fix Android-something
to use i386, or keep using i686 for Android. The latter I know how to do but
for the former, I have no clue where
zaks.anna added inline comments.
Comment at: lib/StaticAnalyzer/Core/SValBuilder.cpp:364
if (symLHS && symRHS &&
- (symLHS->computeComplexity() + symRHS->computeComplexity()) < MaxComp)
+ (symLHS->computeComplexity() + symRHS->computeComplexity()) < MaxComp)
re
zaks.anna added inline comments.
Comment at: lib/StaticAnalyzer/Core/AnalyzerOptions.cpp:190
+ /* Default = */ false);
+ return shouldUnrollLoops() || explicitlyIncludeLoopExit;
}
I would rather keep this method
This revision was automatically updated to reflect the committed changes.
Closed by commit rL311842: [cmake] Remove i686 target that is duplicate to i386
(authored by mgorny).
Changed prior to commit:
https://reviews.llvm.org/D26764?vs=112807&id=112808#toc
Repository:
rL LLVM
https://review
mgorny updated this revision to Diff 112807.
mgorny added a comment.
I'm going to commit this now to see if it helps with the Android buildbot.
Updating to the rebased patch that's going to be committed.
https://reviews.llvm.org/D26764
Files:
cmake/Modules/CompilerRTUtils.cmake
cmake/base-
zaks.anna added a comment.
I think we should have these is .rst format as this is what the rest of the
documentation predominantly uses. (Note, the formatting can be very basic, it's
the format that I care about.)
Otherwise, great to see this addition!
https://reviews.llvm.org/D36737
_
55 matches
Mail list logo
