echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.

One inline comment, but go ahead and commit after fixing that up.



================
Comment at: lib/CodeGen/CGBuiltin.cpp:7292
                                            const CallExpr *E) {
+  if (BuiltinID == X86::BI__builtin_cpu_init) {
+    llvm::FunctionType *FTy = llvm::FunctionType::get(VoidTy,
----------------
I realize it makes sense to put this here because it doesn't require the setup, 
but let's go ahead and just put it in the switch statement below. I don't think 
avoiding the bit of setup/etc below is worth the inconsistency. :)


https://reviews.llvm.org/D36336



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to