v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land.
LGTM! I'd reword the commit message, saying that we intended to add a fast path in `DeclContext::removeDecl` which checks if the decl is hidden to avoid addition in the lookup tables. That caused problems with modules, because the modules system extends the definition of visibility and this is a test making sure we do not reintroduce such an issue. Repository: rL LLVM https://reviews.llvm.org/D37180 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits