zaks.anna added inline comments.
================
Comment at: lib/StaticAnalyzer/Core/AnalyzerOptions.cpp:190
+ /* Default = */ false);
+ return shouldUnrollLoops() || explicitlyIncludeLoopExit;
}
----------------
I would rather keep this method as is and add the extra logic elsewhere (ex:
the place where includeLoopExitInCFG is used). To me,
AnalyzerOptions::includeLoopExitInCFG() returns the value of the corresponding
parameter and I would not expect it to use anything else.
================
Comment at: test/Analysis/loop-unrolling.cpp:276
+
+int loopexit_while_empty_loopstack() {
+ if (getNum())
----------------
nit: "loop" "exit" and "loop" "stack" are separate words, so consider using "_"
to separate them.
https://reviews.llvm.org/D37103
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
