[PATCH] D21120: clang-rename: implement renaming of classes inside dynamic_cast

vmiklos created this revision. vmiklos added a reviewer: klimek. vmiklos added a subscriber: cfe-commits. Refactor to do the same as what is done already for static_cast. http://reviews.llvm.org/D21120 Files: clang-rename/USRLocFinder.cpp test/clang-rename/DynamicCastExpr.cpp Index: test/cl

r272119 - [AVX512] Reformat macro intrinsics, ensure arguments have proper typecasts, ensure result is typecasted back to the generic types.

Author: ctopper Date: Wed Jun 8 01:08:07 2016 New Revision: 272119 URL: http://llvm.org/viewvc/llvm-project?rev=272119&view=rev Log: [AVX512] Reformat macro intrinsics, ensure arguments have proper typecasts, ensure result is typecasted back to the generic types. Modified: cfe/trunk/lib/Hea

r272118 - [X86] Put parentheses around macro arguments in intrinsics.

Author: ctopper Date: Wed Jun 8 01:08:04 2016 New Revision: 272118 URL: http://llvm.org/viewvc/llvm-project?rev=272118&view=rev Log: [X86] Put parentheses around macro arguments in intrinsics. Modified: cfe/trunk/lib/Headers/avx512fintrin.h Modified: cfe/trunk/lib/Headers/avx512fintrin.h UR

[libcxxabi] r272102 - Creating release directory for release_381.

Author: tstellar Date: Tue Jun 7 22:27:22 2016 New Revision: 272102 URL: http://llvm.org/viewvc/llvm-project?rev=272102&view=rev Log: Creating release directory for release_381. Added: libcxxabi/tags/RELEASE_381/ ___ cfe-commits mailing list cfe-c

[libunwind] r272115 - Creating release candidate rc1 from release_381 branch

Author: tstellar Date: Tue Jun 7 22:27:35 2016 New Revision: 272115 URL: http://llvm.org/viewvc/llvm-project?rev=272115&view=rev Log: Creating release candidate rc1 from release_381 branch Added: libunwind/tags/RELEASE_381/rc1/ - copied from r272114, libunwind/branches/release_38/ ___

[libcxxabi] r272103 - Creating release candidate rc1 from release_381 branch

Author: tstellar Date: Tue Jun 7 22:27:23 2016 New Revision: 272103 URL: http://llvm.org/viewvc/llvm-project?rev=272103&view=rev Log: Creating release candidate rc1 from release_381 branch Added: libcxxabi/tags/RELEASE_381/rc1/ (props changed) - copied from r272102, libcxxabi/branche

[libunwind] r272114 - Creating release directory for release_381.

Author: tstellar Date: Tue Jun 7 22:27:34 2016 New Revision: 272114 URL: http://llvm.org/viewvc/llvm-project?rev=272114&view=rev Log: Creating release directory for release_381. Added: libunwind/tags/RELEASE_381/ ___ cfe-commits mailing list cfe-c

[libcxx] r272101 - Creating release candidate rc1 from release_381 branch

Author: tstellar Date: Tue Jun 7 22:27:21 2016 New Revision: 272101 URL: http://llvm.org/viewvc/llvm-project?rev=272101&view=rev Log: Creating release candidate rc1 from release_381 branch Added: libcxx/tags/RELEASE_381/rc1/ (props changed) - copied from r272100, libcxx/branches/rele

[libcxx] r272100 - Creating release directory for release_381.

Author: tstellar Date: Tue Jun 7 22:27:19 2016 New Revision: 272100 URL: http://llvm.org/viewvc/llvm-project?rev=272100&view=rev Log: Creating release directory for release_381. Added: libcxx/tags/RELEASE_381/ ___ cfe-commits mailing list cfe-comm

Re: [PATCH] D21082: Do not assume that -fsanitize=address is valid option in clang tests

vitalybuka added a comment. http://reviews.llvm.org/D21117 Repository: rL LLVM http://reviews.llvm.org/D21082 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D21117: Specify target in lifetime-asan test.

vitalybuka created this revision. vitalybuka added reviewers: pcc, eugenis. vitalybuka added subscribers: kubabrecka, chapuni, christof, cfe-commits. Some target platforms -fsanitize=address. http://reviews.llvm.org/D21117 Files: test/CodeGen/lifetime-asan.c Index: test/CodeGen/lifetime-asan.

Re: [PATCH] D21082: Do not assume that -fsanitize=address is valid option in clang tests

vitalybuka added a comment. Oh, I see, most asan tests in clang use cross-compiler, e.g.: -target x86_64-linux-gnu Repository: rL LLVM http://reviews.llvm.org/D21082 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/c

Re: [PATCH] D21082: Do not assume that -fsanitize=address is valid option in clang tests

vitalybuka requested changes to this revision. vitalybuka added a comment. This revision now requires changes to proceed. It was accepted accidentally. Repository: rL LLVM http://reviews.llvm.org/D21082 ___ cfe-commits mailing list cfe-commits@li

Re: [PATCH] D21082: Do not assume that -fsanitize=address is valid option in clang tests

vitalybuka accepted this revision. vitalybuka added a comment. This revision is now accepted and ready to land. Actually there are other tests with -fsanitize=address I see only difference in %clang vs %clang_cc1? Could you try this? Repository: rL LLVM http://reviews.llvm.org/D21082 _

Re: [PATCH] D21113: Add support for case-insensitive header lookup

compnerd added a comment. This looks good to me. Thanks for picking this up! And thanks for the perf numbers! Comment at: lib/Basic/VirtualFileSystem.cpp:401 @@ +400,3 @@ +IntrusiveRefCntPtr Base) +: Base(Base) {} + Probably can inline this in the hea

Re: [PATCH] D17516: AMDGPU: Verify subtarget specific builtins

arsenm closed this revision. arsenm added a comment. r272091 http://reviews.llvm.org/D17516 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r272091 - AMDGPU: Verify subtarget specific builtins

Author: arsenm Date: Tue Jun 7 20:56:42 2016 New Revision: 272091 URL: http://llvm.org/viewvc/llvm-project?rev=272091&view=rev Log: AMDGPU: Verify subtarget specific builtins Cleanup setup of subtarget features. Added: cfe/trunk/test/CodeGenOpenCL/builtins-amdgcn-error.cl cfe/trunk/test

Re: [PATCH] D21082: Do not assume that -fsanitize=address is valid option in clang tests

vitalybuka added a comment. I guess you can remove // UNSUPPORTED: mingw32 added by cfe/trunk@271509 Repository: rL LLVM http://reviews.llvm.org/D21082 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/

Re: [PATCH] D20709: For RenderScript, set alignment and width of long to 64-bits

rsmith added a comment. In http://reviews.llvm.org/D20709#446595, @srhines wrote: > There is a coming patch that adds a single attribute (for "kernel"), that has > error checking to ensure that it is only used by our RenderScript targets. I > assume that the cleanest way to retain that diagnost

Re: [PATCH] D21113: Add support for case-insensitive header lookup

hans updated this revision to Diff 59982. hans added a comment. Add --show-includes test. http://reviews.llvm.org/D21113 Files: include/clang/Basic/VirtualFileSystem.h include/clang/Driver/Options.td include/clang/Lex/HeaderSearchOptions.h lib/Basic/VirtualFileSystem.cpp lib/Driver/To

[PATCH] D21113: Add support for case-insensitive header lookup

hans created this revision. hans added reviewers: rsmith, rnk, thakis. hans added subscribers: compnerd, majnemer, benlangmuir, cfe-commits. This is useful when dealing with headers that are normally used on case-insensitive filesystems, such as the Windows SDK, when cross-compiling from a file-

[PATCH] D21111: Avoid accessing an invalid PresumedLoc

jordan_rose created this revision. jordan_rose added a reviewer: rsmith. jordan_rose added a subscriber: cfe-commits. jordan_rose set the repository for this revision to rL LLVM. DiagnosticNoteRenderer asserts trying to emit its "while building module Foo imported from bar.h:5" note when the pres

r272080 - [Sema] Teach CheckPlaceholderExpr about unaddressable functions.

Author: gbiv Date: Tue Jun 7 19:34:22 2016 New Revision: 272080 URL: http://llvm.org/viewvc/llvm-project?rev=272080&view=rev Log: [Sema] Teach CheckPlaceholderExpr about unaddressable functions. Given the following C++: ``` void foo(); void foo() __attribute__((enable_if(false, ""))); bool bar

r272079 - [ItaniumMangle] Mangle dependent __underlying_type correctly

Author: majnemer Date: Tue Jun 7 19:34:15 2016 New Revision: 272079 URL: http://llvm.org/viewvc/llvm-project?rev=272079&view=rev Log: [ItaniumMangle] Mangle dependent __underlying_type correctly We attempted to use the UnaryTransformType's UnderlyingType instead of it's BaseType. This is not co

Re: [PATCH] D19843: Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

eric_niebler updated the summary for this revision. eric_niebler updated this revision to Diff 59974. eric_niebler added a comment. Rework the patch to only warn by default for include files //not// found in system include directories, unless they are known "standard" headers that should be port

Re: [PATCH] D21107: Generate codeview for array types

amccarth added inline comments. Comment at: lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:785 @@ +784,3 @@ + TypeIndex IndexType = Asm->MAI->getPointerSize() == 8 ? + TypeIndex(SimpleTypeKind::UInt64) : + TypeIndex(SimpleTypeKind::UInt32); majnemer wrote: >

Re: [PATCH] D21107: Generate codeview for array types

majnemer added a subscriber: majnemer. Comment at: lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:785 @@ +784,3 @@ + TypeIndex IndexType = Asm->MAI->getPointerSize() == 8 ? + TypeIndex(SimpleTypeKind::UInt64) : + TypeIndex(SimpleTypeKind::UInt32); They don't

[PATCH] D21107: Generate codeview for array types

amccarth created this revision. amccarth added a reviewer: rnk. amccarth added a subscriber: cfe-commits. Creates codeview type records for arrays and adds a simple test for one. http://reviews.llvm.org/D21107 Files: lib/CodeGen/AsmPrinter/CodeViewDebug.cpp lib/CodeGen/AsmPrinter/CodeViewD

r272067 - [docs] Coverage: Explain how to avoid static initializers

Author: vedantk Date: Tue Jun 7 17:25:29 2016 New Revision: 272067 URL: http://llvm.org/viewvc/llvm-project?rev=272067&view=rev Log: [docs] Coverage: Explain how to avoid static initializers Modified: cfe/trunk/docs/SourceBasedCodeCoverage.rst Modified: cfe/trunk/docs/SourceBasedCodeCoverag

[PATCH] D21104: [CodeGen][ObjC] Block captures should inherit the type of the captured field in the enclosing lambda or block

ahatanak created this revision. ahatanak added a reviewer: rjmccall. ahatanak added a subscriber: cfe-commits. This patch fixes a bug in code-gen where it uses the type of the declared variable rather than the type of the capture of the enclosing lambda or block for the block capture. For exampl

Re: [PATCH] D17516: AMDGPU: Verify subtarget specific builtins

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. Seems pretty reasonable. If I missed anything we can pick it up later. -eric Comment at: lib/Basic/Targets.cpp:2010 @@ +2009,3 @@ + + // XXX - What does the member GPU m

Re: [PATCH] D21066: Pass MCSubtargetInfo instead of CPU and Triple to createMCAsmBackend

echristo requested changes to this revision. echristo added a comment. This revision now requires changes to proceed. I followed up in the original thread, I don't think this is going to be the right direction. Thanks. -eric http://reviews.llvm.org/D21066 __

Re: [PATCH] D20933: Preallocate ExplodedNode hash table

bcraig updated this revision to Diff 59950. bcraig added a comment. Uploading more context. http://reviews.llvm.org/D20933 Files: include/clang/StaticAnalyzer/Core/PathSensitive/ExplodedGraph.h lib/StaticAnalyzer/Core/CoreEngine.cpp Index: lib/StaticAnalyzer/Core/CoreEngine.cpp ===

Re: 3.8 Merge Request: r259776

Hi Tom, I'm on a vacation right now without an access to the computer. Could you do it yourself? Best regards, Alexey Bataev Отправлено с iPhone > 7 июня 2016 г., в 22:49, Tom Stellard написал(а): > > Hi Alexy, > > Can you merge this? > > Thanks, > Tom > >> On Tue, Jun 07, 2016 at 09:40:44A

Re: [PATCH] D20933: Preallocate ExplodedNode hash table

bcraig added a comment. tldr; I'm going to recommend we stick with the current algorithm, but I only have partial data to back that up. For the pile of LLVM projects that I am currently building (llvm, clang, libcxx, libcxxabi), 18.9% of all analyzed functions hit the maximum step count. For

RE: r269670 - [OpenCL] Add supported OpenCL extensions to target info.

Hi Jeroen, Thanks for your consideration. I am OK with removing those extensions which do not affect language or builtin functions. After removing them, they will be unknown to Clang. If a user tries to enable them, a warning will be emitted saying the extension is unknown. Anastasia, are you

[PATCH] D21099: [Sema] Teach -Wcast-align to look at the aligned attribute of the declared variables

ahatanak created this revision. ahatanak added a subscriber: cfe-commits. Sema::CheckCastAlign currently ignores the aligned attribute attached to the declared variables, which causes clang to issue spurious warnings. This patch fixes the bug. http://reviews.llvm.org/D21099 Files: lib/Sema/S

[libcxx] r272050 - Added notes for a bunch of the issues

Author: marshall Date: Tue Jun 7 15:05:57 2016 New Revision: 272050 URL: http://llvm.org/viewvc/llvm-project?rev=272050&view=rev Log: Added notes for a bunch of the issues Modified: libcxx/trunk/www/upcoming_meeting.html Modified: libcxx/trunk/www/upcoming_meeting.html URL: http://llvm.org

Re: 3.8 Merge Request: r259776

Hi Alexy, Can you merge this? Thanks, Tom On Tue, Jun 07, 2016 at 09:40:44AM -0700, Richard Smith wrote: > It's larger than I'd like for a merge onto the branch, but yes, it looks OK. > > On 7 Jun 2016 9:20 a.m., "Tom Stellard via cfe-commits" < > cfe-commits@lists.llvm.org> wrote: > > > Hi Ri

[PATCH] D21096: [libcxx] [test] Fix MSVC warning C4125 "decimal digit terminates octal escape sequence".

STL_MSFT created this revision. STL_MSFT added reviewers: mclow.lists, EricWF. STL_MSFT added a subscriber: cfe-commits. Fix MSVC warning C4125 "decimal digit terminates octal escape sequence". MSVC somewhat justifiably warns when it sees an octal escape immediately followed by a decimal digit,

[PATCH] D21095: [libcxx] [test] Fix another MSVC warning C4101 "unreferenced local variable".

STL_MSFT created this revision. STL_MSFT added reviewers: mclow.lists, EricWF. STL_MSFT added a subscriber: cfe-commits. Fix another MSVC warning C4101 "unreferenced local variable". http://reviews.llvm.org/D21095 Files: test/std/thread/thread.threads/thread.thread.class/thread.thread.member/

[PATCH] D21094: [libcxx] [test] In test/support/test_allocator.h, fix construct() to avoid moving immovable types.

STL_MSFT created this revision. STL_MSFT added reviewers: mclow.lists, EricWF. STL_MSFT added a subscriber: cfe-commits. In test/support/test_allocator.h, fix construct() to avoid moving immovable types. This improves the allocator's conformance, and fixes compiler errors with MSVC's STL. The s

[PATCH] D21093: [libcxx] [test] In unord.hash/floating.pass.cpp, add a static_cast to fix a truncation warning.

STL_MSFT created this revision. STL_MSFT added reviewers: mclow.lists, EricWF. STL_MSFT added a subscriber: cfe-commits. In unord.hash/floating.pass.cpp, add a static_cast to fix a truncation warning. Fixes MSVC warning C4305 "'argument': truncation from 'double' to 'const std::hash::_Kty'". ht

[PATCH] D21092: [libcxx] [test] Fix vector tests that were using ints copy-pasted from vector tests.

STL_MSFT created this revision. STL_MSFT added reviewers: mclow.lists, EricWF. STL_MSFT added a subscriber: cfe-commits. Fix vector tests that were using ints copy-pasted from vector tests. I copied the bool a[] 0/1 pattern from another vector test. Fixes MSVC warning C4305 "'argument': truncati

Re: [PATCH] D21036: Misplaced const-qualification with typedef types

On Tue, Jun 7, 2016 at 3:06 PM, Haojian Wu wrote: > hokein added a comment. > > @aaron.ballman, you forgot to add the check in docs/ReleaseNotes.rst. Added in a separate commit (r272026). ~Aaron > > > http://reviews.llvm.org/D21036 > > > ___ cfe-commi

Re: [PATCH] D20921: [libcxx] [test] Slightly rearrange scopes in order to avoid shadowing M typedefs.

STL_MSFT closed this revision. STL_MSFT added a comment. Marshall checked this one in too, closing. http://reviews.llvm.org/D20921 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20922: [libcxx] [test] Rename global "x" to "testcases" in complex.number/cases.h and make it const for safety.

STL_MSFT closed this revision. STL_MSFT added a comment. Marshall checked this in, so I'm closing this. http://reviews.llvm.org/D20922 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21036: Misplaced const-qualification with typedef types

hokein added a comment. @aaron.ballman, you forgot to add the check in docs/ReleaseNotes.rst. http://reviews.llvm.org/D21036 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21082: Do not assume that -fsanitize=address is valid option in clang tests

kubabrecka added a subscriber: kubabrecka. kubabrecka added a comment. This doesn’t make sense to me, Clang is able to produce ASanified code even when the compiler itself isn’t ASanified (that’s what LLVM_USE_SANITIZER does). Where exactly is this test failing? Repository: rL LLVM http://

Re: [PATCH] D21020: [clang-tidy] readability-identifier-naming - Support for Macros

Eugene.Zelenko added inline comments. Comment at: docs/ReleaseNotes.rst:262 @@ -261,1 +261,3 @@ +- Updated `readability-identifier-naming-check + `_ Please put this not in alphab

[clang-tools-extra] r272042 - [Clang-tidy] Alphabetical checks order in release notes.

Author: eugenezelenko Date: Tue Jun 7 13:38:42 2016 New Revision: 272042 URL: http://llvm.org/viewvc/llvm-project?rev=272042&view=rev Log: [Clang-tidy] Alphabetical checks order in release notes. Highlight return statement in misc-unconventional-assign-operator documentation. Modified: clan

Re: [clang-tools-extra] r272038 - [Clang-tidy] Documentation style consistency.

On Tue, Jun 7, 2016 at 2:29 PM, Eugene Zelenko via cfe-commits wrote: > Author: eugenezelenko > Date: Tue Jun 7 13:29:15 2016 > New Revision: 272038 > > URL: http://llvm.org/viewvc/llvm-project?rev=272038&view=rev > Log: > [Clang-tidy] Documentation style consistency. Thank you for fixing those

[clang-tools-extra] r272038 - [Clang-tidy] Documentation style consistency.

Author: eugenezelenko Date: Tue Jun 7 13:29:15 2016 New Revision: 272038 URL: http://llvm.org/viewvc/llvm-project?rev=272038&view=rev Log: [Clang-tidy] Documentation style consistency. Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst clang-tools-extra/trunk/docs/clang-tidy/checks/

[libcxx] r272029 - Added notes about the issues for Oulu

Author: marshall Date: Tue Jun 7 12:54:38 2016 New Revision: 272029 URL: http://llvm.org/viewvc/llvm-project?rev=272029&view=rev Log: Added notes about the issues for Oulu Modified: libcxx/trunk/www/upcoming_meeting.html Modified: libcxx/trunk/www/upcoming_meeting.html URL: http://llvm.org

Re: [PATCH] D20687: [ASTMatchers] Make isNoThrow and hasDynamicExceptionSpec polymorphic for use with both functionDecl and functionProtoType

aaron.ballman closed this revision. aaron.ballman added a comment. Committed in r272028. http://reviews.llvm.org/D20687 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r272028 - Make isNoThrow and hasDynamicExceptionSpec polymorphic so they can be used with both functionDecl and functionPrototype matchers.

Author: aaronballman Date: Tue Jun 7 12:34:45 2016 New Revision: 272028 URL: http://llvm.org/viewvc/llvm-project?rev=272028&view=rev Log: Make isNoThrow and hasDynamicExceptionSpec polymorphic so they can be used with both functionDecl and functionPrototype matchers. Patch by Don Hinton. Modif

[clang-tools-extra] r272027 - Fixing a build bot issue with duplicate explicit instantiations.

Author: aaronballman Date: Tue Jun 7 12:32:07 2016 New Revision: 272027 URL: http://llvm.org/viewvc/llvm-project?rev=272027&view=rev Log: Fixing a build bot issue with duplicate explicit instantiations. Modified: clang-tools-extra/trunk/test/clang-tidy/misc-misplaced-const.cpp Modified: cla

[clang-tools-extra] r272026 - Adding a release note for the misc-misplaced-const check added in r272025.

Author: aaronballman Date: Tue Jun 7 12:29:49 2016 New Revision: 272026 URL: http://llvm.org/viewvc/llvm-project?rev=272026&view=rev Log: Adding a release note for the misc-misplaced-const check added in r272025. Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst Modified: clang-tools-

Re: [PATCH] D21036: Misplaced const-qualification with typedef types

aaron.ballman closed this revision. aaron.ballman added a comment. Committed in r272025. http://reviews.llvm.org/D21036 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] r272025 - Add the misc-misplaced-const check to clang-tidy, which diagnoses when a const-qualifier is applied to a typedef of pointer type rather than to the pointee type.

Author: aaronballman Date: Tue Jun 7 12:22:47 2016 New Revision: 272025 URL: http://llvm.org/viewvc/llvm-project?rev=272025&view=rev Log: Add the misc-misplaced-const check to clang-tidy, which diagnoses when a const-qualifier is applied to a typedef of pointer type rather than to the pointee t

Re: [PATCH] D21036: Misplaced const-qualification with typedef types

aaron.ballman added inline comments. Comment at: clang-tidy/misc/MisplacedConstCheck.cpp:23 @@ +22,3 @@ + valueDecl(hasType(isConstQualified()), +hasType(typedefType(hasDeclaration( +typedefDecl(hasType(pointerType(unless(pointee( -

Re: [PATCH] D21036: Misplaced const-qualification with typedef types

sbenza accepted this revision. This revision is now accepted and ready to land. Comment at: clang-tidy/misc/MisplacedConstCheck.cpp:22 @@ +21,3 @@ + Finder->addMatcher( + valueDecl(allOf(hasType(isConstQualified()), + hasType(typedefType(hasDeclaration(

Re: [PATCH] D21036: Misplaced const-qualification with typedef types

aaron.ballman updated this revision to Diff 59906. aaron.ballman marked 2 inline comments as done. aaron.ballman added a comment. Corrected more review feedback. http://reviews.llvm.org/D21036 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/MiscTidyModule.cpp clang-tidy/misc/Misplac

Re: [PATCH] D21036: Misplaced const-qualification with typedef types

aaron.ballman added inline comments. Comment at: clang-tidy/misc/MisplacedConstCheck.cpp:22 @@ +21,3 @@ + Finder->addMatcher( + valueDecl(allOf(hasType(isConstQualified()), + hasType(typedefType(hasDeclaration( sbenza wrote: > allOf() is

Re: [PATCH] D21036: Misplaced const-qualification with typedef types

sbenza added inline comments. Comment at: clang-tidy/misc/MisplacedConstCheck.cpp:22 @@ +21,3 @@ + Finder->addMatcher( + valueDecl(allOf(hasType(isConstQualified()), + hasType(typedefType(hasDeclaration( allOf() is unnecessary =

Re: [PATCH] D21036: Misplaced const-qualification with typedef types

sbenza added a comment. In http://reviews.llvm.org/D21036#450935, @aaron.ballman wrote: > In http://reviews.llvm.org/D21036#450106, @sbenza wrote: > > > I think this would be more interesting with macros. > > Eg triggering in code like this: > > > > #define FOO(type, op) const type& X = op() >

Re: [PATCH] D20867: [PCH] Fix timestamp check on windows hosts.

On 7 Jun 2016 7:52 a.m., "pierre gousseau" wrote: > > pgousseau added a comment. > > > > On Linux, if the timestamp of a header file, included in the pch, is modified, then including the pch without regenerating it causes a fatal error, which is reasonable. > > > > > > > On Windows the check is i

Re: [PATCH] D20328: [libcxx] Externally threaded libc++ variant

rmaprath added a comment. In http://reviews.llvm.org/D20328#451210, @STL_MSFT wrote: > [Asiri Rathnayake] > > > The `constexpr` mutex constructor is apparently also a > > > pain point on windows [1], I'm sure @STL_MSFT knows more about it. > > > That's because of MSVC-specific issues, where we n

Re: [PATCH] D21081: MPI-Checker patch for Clang Static Analyzer

dcoughlin added a comment. Here is the ASan report. It looks to me like the issue is that MPIChecker is holding on a reference to a clang::ento::BugReporter after the lifetime of the BugReporter has ended. The BugReporter lives in ExprEngine and the analyzer creates a new ExprEngine for each to

[PATCH] D21082: Do not assume that -fsanitize=address is valid option in clang tests

christof created this revision. christof added reviewers: vitalybuka, chapuni. christof added a subscriber: cfe-commits. christof set the repository for this revision to rL LLVM. The asan tests should only run on builds that have LLVM_USE_SANITIZER set. The feature 'asan' reflects this and is req

RE: [PATCH] D20328: [libcxx] Externally threaded libc++ variant

[Asiri Rathnayake] > The `constexpr` mutex constructor is apparently also a > pain point on windows [1], I'm sure @STL_MSFT knows more about it. That's because of MSVC-specific issues, where we need to dynamically switch between WinAPI and ConcRT implementations depending on whether the end user'

Re: 3.8 Merge Request: r259776

It's larger than I'd like for a merge onto the branch, but yes, it looks OK. On 7 Jun 2016 9:20 a.m., "Tom Stellard via cfe-commits" < cfe-commits@lists.llvm.org> wrote: > Hi Richard, > > Is this OK for the 3.8 branch? > > reviews.llvm.org/rL259776 > > -Tom > > On Mon, May 30, 2016 at 11:35:04AM

Re: [PATCH] D20328: [libcxx] Externally threaded libc++ variant

rmaprath added a comment. In http://reviews.llvm.org/D20328#451197, @rmaprath wrote: > In http://reviews.llvm.org/D20328#451178, @mclow.lists wrote: > > > Also, I don't see how this can be retargeted "at runtime"; are you implying > > that someone can choose at program launch time what threading

Re: [PATCH] D20328: [libcxx] Externally threaded libc++ variant

rmaprath added a subscriber: STL_MSFT. rmaprath added a comment. In http://reviews.llvm.org/D20328#451178, @mclow.lists wrote: > Also, I don't see how this can be retargeted "at runtime"; are you implying > that someone can choose at program launch time what threading system to use? Yup, users

Re: 3.8 Merge Request: r259776

Hi Richard, Is this OK for the 3.8 branch? reviews.llvm.org/rL259776 -Tom On Mon, May 30, 2016 at 11:35:04AM +, Hahnfeld, Jonas wrote: > Assuming I got it right... > > > -Original Message- > > From: Alexey Bataev [mailto:a.bat...@hotmail.com] > > Sent: Monday, May 30, 2016 1:31 PM

Re: [PATCH] D21081: MPI-Checker patch for Clang Static Analyzer

dcoughlin added a comment. Alexander, When I committed your patch, the AddressSanitizer bots found a memory corruption issue so I reverted it. This will need to be fixed before we can commit the patch. Since Phabricator automatically closed http://reviews.llvm.org/D12761, I've created a new re

Re: [PATCH] D20948: [OpenCL] Fix access qualifiers handling for typedefs

asavonic updated this revision to Diff 59890. asavonic added a comment. - Cleanup images-typedef.cl - Fix typo in SemaType.cpp - Change diagnostic: error when access qualifier applied to a typedef http://reviews.llvm.org/D20948 Files: include/clang/Basic/Attr.td include/clang/Basic/Diagnost

Re: [PATCH] D20948: [OpenCL] Fix access qualifiers handling for typedefs

asavonic updated this revision to Diff 59893. asavonic marked 3 inline comments as done. asavonic added a comment. - Fix images-typedef.cl for OpenCL 2.0 http://reviews.llvm.org/D20948 Files: include/clang/Basic/Attr.td include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sema/Attribu

[PATCH] D21081: MPI-Checker patch for Clang Static Analyzer

dcoughlin created this revision. dcoughlin added reviewers: zaks.anna, dcoughlin, Alexander_Droste. dcoughlin added a subscriber: cfe-commits. (Cloning the revision for the ASan issue since the old one is closed and can't be re-opened) This patch adds a static analysis checker to verify the corr

Re: [PATCH] D20328: [libcxx] Externally threaded libc++ variant

mclow.lists added a comment. Some nits while reading this. More to come. Also, I don't see how this can be retargeted "at runtime"; are you implying that someone can choose at program launch time what threading system to use? How could that work given (say) a constexpr constructor for a mutex t

Re: [PATCH] D20921: [libcxx] [test] Slightly rearrange scopes in order to avoid shadowing M typedefs.

mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. Landed as revision 272018 http://reviews.llvm.org/D20921 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/

[libcxx] r272018 - Avoid Shadowing warnings in the associative containers tests. Thanks to STL for the patch.

Author: marshall Date: Tue Jun 7 10:49:39 2016 New Revision: 272018 URL: http://llvm.org/viewvc/llvm-project?rev=272018&view=rev Log: Avoid Shadowing warnings in the associative containers tests. Thanks to STL for the patch. Modified: libcxx/trunk/test/std/containers/associative/map/map.sp

Re: [PATCH] D21050: [clang-tidy] correct clang-tidy-diff.py help message

sugak added a comment. Thank you for the review! I need someone to commit this for me :) http://reviews.llvm.org/D21050 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20328: [libcxx] Externally threaded libc++ variant

rmaprath added a comment. @mclow.lists, @ericwf: Ping. @bcraig: I guess you wouldn't be able to let this through on your own? (in case if there isn't much interest in this functionality from others). Eric might be away though (didn't see many emails from him), so I'll hold off for now. / Asiri

Re: [PATCH] D20867: [PCH] Fix timestamp check on windows hosts.

It seems Phabricator did not picked up Richard's message so I have manually copied and replied to it via Phabricator's web interface. Cheers, Pierre On 6 June 2016 at 21:53, Richard Smith wrote: > On Wed, Jun 1, 2016 at 8:33 AM, pierre gousseau via cfe-commits < > cfe-commits@lists.llvm.org> w

Re: [PATCH] D20948: [OpenCL] Fix access qualifiers handling for typedefs

asavonic added inline comments. Comment at: test/SemaOpenCL/images-typedef.cl:40 @@ +39,3 @@ + myWrite(img); // expected-error {{passing 'img1d_ro_default' (aka '__read_only image1d_t') to parameter of incompatible type '__write_only image1d_t'}} +} + No, but w

Re: [PATCH] D20867: [PCH] Fix timestamp check on windows hosts.

pgousseau added a comment. > > On Linux, if the timestamp of a header file, included in the pch, is > > modified, then including the pch without regenerating it causes a fatal > > error, which is reasonable. > > > On Windows the check is ifdefed out, allowing the compilation to continue > >

Re: [PATCH] D20867: [PCH] Fix timestamp check on windows hosts.

pgousseau updated this revision to Diff 59887. pgousseau added a comment. Following Bruno's comment: - Remove call to sleep using touch -m -a -t http://reviews.llvm.org/D20867 Files: include/clang/Driver/CC1Options.td include/clang/Frontend/FrontendOptions.h lib/Frontend/CompilerInvocati

[PATCH] D21075: Correct invalid end location in diagnostics for some identifiers.

erikjv created this revision. erikjv added reviewers: bkramer, klimek. erikjv added a subscriber: cfe-commits. Declaration names in DeclSpec had only their start set to a valid location, so when the type specifier was missing, only the carret would be shown at the first character of the name of a

Re: [PATCH] D21074: Correct invalid end location in diagnostics for some identifiers.

erikjv abandoned this revision. erikjv added a comment. Wrong patch http://reviews.llvm.org/D21074 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D21074: Correct invalid end location in diagnostics for some identifiers.

erikjv created this revision. erikjv added reviewers: bkramer, klimek. erikjv added a subscriber: cfe-commits. Declaration names in DeclSpec had only their start set to a valid location, so when the type specifier was missing, only the carret would be shown at the first character of the name of a

Re: [PATCH] D15994: Allow for unfinished #if blocks in preambles.

erikjv abandoned this revision. erikjv added a comment. This will give errors about unbalanced #if/#endif for header guards. http://reviews.llvm.org/D15994 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman

Re: [PATCH] D20687: [ASTMatchers] Make isNoThrow and hasDynamicExceptionSpec polymorphic for use with both functionDecl and functionProtoType

hintonda added a comment. Thanks Aaron. If you could commit for me, I'd appreciate it. Thanks again... http://reviews.llvm.org/D20687 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

Re: [PATCH] D20687: [ASTMatchers] Make isNoThrow and hasDynamicExceptionSpec polymorphic for use with both functionDecl and functionProtoType

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for working on this! http://reviews.llvm.org/D20687 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://

Re: [PATCH] D21014: [Clang][AVX512][Intrinsics] Adding intrinsics reduce_[round]_{ss|sd} to clang

This revision was automatically updated to reflect the committed changes. Closed by commit rL272012: [clang][AVX512][Intrinsics] Adding intrinsics reduce_[round]_{ss|sd} to clang (authored by mzuckerm). Changed prior to commit: http://reviews.llvm.org/D21014?vs=59697&id=59882#toc Repository:

r272012 - [clang][AVX512][Intrinsics] Adding intrinsics reduce_[round]_{ss|sd} to clang

Author: mzuckerm Date: Tue Jun 7 09:00:20 2016 New Revision: 272012 URL: http://llvm.org/viewvc/llvm-project?rev=272012&view=rev Log: [clang][AVX512][Intrinsics] Adding intrinsics reduce_[round]_{ss|sd} to clang Differential Revision: http://reviews.llvm.org/D21014 Modified: cfe/trunk/incl

Re: [PATCH] D21023: [mips] Defer validity check for CPU/ABI pairs and improve error message for invalid cases.

atanasyan accepted this revision. atanasyan added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D21023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/

[PATCH] D21072: [mips] Account for -mabi when determining whether IAS is the default or not.

dsanders created this revision. dsanders added subscribers: jfb, dschuff, cfe-commits. dsanders added a dependency: D21070: Pass the ABI in the triple when appropriate (currently for MIPS) for 'clang -cc1' and 'clang -cc1as'. Herald added subscribers: sdardis, srhines, danalbert, tberghammer. Thi

Re: [PATCH] D21071: [mips] Account for -mabi when determining whether IAS is the default or not.

dsanders abandoned this revision. dsanders added a comment. Part of this patch is missing. I'll repost it soon. http://reviews.llvm.org/D21071 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

[PATCH] D21071: [mips] Account for -mabi when determining whether IAS is the default or not.

dsanders created this revision. dsanders added a subscriber: cfe-commits. dsanders added a dependency: D21070: Pass the ABI in the triple when appropriate (currently for MIPS) for 'clang -cc1' and 'clang -cc1as'. Herald added subscribers: dschuff, jfb. This stops cases such as '-target mips-linux

  1   2   >