Author: ericwf
Date: Sat Feb 20 01:12:17 2016
New Revision: 261419
URL: http://llvm.org/viewvc/llvm-project?rev=261419&view=rev
Log:
Remove all usages of "const" node pointer typedefs in the assoc containers.
The "const" pointer typedefs such as "__node_const_pointer" and
"__node_base_const_point
Author: ericwf
Date: Fri Feb 19 23:28:30 2016
New Revision: 261416
URL: http://llvm.org/viewvc/llvm-project?rev=261416&view=rev
Log:
Cleanup node-type handling in the associative containers.
This patch is very similar to r260431.
This patch is the first in a series of patches that's meant to bet
Hello everyone,
LLVM buildmaster will be updated and restarted in few minutes.
Thank you for understanding.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ABataev added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:2126
@@ +2125,3 @@
+ OpenMPSchedType ScheduleNum = getRuntimeSchedule(ScheduleKind, Chunk !=
nullptr,
+Ordered);
+ auto *UpdatedLocation = emitUpdateLocati
Author: abataev
Date: Fri Feb 19 22:09:36 2016
New Revision: 261412
URL: http://llvm.org/viewvc/llvm-project?rev=261412&view=rev
Log:
[OPENMP 4.5] Initial support for data members in 'lastprivate' clause.
OpenMP 4.5 allows to privatize non-static data members of current class
in non-static member
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
Repository:
rL LLVM
http://reviews.llvm.org/D17148
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
ABataev added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:3799-3806
@@ -3780,4 +3798,10 @@
OffloadEntriesInfoManager.registerTargetRegionEntryInfo(
DeviceID, FileID, ParentName, Line, OutlinedFn, OutlinedFnID);
}
+/// \brief Emit the num_teams clause
On Fri, Feb 19, 2016 at 10:02 PM, Nico Weber wrote:
> On Fri, Feb 19, 2016 at 8:01 PM, Richard Smith
> wrote:
>
>> On Fri, Feb 19, 2016 at 4:41 PM, Nico Weber wrote:
>> > On Fri, Feb 19, 2016 at 4:29 PM, Richard Smith via cfe-commits
>> > wrote:
>> >>
>> >> On Thu, Feb 18, 2016 at 5:52 PM, Nic
alexfh added inline comments.
Comment at: clang-tidy/ClangTidy.cpp:115
@@ +114,3 @@
+//
+// Specify the build directory of the source file as current working
+// directroy to find source file correctly.
Maybe `Change the directory to the one used durin
Hi Adrian,
I'm taking a look at this and can't duplicate using the testcase you gave
without your patch(es) applied. It's also causing asserts in other code as
you can have the forward decl left around and the CU isn't a valid context.
Can you take a look/revert until you've got a different testc
On Fri, Feb 19, 2016 at 8:01 PM, Richard Smith
wrote:
> On Fri, Feb 19, 2016 at 4:41 PM, Nico Weber wrote:
> > On Fri, Feb 19, 2016 at 4:29 PM, Richard Smith via cfe-commits
> > wrote:
> >>
> >> On Thu, Feb 18, 2016 at 5:52 PM, Nico Weber via cfe-commits
> >> wrote:
> >> > Author: nico
> >> >
alexfh added a comment.
In http://reviews.llvm.org/D17434#356765, @dblaikie wrote:
> should probably have test coverage
+1
Repository:
rL LLVM
http://reviews.llvm.org/D17434
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.
benlangmuir accepted this revision.
benlangmuir added a comment.
This revision is now accepted and ready to land.
LGTM!
http://reviews.llvm.org/D17457
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
dexonsmith added a comment.
Honestly I didn't think much about the testing style. I used r239666
as a reference and modified it for std::unordered_map.
I'll redo the tests when I have a moment, based on the newer examples.
Probably next week some time?
http://reviews.llvm.org/D16360
___
Honestly I didn't think much about the testing style. I used r239666
as a reference and modified it for std::unordered_map.
I'll redo the tests when I have a moment, based on the newer examples.
Probably next week some time?
> On 2016-Feb-19, at 17:53, Eric Fiselier wrote:
>
> EricWF added a c
benlangmuir accepted this revision.
benlangmuir added a comment.
This revision is now accepted and ready to land.
LGTM if you fix 256->PATH_MAX.
Comment at: lib/Frontend/ModuleDependencyCollector.cpp:66
@@ +65,3 @@
+#ifdef HAVE_REALPATH
+ char CanonicalPath[256];
+
dexonsmith created this revision.
dexonsmith added reviewers: EricWF, mclow.lists.
dexonsmith added a subscriber: cfe-commits.
The tests for libc++ specify `-target` on the command-line to the
compiler, but this is problematic for a few reasons.
Firstly, the `-target` option isn't supported on Ap
EricWF added a comment.
@dexonsmith Actually is it OK if I contribute the tests for this patch? Your's
are in no way bad, but I want to test this in a similar manner to
`unord.map.modifiers/insert_allocator_requirments.pass.cpp` and it's not fair
to ask you to do that.
However if your willing
EricWF added a comment.
Overall this patch is *almost* there. My only objection is that this
optimization neglects "unordered_set". Optimally we would also catch
"unordered_set.emplace(42)"
Comment at: include/__hash_table:103
@@ -102,1 +102,3 @@
+template ::type>
-
Author: ericwf
Date: Fri Feb 19 19:11:55 2016
New Revision: 261391
URL: http://llvm.org/viewvc/llvm-project?rev=261391&view=rev
Log:
Work around GCC bug in .fail.cpp tests
Modified:
libcxx/trunk/test/libcxx/test/format.py
Modified: libcxx/trunk/test/libcxx/test/format.py
URL:
http://llvm.or
hintonda updated this revision to Diff 48561.
hintonda added a comment.
- Fix additional tests
http://reviews.llvm.org/D17407
Files:
lib/Sema/SemaInit.cpp
test/CXX/dcl.decl/dcl.init/dcl.init.list/p3-0x.cpp
test/SemaCXX/cxx0x-initializer-aggregates.cpp
test/SemaCXX/cxx0x-initializer-cons
Author: majnemer
Date: Fri Feb 19 18:57:00 2016
New Revision: 261388
URL: http://llvm.org/viewvc/llvm-project?rev=261388&view=rev
Log:
Remove a duplicate declaration specifier from _ReadBarrier
This fixes PR26675.
Modified:
cfe/trunk/lib/Headers/Intrin.h
Modified: cfe/trunk/lib/Headers/Intr
On Fri, Feb 19, 2016 at 4:41 PM, Nico Weber wrote:
> On Fri, Feb 19, 2016 at 4:29 PM, Richard Smith via cfe-commits
> wrote:
>>
>> On Thu, Feb 18, 2016 at 5:52 PM, Nico Weber via cfe-commits
>> wrote:
>> > Author: nico
>> > Date: Thu Feb 18 19:52:46 2016
>> > New Revision: 261297
>> >
>> > URL:
> Is there any point in the #include_next, even?
I think so. If stdbool.h may provide extensions/additional definitions (ex
"#define _Bool"). I don't want
to manage these within libc++ and I don't want to prevent users from
getting them from the actual header.
Although upon further inspection "_B
On Fri, Feb 19, 2016 at 4:29 PM, Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Thu, Feb 18, 2016 at 5:52 PM, Nico Weber via cfe-commits
> wrote:
> > Author: nico
> > Date: Thu Feb 18 19:52:46 2016
> > New Revision: 261297
> >
> > URL: http://llvm.org/viewvc/llvm-project?
On Fri, Feb 19, 2016 at 4:16 PM, Eric Fiselier via cfe-commits
wrote:
> Author: ericwf
> Date: Fri Feb 19 18:16:41 2016
> New Revision: 261381
>
> URL: http://llvm.org/viewvc/llvm-project?rev=261381&view=rev
> Log:
> Add stdbool.h wrapper for libc++
>
> Summary:
> According to the C++ standard is
Author: ericwf
Date: Fri Feb 19 18:24:43 2016
New Revision: 261383
URL: http://llvm.org/viewvc/llvm-project?rev=261383&view=rev
Log:
Fix PR26622 - Make CheckLibcxxAtomic.cmake use the libc++ headers.
Modified:
libcxx/trunk/cmake/Modules/CheckLibcxxAtomic.cmake
Modified: libcxx/trunk/cmake/Mo
Author: ericwf
Date: Fri Feb 19 18:19:45 2016
New Revision: 261382
URL: http://llvm.org/viewvc/llvm-project?rev=261382&view=rev
Log:
Make __wrap_iter work with GCC again
Summary:
This bug was originally fixed in http://reviews.llvm.org/D7201.
However it was broken again by the fix to
https://l
EricWF accepted this revision.
EricWF added a reviewer: EricWF.
EricWF added a comment.
This revision is now accepted and ready to land.
@mclow.lists said this was OK to commit if he couldn't think of a better idea.
It's unfortunate to use `` to forward declare containers but ``
already included
Author: ericwf
Date: Fri Feb 19 18:16:41 2016
New Revision: 261381
URL: http://llvm.org/viewvc/llvm-project?rev=261381&view=rev
Log:
Add stdbool.h wrapper for libc++
Summary:
According to the C++ standard isn't allowed to define `true`
`false` or `bool`. However these macros are sometimes defin
EricWF accepted this revision.
EricWF added a reviewer: EricWF.
EricWF added a comment.
This revision is now accepted and ready to land.
Got approval from @mclow.lists offline.
http://reviews.llvm.org/D16346
___
cfe-commits mailing list
cfe-commits@
rsmith added inline comments.
Comment at: lib/CodeGen/CGVTables.cpp:904-919
@@ -900,5 +903,18 @@
+
+bool CodeGenModule::IsBitSetBlacklistedRecord(const CXXRecordDecl *RD) {
+ std::string TypeName = RD->getQualifiedNameAsString();
+ auto isInBlacklist = [&](const SanitizerBlackli
Author: rsmith
Date: Fri Feb 19 16:43:58 2016
New Revision: 261373
URL: http://llvm.org/viewvc/llvm-project?rev=261373&view=rev
Log:
[modules] Do less scanning of macro definition chains when computing the set of
exported module macros outside local submodule visibility mode. Related to
PR24667.
Author: rsmith
Date: Fri Feb 19 16:25:36 2016
New Revision: 261372
URL: http://llvm.org/viewvc/llvm-project?rev=261372&view=rev
Log:
[modules] Flatten -fmodule-name= and -fmodule-implementation-of= into a single
option. Previously these options could both be used to specify that you were
compiling
On Fri, Feb 19, 2016 at 06:14:18PM +, Ben Craig via cfe-commits wrote:
> Instead of checking _LIBCPP_LOCALE__L_EXTENSIONS all over, instead
> check it once, and define the various *_l symbols once.
If you want to rename using macros, please use the argument form. I find
that to provide better
On Thu, Feb 18, 2016 at 5:52 PM, Nico Weber via cfe-commits
wrote:
> Author: nico
> Date: Thu Feb 18 19:52:46 2016
> New Revision: 261297
>
> URL: http://llvm.org/viewvc/llvm-project?rev=261297&view=rev
> Log:
> Implement the likely resolution of core issue 253.
>
> C++11 requires const objects to
On Fri, Feb 19, 2016 at 4:14 PM, Richard Smith via cfe-commits
wrote:
> rsmith added a subscriber: rsmith.
> rsmith added a comment.
>
> Do they treat this as a keyword or as a predefined macro? (Does `#ifdef`
> think `static_assert` is defined?)
It seems to be treated as a keyword instead of a
rsmith added a subscriber: rsmith.
rsmith added a comment.
Do they treat this as a keyword or as a predefined macro? (Does `#ifdef` think
`static_assert` is defined?)
http://reviews.llvm.org/D17444
___
cfe-commits mailing list
cfe-commits@lists.llv
On Fri, Feb 19, 2016 at 5:35 AM, Michael Matz wrote:
> Hi,
>
> On Thu, 18 Feb 2016, Richard Smith wrote:
>
>> >> An empty type is a type where it and all of its subobjects
>> >> (recursively) are of class, structure, union, or array type. No
>> >> memory slot nor register should be used to pass o
george.burgess.iv created this revision.
george.burgess.iv added a reviewer: rsmith.
george.burgess.iv added subscribers: srhines, cfe-commits.
Currently, we get assertion failures/segfaults for variadic functions with
`pass_object_size` params, e.g.:
```
void foo(void *const __attribute__((pass
Anastasia added inline comments.
Comment at: lib/Sema/SemaDecl.cpp:11504
@@ +11503,3 @@
+ else if (getLangOpts().OpenCL)
+// OpenCL function need to be called with prototype, so we don't allow
+// implicit function declarations in OpenCL
Could you add spe
yaxunl accepted this revision.
yaxunl added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks.
Comment at: test/SemaOpenCL/storageclass-cl20.cl:23
@@ -19,1 +22,3 @@
+ extern global int G5;
+ extern int G6; // expected-error{{program scope variable must r
Anastasia added inline comments.
Comment at: lib/Sema/SemaDecl.cpp:3900
@@ -3899,1 +3899,3 @@
if (!DeclaresAnything) {
+// OpenCL C doesn't support bit-field, so declaration with no declarator
+// has no use.
I am still not convinced about this change?
sbenza added inline comments.
Comment at: clang-tidy/cert/CommandProcessorCheck.cpp:36
@@ +35,3 @@
+ // is not a security risk by itself.
+ if (Fn->getName() == "system" && E->getNumArgs() == 1 &&
+ E->getArg(0)->isNullPointerConstant(*Result.Context,
You c
Anastasia added inline comments.
Comment at: test/SemaOpenCL/storageclass-cl20.cl:23
@@ -19,1 +22,3 @@
+ extern global int G5;
+ extern int G6; // expected-error{{program scope variable must reside in
global or constant address space}}
}
Apparently not, becaus
On Fri, Feb 19, 2016 at 11:03 AM, Matthijs van Duin
wrote:
> On 19 February 2016 at 14:35, Michael Matz wrote:
>> struct S {
>> S() {something();}
>> };
>>
>> would be an empty type, and that's not what we want.
>
> Why not? The default constructor is never invoked as part of passing
> such an
Anastasia added inline comments.
Comment at: lib/Sema/SemaDecl.cpp:5714
@@ +5713,3 @@
+ // OpenCL v2.0 s6.9.b
+ // An image type can only be used as a type of a function argument.
+ if (getLangOpts().OpenCL && R->isImageType()) {
Move to the line above, separat
pcc added a comment.
What I meant was that it looks like a hack that this is being handled in the
driver. The frontend shouldn't care what the value of a trap flag is if a
sanitizer is disabled.
Why are we even emitting checks for disabled sanitizers in the target DSO
anyway? Can we fail open
Anastasia added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:7719
@@ +7718,3 @@
+def err_opencl_block_proto_variadic : Error<
+ "invalid block prototype, variadic arguments are not allowed in opencl">;
+def err_opencl_invalid_block_array : Error<
--
An alternative fix would be to interpose MSVC's assert.h in clang's builtin
headers with #include_next, and do the define there. I don't like
interposing headers if we can avoid it though.
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lis
carlo.bertolli updated this revision to Diff 48526.
carlo.bertolli added a comment.
Update to trunk and implement suggestions from latest review: do not make
public methods used in static function calling kmpc_for_static_init, but call
those functions in the caller that can access them.
Reposi
On Fri, Feb 19, 2016 at 11:10 AM, Eugene Zelenko
wrote:
> On Fri, Feb 19, 2016 at 11:06 AM, David Blaikie
> wrote:
> >
> > Could we take this conversation back to the list? (better to discuss
> things
> > with everyone)
> >
> > On Fri, Feb 19, 2016 at 11:02 AM, Eugene Zelenko <
> eugene.zele...@
On Fri, Feb 19, 2016 at 2:02 PM, Reid Kleckner via cfe-commits
wrote:
> rnk added a comment.
>
> I think we should do this because MSVC doesn't make _Static_assert available
> to C code.
Except, they do, somewhat. _Static_assert(0, "this should diagnose");
does *not* work in MSVC. _Static_assert
On 19 February 2016 at 14:35, Michael Matz wrote:
> struct S {
> S() {something();}
> };
>
> would be an empty type, and that's not what we want.
Why not? The default constructor is never invoked as part of passing
such an object around. Its copy constructor is a nop and requires no
reference t
Anastasia added inline comments.
Comment at: lib/Sema/SemaDeclAttr.cpp:5046
@@ +5045,3 @@
+ if (D->hasAttr()) {
+S.Diag(Attr.getLoc(), diag::err_opencl_multiple_access_qualifiers)
+<< D->getSourceRange();
Yes, I think attribute would make more sense.
rnk added a comment.
I think we should do this because MSVC doesn't make _Static_assert available to
C code. David says that, according to the C standard, assert.h is supposed to
`#define static_assert _Static_assert`. MSVC doesn't do that because they
provide static_assert directly as a keywor
bcraig updated the summary for this revision.
bcraig removed a reviewer: scshunt.
bcraig updated this revision to Diff 48520.
bcraig added a comment.
Switched from _CXX_* prefix to _libcxx_* prefix to avoid link time conflicts
with other C++ library implementations.
Removed Sean Hunt from the re
Anastasia updated this revision to Diff 48518.
Anastasia added a comment.
Corrected to new error msg in tests too!
http://reviews.llvm.org/D17345
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaDecl.cpp
test/Parser/opencl-storage-class.cl
test/SemaOpenCL/storageclass-cl20
Anastasia updated this revision to Diff 48516.
Anastasia added a comment.
Fixed error msg and test!
http://reviews.llvm.org/D17345
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaDecl.cpp
test/Parser/opencl-storage-class.cl
test/SemaOpenCL/storageclass-cl20.cl
test/Sema
scshunt added a comment.
Oh man, what did I do to get included on this one? ;)
I haven't worked on LLVM for years, though, so please proceed without me. :)
Sean
http://reviews.llvm.org/D17456
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
On 19 February 2016 at 16:27, H.J. Lu wrote:
> We want to include static member functions and exclude non-static member
> functions.
>
There's no reason to disallow non-static member functions in general; they
have no impact on being trivially copyable or not, only the presence of a
non-trivial
bruno created this revision.
bruno added reviewers: benlangmuir, bogner.
bruno added subscribers: cfe-commits, dexonsmith.
The VFS overlay mapping between virtual paths and real paths is done through
the 'external-contents' entries in YAML files, which contains hardcoded paths
to the real files.
jroelofs added a comment.
In http://reviews.llvm.org/D17456#357245, @bcraig wrote:
> In http://reviews.llvm.org/D17456#357232, @jroelofs wrote:
>
> > > The private redirector symbol names are all prefixed with _CXX_* so that
> > > they won't conflict with user symbols,
> >
> >
> > This is more @
On Fri, Feb 19, 2016 at 10:38 AM, Eugene Zelenko
wrote:
> On Fri, Feb 19, 2016 at 10:32 AM, David Blaikie
> wrote:
> >
> >
> > On Fri, Feb 19, 2016 at 10:25 AM, Eugene Zelenko via cfe-commits
> > wrote:
> >>
> >> Eugene.Zelenko added a comment.
> >>
> >> Also I agree that testing is good idea,
Anastasia updated this revision to Diff 48514.
Anastasia added a comment.
Removed varargs due to printf special handling. To be added as a separate
review!
http://reviews.llvm.org/D16928
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaDecl.cpp
lib/Sema/SemaType.cpp
test/
bcraig added a comment.
In http://reviews.llvm.org/D17456#357232, @jroelofs wrote:
> > The private redirector symbol names are all prefixed with _CXX_* so that
> > they won't conflict with user symbols,
>
>
> This is more @mclow.lists/@ericwf's domain, but I think __libcxx_ prefixes
> would be
Author: stulova
Date: Fri Feb 19 12:30:11 2016
New Revision: 261350
URL: http://llvm.org/viewvc/llvm-project?rev=261350&view=rev
Log:
[OpenCL] Generate metadata for opencl_unroll_hint attribute
Add support for opencl_unroll_hint attribute from OpenCL v2.0 s6.11.5.
Reusing most of metadata genera
This revision was automatically updated to reflect the committed changes.
Closed by commit rL261350: [OpenCL] Generate metadata for opencl_unroll_hint
attribute (authored by stulova).
Changed prior to commit:
http://reviews.llvm.org/D16686?vs=47716&id=48513#toc
Repository:
rL LLVM
http://re
On Fri, Feb 19, 2016 at 10:25 AM, Eugene Zelenko via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Eugene.Zelenko added a comment.
>
> Also I agree that testing is good idea, it doesn't make sense in current
> incarnation which test only vector and set and only with containers' code
> snippet
carlo.bertolli updated this revision to Diff 48511.
carlo.bertolli added a comment.
Update against trunk.
Repository:
rL LLVM
http://reviews.llvm.org/D17148
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
lib/CodeGen/CGOpenMPRuntime.h
lib/CodeGen/CGStmtOpenMP.cpp
test/OpenMP/teams_codegen.cpp
Eugene.Zelenko added a comment.
Also I agree that testing is good idea, it doesn't make sense in current
incarnation which test only vector and set and only with containers' code
snippets instead of real implementations. I wrote about last issue in cfe-dev,
but idea was rejected.
Other issue i
jroelofs added a subscriber: EricWF.
jroelofs added a comment.
> The private redirector symbol names are all prefixed with _CXX_* so that they
> won't conflict with user symbols,
This is more @mclow.lists/@ericwf's domain, but I think __libcxx_ prefixes
would be safer (so that there's no chanc
MatsPetersson added a comment.
@Anastasia: Yes, I agree, printf should be done as a separate patch.
http://reviews.llvm.org/D16928
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bcraig created this revision.
bcraig added reviewers: scshunt, howard.hinnant, jroelofs, mclow.lists.
bcraig added a subscriber: cfe-commits.
Herald added a subscriber: jfb.
This is one part of many of a locale refactor. See
http://reviews.llvm.org/D17146 for an idea of where this is going.
Inst
Anastasia added a comment.
@Mats, I think I would prefer not to add even more special handling (i.e. error
in this case) for printf.
I will look into adding it as a Builtin instead. However, I would prefer to
remove it from this change and submit a separate patch as it doesn't belong to
Clang
a.sidorin removed rL LLVM as the repository for this revision.
a.sidorin updated this revision to Diff 48503.
a.sidorin added a comment.
Fix issues pointed by Aaron.
http://reviews.llvm.org/D17446
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
include/cla
If you merge this, you also need to merge the small follow up "r261301 -
Fix SemaTemplate/instantiate-field.cpp after r261297."
On Feb 19, 2016 11:26 AM, "Hans Wennborg via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
> On Fri, Feb 19, 2016 at 4:00 AM, Ismail Donmez via cfe-commits
> wrote:
LegalizeAdulthood added a comment.
I do not have commit access, so someone else will need to commit this. Let me
know if it needs rebasing.
Patch by Richard Thomson.
http://reviews.llvm.org/D10013
___
cfe-commits mailing list
cfe-commits@lists.ll
beanz accepted this revision.
beanz added a comment.
This revision is now accepted and ready to land.
Looks good to me.
http://reviews.llvm.org/D17452
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
roman.shirokiy created this revision.
roman.shirokiy added reviewers: rnk, majnemer, beanz, pcc.
roman.shirokiy added a subscriber: cfe-commits.
This enables "--rtlib compiler-rt" option under MSVC environment.
Related compiler-rt patch:
http://reviews.llvm.org/D17452
http://reviews.llvm
roman.shirokiy created this revision.
roman.shirokiy added reviewers: rnk, majnemer, beanz, pcc.
roman.shirokiy added a subscriber: cfe-commits.
This enables MSVC build of complex number arithmetic compiler-rt builtins.
Consider Clang which is built under native Windows environment. Compiling t
erik.pilkington created this revision.
erik.pilkington added a reviewer: rsmith.
erik.pilkington added a subscriber: cfe-commits.
Previously, when the 2 expressions passed to a ternary operator were xvalues
and one inherits from the other, the resulting expression had type 'T', not
'T&&' as 5.16
On Fri, Feb 19, 2016 at 4:00 AM, Ismail Donmez via cfe-commits
wrote:
> On Fri, Feb 19, 2016 at 3:52 AM, Nico Weber via cfe-commits
> wrote:
>> Author: nico
>> Date: Thu Feb 18 19:52:46 2016
>> New Revision: 261297
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=261297&view=rev
>> Log:
>> Impl
aaron.ballman added inline comments.
Comment at: clang-tidy/cert/CommandProcessorCheck.cpp:22
@@ +21,3 @@
+ Finder->addMatcher(
+ callExpr(callee(functionDecl(anyOf(hasName("system"), hasName("popen"),
+ hasName("_popen")))
---
aaron.ballman updated this revision to Diff 48499.
aaron.ballman marked an inline comment as done.
http://reviews.llvm.org/D17447
Files:
clang-tidy/cert/CERTTidyModule.cpp
clang-tidy/cert/CMakeLists.txt
clang-tidy/cert/CommandProcessorCheck.cpp
clang-tidy/cert/CommandProcessorCheck.h
do
sbenza added inline comments.
Comment at: clang-tidy/cert/CommandProcessorCheck.cpp:22
@@ +21,3 @@
+ Finder->addMatcher(
+ callExpr(callee(functionDecl(anyOf(hasName("system"), hasName("popen"),
+ hasName("_popen")))
S
aaron.ballman added a comment.
I agree with David, I'd like to see test coverage for this (with both
std::string and std::wstring to be paranoid).
Repository:
rL LLVM
http://reviews.llvm.org/D17434
___
cfe-commits mailing list
cfe-commits@lists.
aaron.ballman created this revision.
aaron.ballman added reviewers: alexfh, sbenza.
aaron.ballman added a subscriber: cfe-commits.
This patch adds a check for the CERT secure coding rule: ENV33-C. Do not call
system(). It flags any call expression that calls a system command processor
(system(),
On Fri, Feb 19, 2016 at 5:35 AM, Michael Matz wrote:
> Hi,
>
> On Thu, 18 Feb 2016, Richard Smith wrote:
>
>> >> An empty type is a type where it and all of its subobjects
>> >> (recursively) are of class, structure, union, or array type. No
>> >> memory slot nor register should be used to pass o
On 2/19/2016 8:40 AM, Joerg Sonnenberger via cfe-commits wrote:
On Thu, Feb 18, 2016 at 10:32:11PM +, Ben Craig via cfe-commits wrote:
The fallback locale functions are also useful on their own for other
lightweight platforms. Putting these fallback implementations in
support/xlocale should
alexfh added a comment.
LG
Comment at: test/clang-tidy/cert-flp30-c.c:6
@@ +5,3 @@
+void func(void) {
+ // CHECK-MESSAGES: :[[@LINE+1]]:37: warning: loop induction expression
should not have floating-point type [cert-flp30-c]
+ for (float x = 0.1f; x <= 1.0f; x += 0.1f) {
---
On 2/19/2016 8:36 AM, Joerg Sonnenberger via cfe-commits wrote:
On Thu, Feb 18, 2016 at 03:39:29PM +, Ben Craig via cfe-commits
wrote:
Unfortunately, I have no access to an AIX machine to build with, so
this change has been made blind.
Any reason why this is not using "new" and "delete"? I
aaron.ballman added a comment.
Given the wide disparity of functionality, I'm wondering if there are concrete
purposes for these new matchers?
Comment at: include/clang/ASTMatchers/ASTMatchers.h:1599
@@ -1543,1 +1598,3 @@
+/// \brief Matches atomic builtins.
+const internal::
a.sidorin added a comment.
Serge Pavlov: I'll enable tests from you patch
(http://reviews.llvm.org/D14224) after all node types your patch supports will
be supported. If you're agree, of course.
Repository:
rL LLVM
http://reviews.llvm.org/D14286
_
yaxunl added inline comments.
Comment at: test/SemaOpenCL/invalid-pipes-cl2.0.cl:9
@@ -8,1 +8,3 @@
}
+void test4() {
+ pipe int p; // expected-error {{pipe can only be used as a function
parameter}}
Do we have a test for diagnosing pipe type for OCL < 2.0 ?
h
a.sidorin updated the summary for this revision.
a.sidorin set the repository for this revision to rL LLVM.
a.sidorin updated this revision to Diff 48487.
a.sidorin added a comment.
Herald added a subscriber: aemerson.
Add AST matcher-based unit tests; add some additional nodes to pass the tests.
On Fri, Feb 19, 2016 at 9:44 AM, Andrey Bokhanko
wrote:
> Aaron, you might be right... but still, I doubt MS will fix it any
> time soon -- I suppose enough code already depends on this.
>
> Either way, it's up to Reid, as Windows maintainer, to decide whatever
> we want this to be supported in cl
Aaron, you might be right... but still, I doubt MS will fix it any
time soon -- I suppose enough code already depends on this.
Either way, it's up to Reid, as Windows maintainer, to decide whatever
we want this to be supported in clang or not.
Yours,
Andrey
On Fri, Feb 19, 2016 at 4:43 PM, Aaro
On Thu, Feb 18, 2016 at 10:32:11PM +, Ben Craig via cfe-commits wrote:
> The fallback locale functions are also useful on their own for other
> lightweight platforms. Putting these fallback implementations in
> support/xlocale should enable code sharing.
Shouldn't the fallback functions be usi
On Thu, Feb 18, 2016 at 03:39:29PM +, Ben Craig via cfe-commits wrote:
> Unfortunately, I have no access to an AIX machine to build with, so
> this change has been made blind.
Any reason why this is not using "new" and "delete"? I think I would
prefer to not define uselocale, but that can be l
1 - 100 of 121 matches
Mail list logo
