Honestly I didn't think much about the testing style.  I used r239666
as a reference and modified it for std::unordered_map.

I'll redo the tests when I have a moment, based on the newer examples.
Probably next week some time?

> On 2016-Feb-19, at 17:53, Eric Fiselier <e...@efcs.ca> wrote:
> 
> EricWF added a comment.
> 
> @dexonsmith Actually is it OK if I contribute the tests for this patch? 
> Your's are in no way bad, but I want to test this in a similar manner to 
> `unord.map.modifiers/insert_allocator_requirments.pass.cpp` and it's not fair 
> to ask you to do that.
> 
> However if your willing to learn how to use `support/container_test_types.h` 
> that even better :-)
> 
> 
> http://reviews.llvm.org/D16360
> 
> 
> 

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to