T12815: Create Calligra Framework by separating out applications and libraries

2020-03-14 Thread Jaime Torres Amate
jtamate added a comment. As I have some free time due to the virus and I'm trying to get up to date. In the SQL word there is the notion of tables, queries and views, where a view can show de values of several tables (combined, filtered or raw). Do you know if there is something simi

Review Request: Avoid two possible NULL pointer access.

2011-06-16 Thread Jaime Torres Amate
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101644/ --- Review request for Calligra. Summary --- The paCanvas and canvasItem

Review Request: one memory leak, 7 exceptions and two comparations.

2011-06-22 Thread Jaime Torres Amate
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101730/ --- Review request for Calligra. Summary --- The two comparations are obv

Review Request: some small performance improvements in plugins

2011-06-23 Thread Jaime Torres Amate
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101736/ --- Review request for Calligra. Summary --- prefix ++ for non trivial ty

Re: Review Request: one memory leak, 7 exceptions and two comparations.

2011-06-23 Thread Jaime Torres Amate
June 22, 2011, 9:46 p.m., Jaime Torres Amate wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101730/ > --

Review Request: avoid an infinite recursive call in kundo2

2011-06-25 Thread Jaime Torres Amate
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101755/ --- Review request for Calligra. Summary --- with the default value in th

Review Request: avoid some null pointers dereferences

2011-06-28 Thread Jaime Torres Amate
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101796/ --- Review request for Calligra. Summary --- cppcheck informs and I t

Review Request: Some dead code I do not know how to handle

2011-06-29 Thread Jaime Torres Amate
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101803/ --- Review request for Calligra. Summary --- the changes are: (easy) 1. i

Re: Review Request: Some dead code I do not know how to handle

2011-07-01 Thread Jaime Torres Amate
27;ll also try to check this equality with -Ofast. - Jaime Torres --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101803/#review4290 ------

Review Request: more parentheris for ? operator and other things

2011-07-01 Thread Jaime Torres Amate
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101818/ --- Review request for Calligra. Summary --- I should not mix so many pat

Review Request: add const qualifier to methods that do not modify the object status

2011-07-03 Thread Jaime Torres Amate
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101839/ --- Review request for Calligra. Summary --- Help the compiler to produce

Review Request: more methods made const

2011-07-03 Thread Jaime Torres Amate
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101843/ --- Review request for Calligra. Summary --- Second and last const method

Re: Review Request: more methods made const

2011-07-04 Thread Jaime Torres Amate
enerated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101843/#review4358 ------- On July 3, 2011, 6:17 p.m., Jaime Torres Amate wrote: > > --- > This is an automati

Review Request: read XML in the rigth way. ie. \n has 5 nodes, not 3

2011-07-05 Thread Jaime Torres Amate
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101857/ --- Review request for Calligra. Summary --- Quoting the w3 consortium: [

Re: Review Request: read XML in the rigth way. ie. \n has 5 nodes, not 3

2011-07-05 Thread Jaime Torres Amate
- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101857/#review4400 --- On July 5, 2011, 4:37 p.m., Jaime Torres Amate wrote: > >

Re: Review Request: read XML in the rigth way. ie. \n has 5 nodes, not 3

2011-08-06 Thread Jaime Torres Amate
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101857/ --- (Updated Aug. 6, 2011, 10:56 a.m.) Review request for Calligra. Summary

Re: Review Request: read XML in the rigth way. ie. \n has 5 nodes, not 3

2011-08-06 Thread Jaime Torres Amate
be rethinked (probably including a second part to handle the spaces for the applications). Discarded as it is. - Jaime Torres --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/10185

Re: Review Request: read XML in the rigth way. ie. \n has 5 nodes, not 3

2011-08-15 Thread Jaime Torres Amate
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101857/ --- (Updated Aug. 15, 2011, 5:56 p.m.) Review request for Calligra. Summary

Re: Review Request: read XML in the rigth way. ie. \n has 5 nodes, not 3

2011-08-17 Thread Jaime Torres Amate
15, 2011, 5:56 p.m., Jaime Torres Amate wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101857/ > ---

Re: Review Request: read XML in the rigth way. ie. \n has 5 nodes, not 3

2011-08-17 Thread Jaime Torres Amate
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101857/ --- (Updated Aug. 18, 2011, 12:04 a.m.) Review request for Calligra. Changes

Review Request: more little things in libs

2011-08-20 Thread Jaime Torres Amate
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102385/ --- Review request for Calligra. Summary --- Use references por QRectF an

Review Request: Some small fixes for latex exports

2011-08-28 Thread Jaime Torres Amate
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102467/ --- Review request for Calligra. Summary --- Check the array index before

Review Request: kexi null pointer safeguards

2011-08-28 Thread Jaime Torres Amate
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102474/ --- Review request for Calligra. Summary --- Add null pointer safeguards

Review Request: some warnings from clang++

2011-11-17 Thread Jaime Torres Amate
odels/kptnodeitemmodel.cpp 1ecb9f4 Diff: http://git.reviewboard.kde.org/r/103171/diff/diff Testing --- still compiles with g++ Thanks, Jaime Torres Amate ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/lis

Re: Review Request: Bug in KoXml* to QDom* conversion

2012-01-11 Thread Jaime Torres Amate
ttp://git.reviewboard.kde.org/r/103674/#comment8042> testXMLReaderWithoutSpaces was a clone of testXMLReader, except that the xmlstreams should not contain whitespaces/tabs/newlinews between nodes. Therefore, your change here is incorrect. - Jaime Torres Amate On Jan. 11, 2012, 12:08 p.m

Re: Review Request: Make the epub filter handle math formulas

2013-01-01 Thread Jaime Torres Amate
> On Dec. 31, 2012, 9:42 p.m., mojtaba shahi wrote: > > I found something, I tested your patch and made an epub from your document > > sample (sqrt) and it doesn't look right for me. > > I unpacked the epub and tryed to open the .xhtml (chapter1.xhtml) with my > > browser and it got error. I ch

Review Request 109226: from allways true to (probably) what is wanted

2013-03-01 Thread Jaime Torres Amate
tore-storage (Failed) 216 - libs-textlayout-TestBlockLayout (Failed) 229 - libs-kotext-styles-TestOpenDocumentStyle (Failed) Thanks, Jaime Torres Amate ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Review Request 116976: do not use a null member

2014-03-22 Thread Jaime Torres Amate
/116976/diff/ Testing --- I can open images. Thanks, Jaime Torres Amate ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 116976: do not use a null member

2014-03-22 Thread Jaime Torres Amate
/libpaintop/kis_multi_sensors_model_p.cpp 3138cfd Diff: https://git.reviewboard.kde.org/r/116976/diff/ Testing --- I can open images. Thanks, Jaime Torres Amate ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman