> On None, Thorsten Zachmann wrote: > > Finally I was able to test the patch. I used cstester and a testset of 1800 > > documents. When testing with the patch about 1000 of the documents changed > > their visual representation. > > > > I found the following problems: > > - bullets are suddenly hidden > > - links get underscroes attached at beginning/end > > - charts look different > > - line break different > > - formulars different size > > > > However as the amount of documents that changed their visible > > representation was so big I did only look in about 50 of the changed > > documents and not all. So there might be more problems which are not yet > > identified. > > > > I have uploaded the documents to http://www.zagge.de/anchor/koxml-info/ > > > > There is a info.txt file describing in which file a chnage is seen. > > The before subdir contains the images without the change. > > The after subdir contains the images with the patch.
I guess you forgot to press the Submit button. This patch must be rethinked (probably including a second part to handle the spaces for the applications). Discarded as it is. - Jaime Torres ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101857/#review4539 ----------------------------------------------------------- On Aug. 6, 2011, 10:56 a.m., Jaime Torres Amate wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101857/ > ----------------------------------------------------------- > > (Updated Aug. 6, 2011, 10:56 a.m.) > > > Review request for Calligra. > > > Summary > ------- > > Quoting the w3 consortium: > [Definition: All text that is not markup constitutes the character data of > the document.] > > And in section > http://www.w3.org/TR/REC-xml/#sec-white-space > > In editing XML documents, it is often convenient to use "white space" > (spaces, tabs, and blank lines) to set apart the markup for greater > readability. > Such white space is typically not intended for inclusion in the delivered > version of the document. > On the other hand, "significant" white space that should be preserved in the > delivered version is common, for example in poetry and source code. > > An XML processor MUST always pass all characters in a document that are not > markup through to the application. > A validating XML processor MUST also inform the application which of these > characters constitute white space appearing in element content. > > [Definition: An element type has mixed content when elements of that type may > contain character data, optionally interspersed with child elements.] > ------------------ > The attached patch modifies the xml parser to return the spaces between > and > < as text elements. > > I needed to change the TestXmlReader to remove all the additional spaces > between nodes. > (I'll need to modify the patch to remove all the additional spaces I've > introduced). > > > Diffs > ----- > > libs/odf/KoXmlReader.cpp ad5e9d2 > libs/odf/KoXmlReaderForward.h 4ca9a74 > libs/odf/tests/TestXmlReader.cpp 6631b64 > > Diff: http://git.reviewboard.kde.org/r/101857/diff > > > Testing > ------- > > The modified TestXmlReader test is OK. > There are only 2 regressions in the tests that I do not know how to fix: > 147 - krita-ui-KisKraLoaderTest (Failed) > 148 - krita-ui-KisKraSaverTest (Failed) > > Also, I've been able to read with calligrawords and calligrastage all the > .od* that I have without problems. > > > Thanks, > > Jaime Torres > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
