> On July 1, 2011, 9:51 a.m., Matus Uzak wrote: > > filters/words/msword-odf/wv2/src/ustring.cpp, line 71 > > <http://git.reviewboard.kde.org/r/101803/diff/1/?file=25713#file25713line71> > > > > According to the corresponding IEEE standard: If x is NAN, then (x == > > x) == false. Can you please explain a bit your change.
I must admit that I did not read the IEEE standard. My change comes from the assumption that the NaN defined some lines above was the intended comparation. I'll revert this commit with a comment about the standard. I'll also try to check this equality with -Ofast. - Jaime Torres ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101803/#review4290 ----------------------------------------------------------- On June 29, 2011, 8:32 p.m., Jaime Torres Amate wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101803/ > ----------------------------------------------------------- > > (Updated June 29, 2011, 8:32 p.m.) > > > Review request for Calligra. > > > Summary > ------- > > the changes are: > (easy) > 1. in formulas is to return the FormulaToken& as recommended by C++. (even if > there is no a=b=c chain). > 2. in ustring is to compare with NaN to know when a value is NaN instead of > compare to itself. > 3. in kis_blur_effect is to clarify the priority of - and ?. > (hard) > 4. in kotextloader to remove 3 duplicated code. (at least the first and > sencond, the third one is sligly different from the previous incarnation of > the code). > They are previously in the same else if chain. > 5. in kotablerowstyle, remove 1 duplicated code (or is it missing some > option?) > 6. in kodfgraphicstyles, remove 1 dead entry (or it should compare to some > other word?) > > > Diffs > ----- > > filters/tables/excel/sidewinder/formulas.h 98559c8 > filters/tables/excel/sidewinder/formulas.cpp 5903dd6 > filters/words/msword-odf/wv2/src/ustring.cpp d9f1707 > krita/plugins/filters/blur/kis_blur_filter.cpp 3a45bc2 > libs/kotext/opendocument/KoTextLoader.cpp ce7c7a3 > libs/kotext/styles/KoTableRowStyle.cpp 6fc53c6 > libs/odf/KoOdfGraphicStyles.cpp f5860b9 > > Diff: http://git.reviewboard.kde.org/r/101803/diff > > > Testing > ------- > > > Thanks, > > Jaime Torres > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
