----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101803/ -----------------------------------------------------------
Review request for Calligra. Summary ------- the changes are: (easy) 1. in formulas is to return the FormulaToken& as recommended by C++. (even if there is no a=b=c chain). 2. in ustring is to compare with NaN to know when a value is NaN instead of compare to itself. 3. in kis_blur_effect is to clarify the priority of - and ?. (hard) 4. in kotextloader to remove 3 duplicated code. (at least the first and sencond, the third one is sligly different from the previous incarnation of the code). They are previously in the same else if chain. 5. in kotablerowstyle, remove 1 duplicated code (or is it missing some option?) 6. in kodfgraphicstyles, remove 1 dead entry (or it should compare to some other word?) Diffs ----- filters/tables/excel/sidewinder/formulas.h 98559c8 filters/tables/excel/sidewinder/formulas.cpp 5903dd6 filters/words/msword-odf/wv2/src/ustring.cpp d9f1707 krita/plugins/filters/blur/kis_blur_filter.cpp 3a45bc2 libs/kotext/opendocument/KoTextLoader.cpp ce7c7a3 libs/kotext/styles/KoTableRowStyle.cpp 6fc53c6 libs/odf/KoOdfGraphicStyles.cpp f5860b9 Diff: http://git.reviewboard.kde.org/r/101803/diff Testing ------- Thanks, Jaime Torres
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
