Re: Review Request: Move Show Statusbar action from menu Settings to menu View

2012-12-28 Thread C. Boemann
request as dismissed - C. Boemann On Sept. 30, 2012, 12:10 a.m., Inge Wallin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: Review Request: Make the epub filter handle math formulas

2012-12-29 Thread C. Boemann
> On Dec. 28, 2012, 2:45 p.m., C. Boemann wrote: > > there is a few places where you have: > > > > if () > > { > > > > and one place where there is no {} after if > > > > other than that I've not looked yet - I assume you want moji to r

Re: Review Request: Make a real dynamic library out of kdgantt

2012-12-29 Thread C. Boemann
approve as far as i'm concerned. I have one little question/nitpick 3rdparty/kdgantt/CMakeLists.txt <http://git.reviewboard.kde.org/r/108019/#comment18557> uhm i don't get why we can't remove it already. - C. Boemann On Dec. 30, 2012, 5:21 a.

Re: Review Request: Fix sorting of style names

2012-12-30 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108020/#review24224 --- Ship it! yes please backport too great work - C. Boemann

Re: Review Request: Make the epub filter handle math formulas

2012-12-30 Thread C. Boemann
> On Dec. 28, 2012, 2:45 p.m., C. Boemann wrote: > > there is a few places where you have: > > > > if () > > { > > > > and one place where there is no {} after if > > > > other than that I've not looked yet - I assume you want moji to r

Review Request: spellchecking changes

2012-12-30 Thread C. Boemann
/part/KWRootAreaProvider.h 1908b11 words/part/KWRootAreaProvider.cpp 9e28045 Diff: http://git.reviewboard.kde.org/r/108022/diff/ Testing --- played around with it Thanks, C. Boemann ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/ma

Re: Review Request: spellchecking changes

2012-12-31 Thread C. Boemann
Pierre Stirnweiss wrote: > > libs/textlayout/KoTextLayoutArea_paint.cpp, lines 776-781 > > <http://git.reviewboard.kde.org/r/108022/diff/1/?file=103023#file103023line776> > > > > I am not sure, but can't the logic be a bit improved here? It seems odd > >

Re: Review Request: spellchecking changes

2012-12-31 Thread C. Boemann
ugins/textshape/TextTool.h a8a525d plugins/textshape/TextTool.cpp 8d43e0a words/part/KWRootAreaProvider.h 1908b11 words/part/KWRootAreaProvider.cpp 9e28045 Diff: http://git.reviewboard.kde.org/r/108022/diff/ Testing --- played around with it Thanks, C. Bo

Re: Review Request: Remove the default paragraph style from user visible lists

2012-12-31 Thread C. Boemann
ttp://git.reviewboard.kde.org/r/108051/#comment18681> so you don't want to get notified of unused styles that get applied? libs/kotext/styles/KoStyleManager.cpp <http://git.reviewboard.kde.org/r/108051/#comment18680> so now you don't want to know if a un unapplied style gets applied?

Re: Review Request: Remove the default paragraph style from user visible lists

2012-12-31 Thread C. Boemann
backport - C. Boemann On Dec. 31, 2012, 3:47 p.m., Pierre Stirnweiss wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: Review Request: Merge textshape-stylesWidget-PierreSt in master

2013-01-01 Thread C. Boemann
8689> removal plugins/textshape/dialogs/StylesModel.cpp <http://git.reviewboard.kde.org/r/108060/#comment18690> removal .. - C. Boemann On Jan. 1, 2013, 9:55 a.m., Pierre Stirnweiss wrote: > > --- > This is a

Re: Review Request: Merge textshape-stylesWidget-PierreSt in master

2013-01-01 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108060/#review24358 --- Ship it! Ship It! - C. Boemann On Jan. 1, 2013, 9:55 a.m

Re: Review Request: make parameters of KoTextEditor const refs if possible instead of passing by value

2013-01-03 Thread C. Boemann
about these changes. For a long time it was changed the other way because those classes are shallow libs/kotext/KoTextEditor_p.h <http://git.reviewboard.kde.org/r/108131/#comment18870> please add space - C. Boemann On Jan. 3, 2013, 6:59 p.m., Friedrich W. H. Kos

Re: Review Request: Fix applying style to a caret without a selection

2013-01-05 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108191/#review24745 --- Ship it! yes it looks good - thank you - C. Boemann On Jan

Re: Review Request: Fix wrong style applied when backspace

2013-01-05 Thread C. Boemann
- i see no problem with it for now you can backport it too - C. Boemann On Jan. 5, 2013, 12:21 p.m., Pierre Stirnweiss wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: Going to request remove of any Calligra app icons from the Oxygen iconset

2013-01-07 Thread C. Boemann
On Monday 07 January 2013 22:57:13 Friedrich W. H. Kossebau wrote: > Hi, > > while looking at syncing the (new) Calligra app icons (*-app-*) and their > usage I found a problem: > installing the app icons as hicolor in the global icon folders only > installs them as kind of pick-as-last-ressort-if

Re: Review Request: Turn off table and other text features in Krita

2013-01-09 Thread C. Boemann
/TextTool.cpp <http://git.reviewboard.kde.org/r/108298/#comment19183> spaces - C. Boemann On Jan. 9, 2013, 3:47 p.m., Sven Langkamp wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.rev

Re: Review Request: Update the version numbers of all calligra plugins

2013-01-10 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108326/#review25168 --- i like it but will not approve just yet - C. Boemann On Jan

Re: Review Request: Fix a number of Krazy issues: source files not ending in newline

2013-01-10 Thread C. Boemann
say it improves portability And the fewer issues on ebn the easier it is to see the issues that really matter, (same principle applies to number of bugs in bko, and warnings during compile) - C. Boemann On Jan. 10, 2013, 6:41 a.m., Inge Wallin wrote

Re: Review Request: Update the version numbers of all calligra plugins

2013-01-11 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108326/#review25230 --- Ship it! Ship It! - C. Boemann On Jan. 10, 2013, 3:50 p.m

Re: Review Request: Fix a number of Krazy issues: source files not ending in newline

2013-01-11 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108317/#review25237 --- Ship it! yes, incl backport - C. Boemann On Jan. 10, 2013

Review Request: shape placement restrictions in Words

2013-01-11 Thread C. Boemann
eeded Thanks, C. Boemann ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Review Request 108368: page breaks CAN be inherited

2013-01-12 Thread C. Boemann
imple file cs tester run needed Thanks, C. Boemann ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 108358: shape placement restrictions in Words

2013-01-12 Thread C. Boemann
as well. But a cstester run is needed Thanks, C. Boemann ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 108097: Remove out-dated margin and spacing settings in UI files

2013-01-12 Thread C. Boemann
- let's just approve - C. Boemann On Jan. 3, 2013, 12:05 p.m., Friedrich W. H. Kossebau wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard

Re: Review Request 108358: shape placement restrictions in Words

2013-01-12 Thread C. Boemann
o fix at least 3 bugs thanks for testing - C. Boemann On Jan. 12, 2013, 4:19 p.m., C. Boemann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard

Re: Review Request 108379: Fix merging style to caret

2013-01-13 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108379/#review25340 --- Ship it! Ship It! - C. Boemann On Jan. 13, 2013, 9:08 a.m

Re: Review Request 108406: fix crash during import of an xls file with text frame objects

2013-01-14 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108406/#review25437 --- Ship it! Ship It! - C. Boemann On Jan. 14, 2013, 11:29 a.m

Re: Bug in shape opacity save

2013-01-14 Thread C. Boemann
On Monday 14 January 2013 11:01:08 Jean-Nicolas Artaud wrote: > 2013/1/12 Sven Langkamp > > > On Sat, Jan 12, 2013 at 5:30 PM, Jean-Nicolas Artaud > > > > wrote: > > > Hello, > > > > > > I've found a bug in calligra using stage. I'm on the master. > > > > > > Way to reproduce: > > > > > > o

Re: Review Request 108295: Setting working environment on launching in Windows

2013-01-14 Thread C. Boemann
/KoApplication.cpp <http://git.reviewboard.kde.org/r/108295/#comment19482> is it just reviewboard or is there some weird indentation going on at least there is a space between ) and ) that shouldn't be there - C. Boemann On Jan. 14, 2013, 1:22 p.m., Stuart Di

Re: Review Request 108408: Add scripts to create an installer for Krita.

2013-01-14 Thread C. Boemann
approves of the license not approving yet to give the rest of you time to raise your voice - C. Boemann On Jan. 14, 2013, 1:23 p.m., Boudewijn Rempt wrote: > > --- > This is an automatically generated e-mail. To reply, visi

Review Request 108420: "Fit Text Width" zoom mode

2013-01-14 Thread C. Boemann
rd.kde.org/r/108420/diff/ Testing --- only in words, and since it touches libs too I'd like some feedback Thanks, C. Boemann ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 108420: "Fit Text Width" zoom mode

2013-01-14 Thread C. Boemann
work only applies to Words/Author I don't intend for other applications to experience any changes - C. Boemann On Jan. 15, 2013, 5:04 a.m., C. Boemann wrote: > > --- > This is an automatically generated e-mail. To reply,

Review Request 108424: updated modebox for words,sheets,author

2013-01-15 Thread C. Boemann
37757 Diff: http://git.reviewboard.kde.org/r/108424/diff/ Testing --- played with it, without problems Thanks, C. Boemann ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 108439: base visualization of inline objects on text color, instead of hardcoding to gray

2013-01-16 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108439/#review25680 --- Ship it! thanks a lot - C. Boemann On Jan. 16, 2013, 6:14

Re: Review Request 108448: primitive first version of a QTextDocument inspector docker

2013-01-17 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108448/#review25728 --- Ship it! Ship It! - C. Boemann On Jan. 17, 2013, 4:30 p.m

Review Request 108459: Refactor in KoText

2013-01-17 Thread C. Boemann
ng and saving and display should be just as good as before, and the code so far should make sense - so please review that Thanks, C. Boemann ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 108451: cleanup: turn postfix to prefix operators in libs, Sheets, Words (review work for commuters or travellers)

2013-01-17 Thread C. Boemann
then no salary ;) - C. Boemann On Jan. 17, 2013, 6:57 p.m., Friedrich W. H. Kossebau wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: Review Request 108475: fix broken check for small diff in KoTextLayoutArea::layoutBlock(...)

2013-01-18 Thread C. Boemann
too - C. Boemann On Jan. 18, 2013, 6:53 p.m., Friedrich W. H. Kossebau wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: Review Request 108476: fix strange code in PictureShape::_Private::generateOutline(...)

2013-01-18 Thread C. Boemann
org/r/108476/ > --- > > (Updated Jan. 18, 2013, 7 p.m.) > > > Review request for Calligra and C. Boemann. > > > Description > --- > > MSVC complained about this, I agree as well. Seems to have worked because > "first" was "false"

Re: Review Request 108476: fix strange code in PictureShape::_Private::generateOutline(...)

2013-01-18 Thread C. Boemann
org/r/108476/ > --- > > (Updated Jan. 18, 2013, 7 p.m.) > > > Review request for Calligra and C. Boemann. > > > Description > --- > > MSVC complained about this, I agree as well. Seems to have worked because > "first" was "false"

Re: Review Request 108479: Change Tracker in KoTextWriter and KoTextLoader removal

2013-01-18 Thread C. Boemann
ete trailing spaces libs/kotext/opendocument/KoTextLoader.cpp <http://git.reviewboard.kde.org/r/108479/#comment19622> please delete trailing spaces libs/kotext/opendocument/KoTextLoader.cpp <http://git.reviewboard.kde.org/r/108479/#

Re: Review Request 108420: "Fit Text Width" zoom mode

2013-01-18 Thread C. Boemann
generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108420/#review25754 ------- On Jan. 15, 2013, 5:04 a.m., C. Boemann wrote: > > --- > This

Re: Review Request 108459: Refactor in KoText

2013-01-18 Thread C. Boemann
ical point to do a review In several commands i've disabled some stuff because it would be a vaste of time to fix it only to break it again with part2. But loading and saving and display should be just as good as before, and the code so far should make sense - so please rev

Re: Review Request 108459: Refactor in KoText

2013-01-18 Thread C. Boemann
n with part2. But loading and saving and display should be just as good as before, and the code so far should make sense - so please review that Thanks, C. Boemann ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 108479: Change Tracker in KoTextWriter and KoTextLoader removal

2013-01-19 Thread C. Boemann
block libs/kotext/opendocument/KoTextWriter_p.cpp <http://git.reviewboard.kde.org/r/108479/#comment19711> where did this come from? - C. Boemann On Jan. 19, 2013, 8:34 a.m., Luke De Mouy wrote: > > --- > This is an automa

Re: Review Request 108479: Change Tracker in KoTextWriter and KoTextLoader removal

2013-01-19 Thread C. Boemann
> On Jan. 19, 2013, 4:01 p.m., C. Boemann wrote: > > libs/kotext/opendocument/KoTextWriter_p.cpp, line 1021 > > <http://git.reviewboard.kde.org/r/108479/diff/4/?file=107946#file107946line1021> > > > > where did this come from? > > Luke De Mouy wrote:

Re: Review Request 108491: Implement Undo command for Paragraph Settings

2013-01-19 Thread C. Boemann
kotext/commands instead - C. Boemann On Jan. 19, 2013, 4:40 p.m., Gopalakrishna Bhat wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: Review Request 108491: Implement Undo command for Paragraph Settings

2013-01-19 Thread C. Boemann
> On Jan. 20, 2013, 4:07 a.m., C. Boemann wrote: > > looks very good, except could you please move the command to > > kotext/commands instead > > Gopalakrishna Bhat wrote: > The reason it is there is because of translation requirement for 2.6. In > kotex

Re: Review Request 108491: Implement Undo command for Paragraph Settings

2013-01-19 Thread C. Boemann
ttp://git.reviewboard.kde.org/r/108491/#comment19725> I'd prefer "Direct Paragraph Formatting" and as a result we should maybe rename the command too to: ParagraphFormattingCommand - C. Boemann On Jan. 20, 2013, 6:07 a.m., Gop

Re: Review Request 108491: Implement Undo command for Paragraph Settings

2013-01-19 Thread C. Boemann
some more but please commit to master and 2.6 - C. Boemann On Jan. 20, 2013, 6:58 a.m., Gopalakrishna Bhat wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: Review Request 108491: Implement Undo command for Paragraph Settings

2013-01-19 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108491/#review25828 --- Ship it! Ship It! - C. Boemann On Jan. 20, 2013, 6:58 a.m

Re: Review Request 108459: Refactor in KoText

2013-01-20 Thread C. Boemann
2. But loading and saving and display should be just as good as before, and the code so far should make sense - so please review that Thanks, C. Boemann ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 108481: Temporarily swith to path tool to change shape parameters without double click to switch tool

2013-01-20 Thread C. Boemann
this is the way we should go but I think we should come up with a general solution instead of patchinga single use case I've been trying to do that grand solution half a year ago, but got sidetracked. So I would prefer that this does not go in - C. Boemann On Jan. 19, 2013, 9:11 a.m., Yu

Re: Review Request 108510: split out _data() method for TestBlockLayout::testTabs()

2013-01-20 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108510/#review25863 --- Ship it! Ship It! - C. Boemann On Jan. 20, 2013, 5:50 p.m

Re: Review Request 108509: Fix 313576: Use the doc of the correct part

2013-01-20 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108509/#review25864 --- looks okay to me, boud? - C. Boemann On Jan. 20, 2013, 5:50

Re: Review Request 108459: Refactor in KoText

2013-01-20 Thread C. Boemann
In several commands i've disabled some stuff because it would be a vaste of time to fix it only to break it again with part2. But loading and saving and display should be just as good as before, and the code so far should make sense - so please review t

Re: Review Request 108459: Refactor in KoText

2013-01-21 Thread C. Boemann
> On Jan. 21, 2013, 6:59 a.m., C. Boemann wrote: > > libs/kotext/KoShapeAnchor.h, line 173 > > <http://git.reviewboard.kde.org/r/108459/diff/5/?file=108302#file108302line173> > > > > oh really - we don't support that at all > > > > it

Re: Review Request 108459: Refactor in KoText

2013-01-21 Thread C. Boemann
> On Jan. 21, 2013, 6:59 a.m., C. Boemann wrote: > > libs/kotext/KoShapeAnchor.cpp, line 340 > > <http://git.reviewboard.kde.org/r/108459/diff/5/?file=108303#file108303line340> > > > > or not parented at all like anchor to page > > > >

Re: Review Request 108535: Clean out KoTextLoader of changetracking

2013-01-21 Thread C. Boemann
ewboard.kde.org/r/108535/#comment19817> trailing space please remove - C. Boemann On Jan. 22, 2013, 3:56 a.m., Luke De Mouy wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Re: Review Request 108535: Clean out KoTextLoader of changetracking

2013-01-21 Thread C. Boemann
ttp://git.reviewboard.kde.org/r/108535/#comment19819> lots of trailing space here libs/kotext/opendocument/KoTextLoader.cpp <http://git.reviewboard.kde.org/r/108535/#comment19820> hmm i don't think this should be removed though - C. Boemann On Jan. 22, 2013, 3:56 a.m., L

Re: Review Request 108532: Fix crash in krita master on style combo

2013-01-21 Thread C. Boemann
have no problem with this And to Sven: yes it's lost unless krita creates a real stylemananger and make sure to save it's contents and load it again - C. Boemann On Jan. 21, 2013, 7:41 p.m., Pierre Stirnweiss wrote: > >

Re: Review Request 108532: Fix crash in krita master on style combo

2013-01-21 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108532/#review25955 --- Ship it! Ship It! - C. Boemann On Jan. 21, 2013, 7:41 p.m

Re: Review Request 108535: Clean out KoTextLoader of changetracking

2013-01-21 Thread C. Boemann
> On Jan. 22, 2013, 6:18 a.m., C. Boemann wrote: > > libs/kotext/opendocument/KoTextLoader.cpp, line 413 > > <http://git.reviewboard.kde.org/r/108535/diff/3/?file=108546#file108546line413> > > > > hmm i don't think this should be removed though > >

Re: Review Request 108535: Clean out KoTextLoader of changetracking

2013-01-21 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108535/#review25959 --- Ship it! can be committed to your branch - C. Boemann On

Re: Review Request 108459: Refactor in KoText

2013-01-22 Thread C. Boemann
e of time to fix it only to break it again with part2. But loading and saving and display should be just as good as before, and the code so far should make sense - so please review that Thanks, C. Boemann ___ calligra-devel mailing list cal

Re: Review Request 108563: Finish removing changetracker code from KoTextWriter

2013-01-22 Thread C. Boemann
emember the class name KoDeleteChangeMarker This will be your next task - to remove that libs/kotext/opendocument/KoTextWriter_p.cpp <http://git.reviewboard.kde.org/r/108563/#comment19847> yes as expected it can be removed completely - C. Boemann On Jan. 23, 2013, 12:19 a

Re: Review Request 108557: Do not pass KoDocument as argument to openDocument

2013-01-22 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108557/#review26045 --- Ship it! Ship It! - C. Boemann On Jan. 22, 2013, 7:32 p.m

Re: Review Request 108563: Finish removing changetracker code from KoTextWriter

2013-01-22 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108563/#review26047 --- Ship it! Ship It! - C. Boemann On Jan. 23, 2013, 5:41 a.m

Re: Review Request 108459: Refactor in KoText

2013-01-23 Thread C. Boemann
sabled some stuff because it would be a vaste of time to fix it only to break it again with part2. But loading and saving and display should be just as good as before, and the code so far should make sense - so please review that Thanks, C. Boemann _

next release and release pace in general

2013-01-23 Thread C. Boemann
Hi I'm worried about our release pace. For 2.6 Words was able to make exactly 0 new features. Sure we made several fixes, but apart from a few strings those could (almost) just as well have gone into a bugfix release. I'm also worried that even though we do manage to put in an occasional new f

Re: next release and release pace in general

2013-01-23 Thread C. Boemann
On Wednesday 23 January 2013 18:25:59 Inge Wallin wrote: > On Wednesday, January 23, 2013 12:05:43 C. Boemann wrote: > > Hi > > > > I'm worried about our release pace. For 2.6 Words was able to make > > exactly 0 new features. Sure we made several fixes, but ap

Re: Review Request 108569: Flake ConfigWidgets and user friendly interface

2013-01-24 Thread C. Boemann
gets/KoShadowConfigWidget.cpp <http://git.reviewboard.kde.org/r/108569/#comment19872> spaces libs/widgets/KoStrokeConfigWidget.cpp <http://git.reviewboard.kde.org/r/108569/#comment19874> seems we have a todo here - C. Boemann On Jan. 23, 2013, 10:25 p.m., Jean-Nicolas Artaud wr

Re: Review Request 108595: Remove old annotation ui

2013-01-26 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108595/#review26196 --- Ship it! Ship It! - C. Boemann On Jan. 26, 2013, 12:36 p.m

Re: Review Request 108459: Refactor in KoText

2013-01-26 Thread C. Boemann
avoid a memory leak? I guess but then we risk double deletion, so I'd rather just let the system clean it up - C. --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108459/#revi

Re: Review Request 108605: Remove KoDeleteChangeMarker

2013-01-26 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108605/#review26220 --- Ship it! ok commit to your branch - C. Boemann On Jan. 26

Re: RFC: Bumping min. KDE Platform version to 4.6.0

2013-01-27 Thread C. Boemann
On Sunday 27 January 2013 17:28:11 Friedrich W. H. Kossebau wrote: > Hi, > > while I was working on sheets/plugins/calendar/CalendarTool.cpp to fix the > code for the "deprecated!" warnings in there I wondered why we still depend > on KDE 4.3 as minimum platform, especially now that the min. requi

Re: Review Request 108459: Refactor in KoText

2013-01-28 Thread C. Boemann
before, and the code so far should make sense - so please review that Thanks, C. Boemann ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 108459: Refactor in KoText

2013-01-28 Thread C. Boemann
cation/m_oldLocation depending on > > which one is set when destructing to avoid a memory leak? > > C. Boemann wrote: > I guess but then we risk double deletion, so I'd rather just let the > system clean it up okay fixed it - C. -

Re: Review Request 108459: Refactor in KoText

2013-01-28 Thread C. Boemann
> On Jan. 21, 2013, 6:59 a.m., C. Boemann wrote: > > libs/kotext/KoShapeAnchor.h, line 173 > > <http://git.reviewboard.kde.org/r/108459/diff/5/?file=108302#file108302line173> > > > > oh really - we don't support that at all > > > >

Re: RFC: Bumping min. KDE Platform version to 4.6.0

2013-01-29 Thread C. Boemann
On Tuesday 29 January 2013 10:49:44 Thomas Pfeiffer wrote: > On 28.01.2013 20:19, Inge Wallin wrote: > > Regarding the main question... I'm not against the upping of the required > > KDE version per se. But I'm a little worried about the general notion > > that you need a late version of the OS to

Re: Review Request 108683: Delete old view before creating a new view

2013-01-31 Thread C. Boemann
be back - C. Boemann On Jan. 31, 2013, 11:01 a.m., Sven Langkamp wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: Review Request 108683: Delete old view before creating a new view

2013-01-31 Thread C. Boemann
egressions - C. Boemann On Jan. 31, 2013, 11:01 a.m., Sven Langkamp wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.review

Re: Review Request 108684: Move palettes to a Calligra-wide data folder

2013-01-31 Thread C. Boemann
ones from karbon too then And gradients and patterns too what do you think? I'm saying ship-it anyway ,as the other things can happen in other steps if we want. Good work! - C. Boemann On Jan. 31, 2013, 2:16 p.m., Sven Langkamp

Re: Review Request 108684: Move palettes to a Calligra-wide data folder

2013-01-31 Thread C. Boemann
> On Jan. 31, 2013, 10:21 p.m., Jarosław Staniek wrote: > > What if we only install Plan or Kexi? Are the palettes needed? well if it's not used in kexi and plan I would say it's a missing feature in those apps. Whenever the user chooses color for anything (text or backround color) then the Ko

Re: Review Request 108684: Move palettes to a Calligra-wide data folder

2013-01-31 Thread C. Boemann
> On Jan. 31, 2013, 10:21 p.m., Jarosław Staniek wrote: > > What if we only install Plan or Kexi? Are the palettes needed? > > C. Boemann wrote: > well if it's not used in kexi and plan I would say it's a missing feature > in those apps. Whenever the user c

Re: Review Request 108698: separate the rdf code into its own library

2013-02-01 Thread C. Boemann
good imho. I probably should test it so I neeed some more time for that. However looking through the code I see no problems - C. Boemann On Feb. 1, 2013, 1:16 p.m., Boudewijn Rempt wrote: > > --- > This is an automatically ge

Re: Review Request 108726: Fix width of Words statistics docker after opening a document

2013-02-02 Thread C. Boemann
yourself - C. Boemann On Feb. 3, 2013, 12:20 a.m., Sven Langkamp wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: Review Request 108725: Fix for unsetting the canvas, new approach

2013-02-03 Thread C. Boemann
lease. You can commit when you have done that, and you are also allowed to backport after a grace period of a few days - C. Boemann On Feb. 3, 2013, 4:35 a.m., Sven Langkamp wrote: > > --- > This is an automatically generated e-

Re: Review Request 108569: Flake ConfigWidgets and user friendly interface

2013-02-03 Thread C. Boemann
/KoPencilTool.cpp <http://git.reviewboard.kde.org/r/108569/#comment20184> spaces - C. Boemann On Feb. 3, 2013, 11:18 a.m., Jean-Nicolas Artaud wrote: > > --- > This is an automatically generated e-mail. To reply

Re: Review Request 108725: Fix for unsetting the canvas, new approach

2013-02-03 Thread C. Boemann
> On Feb. 3, 2013, 10:20 a.m., C. Boemann wrote: > > Okay, I've now tested in words, stage and sheets with all the combinations > > I can think which might have problems with this. > > > > Not finding, and I like you solution as well, although the manual tw

Re: Review Request 108587: Don't interpret selection by tablet as move

2013-02-03 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108587/#review26579 --- Ship it! Ship It! - C. Boemann On Jan. 25, 2013, 11:42 p.m

Re: Review Request 108569: Flake ConfigWidgets and user friendly interface

2013-02-03 Thread C. Boemann
it's time :) - C. Boemann On Feb. 3, 2013, 11:18 a.m., Jean-Nicolas Artaud wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard

Re: Review Request 108767: Added icon only mode for the modebox

2013-02-03 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108767/#review26597 --- Ship it! Looks very good - thanks a lot - C. Boemann On

Re: 2.6.0 tag is set on...

2013-02-04 Thread C. Boemann
On Monday 04 February 2013 15:33:05 Inge Wallin wrote: > On Monday, February 04, 2013 10:00:05 Cyrille Berger wrote: > > The conclusion on IRC was to reenable it for 2.6.1 (in two weeks). > > That sucks badly for Calligra Author since the only thing that we can > actually say that we bring to the

Re: 2.6.0 tag is set on...

2013-02-04 Thread C. Boemann
On Monday 04 February 2013 19:12:22 Inge Wallin wrote: > On Monday, February 04, 2013 19:04:41 Inge Wallin wrote: > > On Monday, February 04, 2013 18:29:45 C. Boemann wrote: > > > > But there is something you are missing: If there was such an important > > bug and

Re: Review Request 108781: Moving Formatting in Calligrawords from old framework to new framework.

2013-02-04 Thread C. Boemann
pp <http://git.reviewboard.kde.org/r/108781/#comment20231> not sure but i think this needs to stay too. unless it's already done in mergeAutoStyle - C. Boemann On Feb. 4, 2013, 6:13 p.m., Sudhendu Kumar wrote: > > ---

Re: 2.6.0 tag is set on...

2013-02-04 Thread C. Boemann
On Monday 04 February 2013 19:58:13 Inge Wallin wrote: > On Monday, February 04, 2013 19:41:34 C. Boemann wrote: > > On Monday 04 February 2013 19:12:22 Inge Wallin wrote: > > > On Monday, February 04, 2013 19:04:41 Inge Wallin wrote: > > > > On Monday, February 04,

Re: Review Request 108698: separate the rdf code into its own library

2013-02-04 Thread C. Boemann
27;t have a solution at hand except somehow writing this into a config.h libs/rdf/CMakeLists.txt <http://git.reviewboard.kde.org/r/108698/#comment20248> please export kordf_export.h - C. Boemann On Feb. 4, 2013, 1:46 p.m., Boud

Re: Review Request 108698: separate the rdf code into its own library

2013-02-08 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108698/#review26977 --- Ship it! Ship It! - C. Boemann On Feb. 6, 2013, 7:38 p.m

<    4   5   6   7   8   9   10   11   >