----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108097/#review25309 -----------------------------------------------------------
Ship it! okay, enough time has gone with no one complaining - let's just approve - C. Boemann On Jan. 3, 2013, 12:05 p.m., Friedrich W. H. Kossebau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108097/ > ----------------------------------------------------------- > > (Updated Jan. 3, 2013, 12:05 p.m.) > > > Review request for Calligra. > > > Description > ------- > > There are a few left-overs from <Qt4 times were it was fashion to use > KDialog::spacingHint and KDialog::marginHint as well as hardcode the default > spacing/margin with values that seemed sane (who imagined the code to still > be in use with displays one did not even dream of). > > No longer needed these days, as the styles care for proper spacings. Only > exception is "margin=0", which means no margin here and is still useful and > needed. > > Spared out Kexi, Krita and Plan UI files in this RR, as they seem to be full > of pixel-optimized layouting, will need more time for those. > > > Diffs > ----- > > filters/flow/imageexport/flow_imageexportwidget.ui 05fe6f9 > filters/words/ascii/ImportDialogUI.ui eec1a36 > libs/main/KoDetailsPaneBase.ui 1bb80f0 > libs/main/KoOpenPaneBase.ui b824720 > libs/main/config/KoConfigAuthorPage.ui 2a3aea4 > libs/main/koDocumentInfoAboutWidget.ui 1695ae4 > libs/main/koDocumentInfoAuthorWidget.ui c6a9da9 > libs/widgets/KoCsvImportDialog.ui 645cf64 > plugins/textshape/dialogs/FontDecorations.ui 2f9aca1 > plugins/variables/FixedDateFormat.ui ff181ac > sheets/dialogs/DataFormatWidget.ui 5205d22 > sheets/dialogs/FontWidget.ui d0cb129 > sheets/dialogs/PositionWidget.ui 2b5dedb > sheets/dialogs/ProtectionWidget.ui 62f20d7 > sheets/dialogs/SpecialPasteWidget.ui 623d107 > sheets/dialogs/SubtotalWidget.ui 1a68bf7 > sheets/part/dialogs/SheetPropertiesWidget.ui bb73166 > sheets/part/dialogs/SheetSelectWidget.ui 3842e7a > sheets/plugins/scripting/scripts/htmlexportinfos.ui 214ed86 > sheets/plugins/solver/SolverDetailsWidget.ui 18a09d7 > sheets/plugins/solver/SolverMainWidget.ui d57e35b > words/part/dialogs/KWStartupWidget.ui c198d88 > > Diff: http://git.reviewboard.kde.org/r/108097/diff/ > > > Testing > ------- > > Looked at all UI files with designer, looked all okay/better. > > > Thanks, > > Friedrich W. H. Kossebau > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
