-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108459/
-----------------------------------------------------------
(Updated Jan. 20, 2013, 8:44 a.m.)
Review request for Calligra and Thorsten Zachmann.
Changes
-------
fixed reported crash
Description
-------
Change KoTextAnchor into two new classes
KoShapeANchor - which in theory should be moved to flake later
KoAnchorInlineObject - which is the kotext part responsible for being an
inline object
No realy user visible changes coming out of this but it's nessesary ground
work for the next step
I have had to disable several commands so we loos that functionality
This will be reenabled with the following commits which adds a third class
Diffs (updated)
-----
libs/kotext/CMakeLists.txt d465769
libs/kotext/KoAnchorInlineObject.h PRE-CREATION
libs/kotext/KoAnchorInlineObject.cpp PRE-CREATION
libs/kotext/KoAnchorTextRange.h PRE-CREATION
libs/kotext/KoAnchorTextRange.cpp PRE-CREATION
libs/kotext/KoShapeAnchor.h PRE-CREATION
libs/kotext/KoShapeAnchor.cpp PRE-CREATION
libs/kotext/KoTextAnchor.h 4ec3f03
libs/kotext/KoTextAnchor.cpp 1f2e8c5
libs/kotext/KoTextEditor.h 5c78240
libs/kotext/KoTextEditor.cpp 414b5dc
libs/kotext/KoTextRange.h 78515d9
libs/kotext/KoTextRange.cpp 61cbfa2
libs/kotext/commands/ChangeAnchorPropertiesCommand.h f1448ad
libs/kotext/commands/ChangeAnchorPropertiesCommand.cpp 50e9f55
libs/kotext/commands/ChangeTrackedDeleteCommand.cpp 966d990
libs/kotext/commands/DeleteAnchorsCommand.h d98b858
libs/kotext/commands/DeleteAnchorsCommand.cpp 4d4cbcf
libs/kotext/commands/DeleteCommand.h a0004a6
libs/kotext/commands/DeleteCommand.cpp 5d39f4f7
libs/kotext/opendocument/KoTextLoader.cpp d024996
libs/kotext/opendocument/KoTextSharedLoadingData.h b247992
libs/kotext/opendocument/KoTextSharedLoadingData.cpp ff609d1
libs/kotext/opendocument/KoTextWriter_p.h f3466e1
libs/kotext/opendocument/KoTextWriter_p.cpp 39cf629
libs/textlayout/AnchorStrategy.h f0853f1
libs/textlayout/AnchorStrategy.cpp a7dbec1
libs/textlayout/FloatingAnchorStrategy.h 090efea
libs/textlayout/FloatingAnchorStrategy.cpp 1364df1
libs/textlayout/InlineAnchorStrategy.h 24d3051
libs/textlayout/InlineAnchorStrategy.cpp c21f62b
libs/textlayout/KoTextDocumentLayout.h ef7c197
libs/textlayout/KoTextDocumentLayout.cpp dcb4c8a
libs/textlayout/KoTextLayoutArea.cpp a503f81
libs/textlayout/KoTextShapeContainerModel.h 93b8a4d
libs/textlayout/KoTextShapeContainerModel.cpp f19efa5
libs/textlayout/KoTextShapeData.cpp 9d096ef
plugins/textshape/commands/ShowChangesCommand.cpp a486c113
words/part/KWDocument.h dc64e5e
words/part/KWDocument.cpp 67f808d
words/part/KWOdfSharedLoadingData.h 7893cb9
words/part/KWOdfSharedLoadingData.cpp 58f533b
words/part/KWOdfWriter.cpp c9c72f7
words/part/KWRootAreaProvider.cpp 9a86d5d
words/part/KWView.h e86cc5c
words/part/KWView.cpp c9405df
words/part/commands/KWShapeCreateCommand.h a6e2852
words/part/commands/KWShapeCreateCommand.cpp 4781c390
words/part/dialogs/KWAnchoringProperties.h 14ac2d4
words/part/dialogs/KWAnchoringProperties.cpp fe97a23
words/part/frames/KWFrame.h 757c4ec
words/part/frames/KWFrame.cpp e30e8f0
words/part/frames/KWFrameLayout.cpp 5ad85ed
Diff: http://git.reviewboard.kde.org/r/108459/diff/
Testing
-------
I've create two small documents and they load fine.
I'd like Thorsten to run cstester on this to be sure
This review is not for final approval - as i need a second step, but it's a
nice logical point to do a review
In several commands i've disabled some stuff because it would be a vaste of
time to fix it only to break it again with part2.
But loading and saving and display should be just as good as before, and the
code so far should make sense - so please review that
Thanks,
C. Boemann
_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
