----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108481/#review25829 -----------------------------------------------------------
I have some reservations against this. In general I think this is the way we should go but I think we should come up with a general solution instead of patchinga single use case I've been trying to do that grand solution half a year ago, but got sidetracked. So I would prefer that this does not go in - C. Boemann On Jan. 19, 2013, 9:11 a.m., Yue Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108481/ > ----------------------------------------------------------- > > (Updated Jan. 19, 2013, 9:11 a.m.) > > > Review request for Calligra. > > > Description > ------- > > After patch is applied, is a single parameter shape is selected in default > tool, parameter handles will be painted. If mouse move on the handles, will > temporarily switch to path tool so users can edit shape parameters. In > temporary path tool if mouse move off from the handles, current tool will be > switched back to default tool. > > Now double click in default tool can be used for other tasks, such as add a > new textbox for current shape. > > > Diffs > ----- > > libs/flake/KoParameterShape.h 9c0db7a > libs/flake/tools/KoPathTool.h af906bb > libs/flake/tools/KoPathTool.cpp 9dd8caf > libs/flake/tools/KoPathToolFactory.h 2aacfe5 > libs/flake/tools/KoPathToolFactory.cpp 1846c86 > plugins/defaultTools/defaulttool/DefaultTool.cpp db7c489 > plugins/defaultTools/defaulttool/SelectionDecorator.h 83e715e > plugins/defaultTools/defaulttool/SelectionDecorator.cpp 3e16cfa > > Diff: http://git.reviewboard.kde.org/r/108481/diff/ > > > Testing > ------- > > works in words, stage, flow, karbon > > > Thanks, > > Yue Liu > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
