Re: Review Request: import csv-file into existing table

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107330/#review23504 --- This review has been submitted with commit cb692dbe4c69b38a6df

Re: Review Request: import csv-file into existing table

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107330/#review23494 --- Ship it! Ship It! - Jarosław Staniek On Dec. 13, 2012, 11:3

Re: Review Request: import csv-file into existing table

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107330/ --- (Updated Dec. 13, 2012, 11:35 p.m.) Review request for Calligra, Jarosław

Re: Review Request: import csv-file into existing table

> On Nov. 25, 2012, 6:15 p.m., Jarosław Staniek wrote: > > "Fields count does not match" error is displayed on appending if the > > destination table is identical but contains extra primary-key column > > (generated by Kexi). I know this case is just not supported now. We would > > try to impo

Re: Review Request: import csv-file into existing table

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107330/#review23141 --- Ship it! Congratulations, Oleg. That's a nice and well impleme

Re: Review Request: import csv-file into existing table

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107330/ --- (Updated Dec. 5, 2012, 3:46 p.m.) Review request for Calligra, Jarosław St

Re: Review Request: import csv-file into existing table

> On Dec. 2, 2012, 12:41 a.m., Jarosław Staniek wrote: > > > > > > - Perhaps it's earlier bug but please look at numbers on the vertical > > header (it's "2, 2, 3", instead of "1, 2, 3"): > > http://wstaw.org/m/2012/12/02/plasma-desktoppx2099.png > > Test data (autodetected separator is ','):

Re: Review Request: import csv-file into existing table

> On Dec. 2, 2012, 12:41 a.m., Jarosław Staniek wrote: > > > > > > - Perhaps it's earlier bug but please look at numbers on the vertical > > header (it's "2, 2, 3", instead of "1, 2, 3"): > > http://wstaw.org/m/2012/12/02/plasma-desktoppx2099.png > > Test data (autodetected separator is ','):

Re: Review Request: import csv-file into existing table

> On Dec. 2, 2012, 12:41 a.m., Jarosław Staniek wrote: > > > > > > - Perhaps it's earlier bug but please look at numbers on the vertical > > header (it's "2, 2, 3", instead of "1, 2, 3"): > > http://wstaw.org/m/2012/12/02/plasma-desktoppx2099.png > > Test data (autodetected separator is ','):

Re: Review Request: import csv-file into existing table

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107330/#review22901 --- - Perhaps it's earlier bug but please look at numbers on the

Re: Review Request: import csv-file into existing table

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107330/ --- (Updated Dec. 1, 2012, 11:59 p.m.) Review request for Calligra, Jarosław S

Re: Review Request: import csv-file into existing table

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107330/#review22897 --- kexi/plugins/importexport/csv/kexicsvimportdialog.cpp

Re: Review Request: import csv-file into existing table

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107330/ --- (Updated Dec. 1, 2012, 10:57 p.m.) Review request for Calligra, Jarosław S

Re: Review Request: import csv-file into existing table

> On Nov. 25, 2012, 6:15 p.m., Jarosław Staniek wrote: > > "Fields count does not match" error is displayed on appending if the > > destination table is identical but contains extra primary-key column > > (generated by Kexi). I know this case is just not supported now. We would > > try to impo

Re: Review Request: import csv-file into existing table

> On Nov. 25, 2012, 5:14 p.m., Jarosław Staniek wrote: > > Error encountered: > > Creating table failed. Error while executing SQL statement. > > Message from server: duplicate column name: Text > > SQL statement: CREATE TABLE votersbook_small2 (id INTEGER PRIMARY KEY, > > Text, a Text, Text, b

Re: Review Request: import csv-file into existing table

> On Nov. 25, 2012, 4:59 p.m., Jarosław Staniek wrote: > > Detection of import options does not work when I click Back and pick > > different file. For example if space delimiter was detected initially, and > > later comma-separated file is picked, this is not detected. fixed - Oleg --

Re: Review Request: import csv-file into existing table

> On Nov. 25, 2012, 4:56 p.m., Jarosław Staniek wrote: > > If I forget to select source filename, `Cannot open input file "".` error > > pops up. How about displaying dedicated error (we did that in > > migration/importwizard.cpp:868 too). fixed - Oleg -

Re: Review Request: import csv-file into existing table

> On Nov. 24, 2012, 11:10 p.m., Jarosław Staniek wrote: > > kexi/plugins/importexport/csv/kexicsvimportdialog.cpp, line 1802 > > > > > > -> An error using i18nc - Oleg -

Re: Review Request: import csv-file into existing table

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107330/#review22525 --- "Fields count does not match" error is displayed on appending i

Re: Review Request: import csv-file into existing table

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107330/#review22519 --- Error encountered: Creating table failed. Error while executin

Re: Review Request: import csv-file into existing table

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107330/#review22515 --- kexi/plugins/importexport/csv/kexicsvimportdialog.cpp

Re: Review Request: import csv-file into existing table

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107330/#review22514 --- Detection of import options does not work when I click Back and

Re: Review Request: import csv-file into existing table

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107330/#review22511 --- If I forget to select source filename, `Cannot open input file

Re: Review Request: import csv-file into existing table

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107330/#review22510 --- kexi/plugins/importexport/csv/kexicsvimportdialog.cpp

Re: Review Request: import csv-file into existing table

Dear Oleg, reviewed the whole patch now. On 15 November 2012 00:16, Oleg Kukharchuk wrote: >This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107330/ > Review request for Calligra, Jarosław Staniek, Adam Pigg, and Dimitrios > Tanis. > By Oleg K

Re: Review Request: import csv-file into existing table

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107330/#review22496 --- kexi/plugins/importexport/csv/kexicsvimportdialog.cpp

Re: Review Request: import csv-file into existing table

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107330/#review22467 --- kexi/plugins/importexport/csv/kexicsvimportdialog.cpp

Re: Review Request: import csv-file into existing table

> On Nov. 22, 2012, 11:22 p.m., Jarosław Staniek wrote: > > kexi/doc/kexidb/kexidb.doxygen, line 1 > > > > > > please commit kexidb.doxygen separately to master commit 43f528d8 > On Nov. 22, 2012, 11:22 p.m., Jaros

Re: Review Request: import csv-file into existing table

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107330/ --- (Updated Nov. 23, 2012, 2:06 p.m.) Review request for Calligra, Jarosław S

Re: Review Request: import csv-file into existing table

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107330/#review22404 --- kexi/doc/kexidb/kexidb.doxygen

Re: Review Request: import csv-file into existing table

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107330/ --- (Updated Nov. 14, 2012, 11:17 p.m.) Review request for Calligra, Jarosław

Review Request: import csv-file into existing table

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107330/ --- Review request for Calligra, Jarosław Staniek, Adam Pigg, and Dimitrios Tani