----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107330/#review22467 -----------------------------------------------------------
kexi/plugins/importexport/csv/kexicsvimportdialog.cpp <http://git.reviewboard.kde.org/r/107330/#comment17210> It's better to use dedicated void KAssistantDialog::setAppropriate(KPageWidgetItem *page, bool appropriate) in the place where we create the respective page. See ImportWizard::ImportWizard() for example (migration/importwizard.cpp). kexi/plugins/importexport/csv/kexicsvimportdialog.cpp <http://git.reviewboard.kde.org/r/107330/#comment17214> It would be good to move setup code for each page to separate setup*() method, like we do in ImportWizard (setupIntro, setupSrcConn, ..) kexi/plugins/importexport/csv/kexicsvimportdialog.cpp <http://git.reviewboard.kde.org/r/107330/#comment17211> For new/updated strings I propose to use i18nc("@info", "Loading CSV Data from <filename>%1</filename>...", ... More at: http://techbase.kde.org/Development/Tutorials/Localization/i18n_Semantics I know it's initially hard to remember but we'd like to go to these tags everywhere in Kexi for consistency and benefit of translators. kexi/plugins/importexport/csv/kexicsvimportdialog.cpp <http://git.reviewboard.kde.org/r/107330/#comment17212> it's better not to do 'center on screen' and adjustSize() every time user enters to a page - Jarosław Staniek On Nov. 23, 2012, 2:06 p.m., Oleg Kukharchuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107330/ > ----------------------------------------------------------- > > (Updated Nov. 23, 2012, 2:06 p.m.) > > > Review request for Calligra, Jarosław Staniek, Adam Pigg, and Dimitrios Tanis. > > > Description > ------- > > * moved to a KAssistantDialog > * added ability to import into an existent table > > > Diffs > ----- > > kexi/plugins/importexport/csv/kexicsvimportdialog.h > 15be3504dfc54877bc45d81eb7e59a72f70c9c5a > kexi/plugins/importexport/csv/kexicsvimportdialog.cpp > 5176299599ab034bf256f07ee2651d8a4babb3a0 > kexi/widget/fields/KexiFieldListModel.cpp > 91ed791065a34d8a137dc84997506bdd0643b231 > libs/db/drivers/sqlite/sqlitepreparedstatement.cpp > ffb751ebb1c87c32db95f48797e4c358c7b17991 > > Diff: http://git.reviewboard.kde.org/r/107330/diff/ > > > Testing > ------- > > tested on local branch > and additional testing needed > > (code was not cleaned up yet) > > > Thanks, > > Oleg Kukharchuk > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
