-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107330/#review22525
-----------------------------------------------------------


"Fields count does not match" error is displayed on appending if the 
destination table is identical but contains extra primary-key column (generated 
by Kexi). I know this case is just not supported now. We would try to import if 
no primary key is defined for imported data but it is present in the 
destination table. This could happen silently.


kexi/plugins/importexport/csv/kexicsvimportdialog.cpp
<http://git.reviewboard.kde.org/r/107330/#comment17239>

    The last page after successful importing is getting enlarged. This is not 
looking good.


- Jarosław Staniek


On Nov. 23, 2012, 2:06 p.m., Oleg Kukharchuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107330/
> -----------------------------------------------------------
> 
> (Updated Nov. 23, 2012, 2:06 p.m.)
> 
> 
> Review request for Calligra, Jarosław Staniek, Adam Pigg, and Dimitrios Tanis.
> 
> 
> Description
> -------
> 
> * moved to a KAssistantDialog
> * added ability to import into an existent table
> 
> 
> Diffs
> -----
> 
>   kexi/plugins/importexport/csv/kexicsvimportdialog.h 
> 15be3504dfc54877bc45d81eb7e59a72f70c9c5a 
>   kexi/plugins/importexport/csv/kexicsvimportdialog.cpp 
> 5176299599ab034bf256f07ee2651d8a4babb3a0 
>   kexi/widget/fields/KexiFieldListModel.cpp 
> 91ed791065a34d8a137dc84997506bdd0643b231 
>   libs/db/drivers/sqlite/sqlitepreparedstatement.cpp 
> ffb751ebb1c87c32db95f48797e4c358c7b17991 
> 
> Diff: http://git.reviewboard.kde.org/r/107330/diff/
> 
> 
> Testing
> -------
> 
> tested on local branch
> and additional testing needed
> 
> (code was not cleaned up yet)
> 
> 
> Thanks,
> 
> Oleg Kukharchuk
> 
>

_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Reply via email to