----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107330/#review22404 -----------------------------------------------------------
kexi/doc/kexidb/kexidb.doxygen <http://git.reviewboard.kde.org/r/107330/#comment17172> please commit kexidb.doxygen separately to master kexi/main/kexinamewidget.h <http://git.reviewboard.kde.org/r/107330/#comment17174> This file was moved to kexi/widget/ already on Oct 15 (commit 8a2624aaa to master), so please merge master onto your branch. kexi/plugins/importexport/csv/CMakeLists.txt <http://git.reviewboard.kde.org/r/107330/#comment17175> we do not need to depend on main/ here, see the previous comment; otherwise existence of core/ makes little sense kexi/plugins/importexport/csv/kexicsvimportdialog.h <http://git.reviewboard.kde.org/r/107330/#comment17176> m_ prefix needed kexi/plugins/importexport/csv/kexicsvimportdialog.cpp <http://git.reviewboard.kde.org/r/107330/#comment17177> m_importCancelled is declared after m_fieldsListModel, please reorder and check other cases - Jarosław Staniek On Nov. 14, 2012, 11:17 p.m., Oleg Kukharchuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107330/ > ----------------------------------------------------------- > > (Updated Nov. 14, 2012, 11:17 p.m.) > > > Review request for Calligra, Jarosław Staniek, Adam Pigg, and Dimitrios Tanis. > > > Description > ------- > > * moved to a KAssistantDialog > * added ability to import into an existent table > > > Diffs > ----- > > kexi/doc/kexidb/kexidb.doxygen ebfa7741ac624c818a6ab88470be672095b188ee > kexi/main/kexinamewidget.h 870c3668128798b25ab7d646393c5c6eb9086b9a > kexi/plugins/importexport/csv/CMakeLists.txt > f8da4e24dfc19055d009ee845514e567ef843eff > kexi/plugins/importexport/csv/kexicsvimportdialog.h > 15be3504dfc54877bc45d81eb7e59a72f70c9c5a > kexi/plugins/importexport/csv/kexicsvimportdialog.cpp > 18fafd486c13cfae943f2af0078fca93b83c4315 > kexi/widget/fields/KexiFieldListModel.cpp > 91ed791065a34d8a137dc84997506bdd0643b231 > libs/db/connection.cpp d36def0c1b66440c79fa617bc185b47cf2d67d06 > libs/db/drivers/sqlite/sqlitepreparedstatement.cpp > ffb751ebb1c87c32db95f48797e4c358c7b17991 > libs/db/object.cpp c6585a72626f93d18085c42e8ea19ae92619cfff > > Diff: http://git.reviewboard.kde.org/r/107330/diff/ > > > Testing > ------- > > tested on local branch > and additional testing needed > > (code was not cleaned up yet) > > > Thanks, > > Oleg Kukharchuk > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
