Re: Review Request 108677: Add support for hyperlinks in kexi buttons

2013-10-21 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108677/#review42132 --- This review has been submitted with commit 2af594ef0bda8576992

Re: Review Request 108677: Add support for hyperlinks in kexi buttons

2013-10-21 Thread Oleg Kukharchuk
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108677/ --- (Updated Oct. 21, 2013, 8:11 p.m.) Status -- This change has been mar

Re: Review Request 108677: Add support for hyperlinks in kexi buttons

2013-10-16 Thread Jarosław Staniek
> On June 6, 2013, 9:41 p.m., Jarosław Staniek wrote: > > kexi/kexiutils/utils.h, line 565 > > > > > > missing ctor, in it we need to initialize all the attributes You're right, I'm sorry. - Jarosław

Re: Review Request 108677: Add support for hyperlinks in kexi buttons

2013-10-16 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108677/#review41848 --- Ship it! Good job! - Jarosław Staniek On Oct. 10, 2013, 12:

Re: Review Request 108677: Add support for hyperlinks in kexi buttons

2013-10-10 Thread Oleg Kukharchuk
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108677/ --- (Updated Oct. 10, 2013, 12:55 p.m.) Review request for Calligra, Adam Pigg

Re: Review Request 108677: Add support for hyperlinks in kexi buttons

2013-10-10 Thread Oleg Kukharchuk
> On June 6, 2013, 9:41 p.m., Jarosław Staniek wrote: > > kexi/kexiutils/utils.h, line 559 > > > > > > no need to inherit QObject here, right? we need enum in the property editor, isn't it? see kexi/kexiutils/uti

Re: Review Request 108677: Add support for hyperlinks in kexi buttons

2013-06-06 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108677/#review33883 --- kexi/kexiutils/utils.h

Re: Review Request 108677: Add support for hyperlinks in kexi buttons

2013-06-02 Thread Oleg Kukharchuk
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108677/ --- (Updated June 2, 2013, 6:12 p.m.) Review request for Calligra, Adam Pigg,

Re: Review Request 108677: Add support for hyperlinks in kexi buttons

2013-06-02 Thread Oleg Kukharchuk
> On Feb. 1, 2013, 11:36 p.m., Jarosław Staniek wrote: > > kexi/kexiutils/KexiPushButton.cpp, line 84 > > > > > > Shouldn't we add here: > > if (executable) { KRun::run(); } > > Oleg Kukharchuk wrote: >

Re: Review Request 108677: Add support for hyperlinks in kexi buttons

2013-05-29 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108677/#review33383 --- kexi/kexiutils/KexiHyperLinkHandler.h

Re: Review Request 108677: Add support for hyperlinks in kexi buttons

2013-05-29 Thread Oleg Kukharchuk
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108677/ --- (Updated May 29, 2013, 8 p.m.) Review request for Calligra, Adam Pigg, Jar

Re: Review Request 108677: Add support for hyperlinks in kexi buttons

2013-02-06 Thread Jarosław Staniek
> On Feb. 1, 2013, 11:36 p.m., Jarosław Staniek wrote: > > kexi/kexiutils/KexiPushButton.cpp, line 84 > > > > > > Shouldn't we add here: > > if (executable) { KRun::run(); } > > Oleg Kukharchuk wrote: >

Re: Review Request 108677: Add support for hyperlinks in kexi buttons

2013-02-05 Thread Oleg Kukharchuk
> On Feb. 1, 2013, 11:36 p.m., Jarosław Staniek wrote: > > kexi/kexiutils/KexiPushButton.cpp, line 84 > > > > > > Shouldn't we add here: > > if (executable) { KRun::run(); } > > Oleg Kukharchuk wrote: >

Re: Review Request 108677: Add support for hyperlinks in kexi buttons

2013-02-03 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108677/#review26556 --- kexi/kexiutils/KexiPushButton.cpp

Re: Review Request 108677: Add support for hyperlinks in kexi buttons

2013-02-02 Thread Jarosław Staniek
> On Feb. 1, 2013, 11:36 p.m., Jarosław Staniek wrote: > > kexi/kexiutils/KexiPushButton.cpp, line 84 > > > > > > Shouldn't we add here: > > if (executable) { KRun::run(); } > > Oleg Kukharchuk wrote: >

Re: Review Request 108677: Add support for hyperlinks in kexi buttons

2013-02-02 Thread Oleg Kukharchuk
> On Feb. 1, 2013, 11:36 p.m., Jarosław Staniek wrote: > > kexi/kexiutils/KexiPushButton.cpp, line 84 > > > > > > Shouldn't we add here: > > if (executable) { KRun::run(); } You think KRun::runUrl(url, typ

Re: Review Request 108677: Add support for hyperlinks in kexi buttons

2013-02-01 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108677/#review26527 --- kexi/plugins/forms/widgets/kexidbcommandlinkbutton.cpp

Re: Review Request 108677: Add support for hyperlinks in kexi buttons

2013-02-01 Thread Oleg Kukharchuk
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108677/ --- (Updated Feb. 1, 2013, 12:57 p.m.) Review request for Calligra, Adam Pigg,

Re: Review Request 108677: Add support for hyperlinks in kexi buttons

2013-01-31 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108677/#review26483 --- kexi/kexiutils/CMakeLists.txt