----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108677/#review26527 -----------------------------------------------------------
kexi/plugins/forms/widgets/kexidbcommandlinkbutton.cpp <http://git.reviewboard.kde.org/r/108677/#comment20162> no need for ; here kexi/plugins/forms/widgets/kexidbcommandlinkbutton.cpp <http://git.reviewboard.kde.org/r/108677/#comment20163> empty line missing kexi/plugins/forms/widgets/kexidbcommandlinkbutton.cpp <http://git.reviewboard.kde.org/r/108677/#comment20164> empty line missing before kexi/plugins/forms/widgets/kexidbpushbutton.cpp <http://git.reviewboard.kde.org/r/108677/#comment20165> empty line missing before kexi/kexiutils/KexiPushButton.h <http://git.reviewboard.kde.org/r/108677/#comment20167> After testing in the GUI, I propose to reverse the logic by moving to bool remoteHyperlink, false by default. kexi/kexiutils/KexiPushButton.h <http://git.reviewboard.kde.org/r/108677/#comment20156> KexiPushButton::NoHyperlink -> NoHyperlink kexi/kexiutils/KexiPushButton.h <http://git.reviewboard.kde.org/r/108677/#comment20157> like above kexi/kexiutils/KexiPushButton.h <http://git.reviewboard.kde.org/r/108677/#comment20160> no need for \a here kexi/kexiutils/KexiPushButton.h <http://git.reviewboard.kde.org/r/108677/#comment20158> no need for \a here kexi/kexiutils/KexiPushButton.h <http://git.reviewboard.kde.org/r/108677/#comment20159> no need for \a here kexi/kexiutils/KexiPushButton.cpp <http://git.reviewboard.kde.org/r/108677/#comment20168> Shouldn't we add here: if (executable) { KRun::run(....); } kexi/kexiutils/KexiPushButton.cpp <http://git.reviewboard.kde.org/r/108677/#comment20161> one space too much after "allowed:", sorry my mistake kexi/plugins/forms/kexidbfactory.cpp <http://git.reviewboard.kde.org/r/108677/#comment20166> "hyperLink" -> "hyperlink", otherwise this line won't work - Jarosław Staniek On Feb. 1, 2013, 12:57 p.m., Oleg Kukharchuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108677/ > ----------------------------------------------------------- > > (Updated Feb. 1, 2013, 12:57 p.m.) > > > Review request for Calligra, Adam Pigg, Jarosław Staniek, and Dimitrios Tanis. > > > Description > ------- > > added support for hyperlinks in kexidbpushbutton and kexicommandlinkbutton > > > Diffs > ----- > > kexi/kexiutils/CMakeLists.txt 19a3320b9138b54fdbbe1fee14dabb70cd1b9ba8 > kexi/kexiutils/KexiCommandLinkButton.h > e5270eaeacd4e563742ca1120caaaad561f45d69 > kexi/kexiutils/KexiCommandLinkButton.cpp > a1cff931012678b7c6dac09f4c70411c773db84e > kexi/kexiutils/KexiPushButton.h PRE-CREATION > kexi/kexiutils/KexiPushButton.cpp PRE-CREATION > kexi/plugins/forms/CMakeLists.txt 35142914417d12fba7d03078657690582d584612 > kexi/plugins/forms/kexidbfactory.cpp > f8bbab480e0ee92891617a3fe5e3bfbe51b78db8 > kexi/plugins/forms/kexiformview.cpp > 3ffc0a8d9f9f3171873a569b28e44b712d747162 > kexi/plugins/forms/widgets/KexiDBPushButton.h PRE-CREATION > kexi/plugins/forms/widgets/KexiDBPushButton.cpp PRE-CREATION > kexi/plugins/forms/widgets/kexidbautofield.cpp > daa3c2ee730bd232a7ff656d6a3d00c2d87007cf > kexi/plugins/forms/widgets/kexidbcommandlinkbutton.h > 39a68c8c43c912985992c389b88bd0c49aa7f703 > kexi/plugins/forms/widgets/kexidbcommandlinkbutton.cpp > 1592d2e0ba04a24cd856519fe4d988dd25eef5b9 > kexi/plugins/forms/widgets/kexipushbutton.h > c3b9113f0839a704c0807e70afff9a5bdf232d50 > kexi/plugins/forms/widgets/kexipushbutton.cpp > 0cfe327c83f6abc4597826456bed6f6bbabe7dbd > > Diff: http://git.reviewboard.kde.org/r/108677/diff/ > > > Testing > ------- > > > Thanks, > > Oleg Kukharchuk > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
