> On Feb. 1, 2013, 11:36 p.m., Jarosław Staniek wrote: > > kexi/kexiutils/KexiPushButton.cpp, line 84 > > <http://git.reviewboard.kde.org/r/108677/diff/2/?file=111331#file111331line84> > > > > Shouldn't we add here: > > if (executable) { KRun::run(....); } > > Oleg Kukharchuk wrote: > You think KRun::runUrl(url, type, q); not enough for that? Of course we > should use defaultHyperlinkTool for that.
You're right, no need to cover special case. I thought I found an obscure case but cannot reproduce that. If found, can be fixed later. Both static and dynamic case works as well as urls like file:///usr/bin/kate. I have related points thought: - a note: we shall think about security, not counting scripts, this feature is the first one that has access to executing arbitrary code - how about defaulting to only relative paths? for that we'd need another property - however, we're not supporting arguments, so we're not very unsafe so far; if we were, /usr/bin/rm -rf ~ would be possible - btw, why not supporting args, this would be usable feature, easy to implement, and users would be able to skip a need for programming in such case - for dynamic hyperlink type, how about setting the button's text (in Data mode only) to the hyperlink text? - Jarosław ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108677/#review26527 ----------------------------------------------------------- On Feb. 1, 2013, 12:57 p.m., Oleg Kukharchuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108677/ > ----------------------------------------------------------- > > (Updated Feb. 1, 2013, 12:57 p.m.) > > > Review request for Calligra, Adam Pigg, Jarosław Staniek, and Dimitrios Tanis. > > > Description > ------- > > added support for hyperlinks in kexidbpushbutton and kexicommandlinkbutton > > > Diffs > ----- > > kexi/kexiutils/CMakeLists.txt 19a3320b9138b54fdbbe1fee14dabb70cd1b9ba8 > kexi/kexiutils/KexiCommandLinkButton.h > e5270eaeacd4e563742ca1120caaaad561f45d69 > kexi/kexiutils/KexiCommandLinkButton.cpp > a1cff931012678b7c6dac09f4c70411c773db84e > kexi/kexiutils/KexiPushButton.h PRE-CREATION > kexi/kexiutils/KexiPushButton.cpp PRE-CREATION > kexi/plugins/forms/CMakeLists.txt 35142914417d12fba7d03078657690582d584612 > kexi/plugins/forms/kexidbfactory.cpp > f8bbab480e0ee92891617a3fe5e3bfbe51b78db8 > kexi/plugins/forms/kexiformview.cpp > 3ffc0a8d9f9f3171873a569b28e44b712d747162 > kexi/plugins/forms/widgets/KexiDBPushButton.h PRE-CREATION > kexi/plugins/forms/widgets/KexiDBPushButton.cpp PRE-CREATION > kexi/plugins/forms/widgets/kexidbautofield.cpp > daa3c2ee730bd232a7ff656d6a3d00c2d87007cf > kexi/plugins/forms/widgets/kexidbcommandlinkbutton.h > 39a68c8c43c912985992c389b88bd0c49aa7f703 > kexi/plugins/forms/widgets/kexidbcommandlinkbutton.cpp > 1592d2e0ba04a24cd856519fe4d988dd25eef5b9 > kexi/plugins/forms/widgets/kexipushbutton.h > c3b9113f0839a704c0807e70afff9a5bdf232d50 > kexi/plugins/forms/widgets/kexipushbutton.cpp > 0cfe327c83f6abc4597826456bed6f6bbabe7dbd > > Diff: http://git.reviewboard.kde.org/r/108677/diff/ > > > Testing > ------- > > > Thanks, > > Oleg Kukharchuk > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
