----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108677/#review26483 -----------------------------------------------------------
kexi/kexiutils/CMakeLists.txt <http://git.reviewboard.kde.org/r/108677/#comment20125> I propose to go with KexiPushButton.cpp/h - we're moving to CamelCase filenames. kexi/kexiutils/kexipushbutton.h <http://git.reviewboard.kde.org/r/108677/#comment20127> It would be good add some docs, and to document default values. kexi/kexiutils/kexipushbutton.cpp <http://git.reviewboard.kde.org/r/108677/#comment20126> no need to use m_ prefix for *Private classes kexi/kexiutils/kexipushbutton.cpp <http://git.reviewboard.kde.org/r/108677/#comment20128> Space after 'if' kexi/kexiutils/kexipushbutton.cpp <http://git.reviewboard.kde.org/r/108677/#comment20129> how about less technical -> Invalid hyperlink kexi/kexiutils/kexipushbutton.cpp <http://git.reviewboard.kde.org/r/108677/#comment20130> more informative: -> "Executable is not allowed: <link>%1</link>", url.url() kexi/kexiutils/kexipushbutton.cpp <http://git.reviewboard.kde.org/r/108677/#comment20131> more informative and simpler: -> "Remote hyperlink not allowed: <link>%1</link>", url.url() kexi/plugins/forms/kexidbfactory.cpp <http://git.reviewboard.kde.org/r/108677/#comment20132> KexiPushButton should be kept for backward compatibility I guess. How about adding another line with the call? kexi/plugins/forms/kexidbfactory.cpp <http://git.reviewboard.kde.org/r/108677/#comment20133> -> "Local Hyperlink" kexi/plugins/forms/kexidbfactory.cpp <http://git.reviewboard.kde.org/r/108677/#comment20134> -> "Executable Hyperlink" kexi/plugins/forms/kexidbfactory.cpp <http://git.reviewboard.kde.org/r/108677/#comment20135> we shall keep the condition c == "KexiPushButton" as well for backward compatibility, right? kexi/plugins/forms/kexidbfactory.cpp <http://git.reviewboard.kde.org/r/108677/#comment20136> classname == "KexiPushButton" || classname == "KexiDBPushButton" kexi/plugins/forms/kexiformview.cpp <http://git.reviewboard.kde.org/r/108677/#comment20137> see note like above kexi/plugins/forms/widgets/kexidbcommandlinkbutton.cpp <http://git.reviewboard.kde.org/r/108677/#comment20138> return not needed here kexi/plugins/forms/widgets/kexidbpushbutton.h <http://git.reviewboard.kde.org/r/108677/#comment20139> explicit KexiDBPushButton(const QString & text, QWidget * parent = 0); kexi/plugins/forms/widgets/kexidbpushbutton.h <http://git.reviewboard.kde.org/r/108677/#comment20140> I propose to move to a d-pointer. kexi/plugins/forms/widgets/kexidbpushbutton.cpp <http://git.reviewboard.kde.org/r/108677/#comment20141> this return makes no sense here - Jarosław Staniek On Jan. 30, 2013, 7:42 p.m., Oleg Kukharchuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108677/ > ----------------------------------------------------------- > > (Updated Jan. 30, 2013, 7:42 p.m.) > > > Review request for Calligra, Adam Pigg, Jarosław Staniek, and Dimitrios Tanis. > > > Description > ------- > > added support for hyperlinks in kexidbpushbutton and kexicommandlinkbutton > > > Diffs > ----- > > kexi/examples/Simple_Database.kexi c34cc7d805d3f6119df23a2240c8149854743afb > kexi/kexiutils/CMakeLists.txt 19a3320b9138b54fdbbe1fee14dabb70cd1b9ba8 > kexi/kexiutils/KexiCommandLinkButton.h > e5270eaeacd4e563742ca1120caaaad561f45d69 > kexi/kexiutils/KexiCommandLinkButton.cpp > a1cff931012678b7c6dac09f4c70411c773db84e > kexi/kexiutils/kexipushbutton.h PRE-CREATION > kexi/kexiutils/kexipushbutton.cpp PRE-CREATION > kexi/plugins/forms/CMakeLists.txt 35142914417d12fba7d03078657690582d584612 > kexi/plugins/forms/kexidbfactory.cpp > f8bbab480e0ee92891617a3fe5e3bfbe51b78db8 > kexi/plugins/forms/kexiformview.cpp > 3ffc0a8d9f9f3171873a569b28e44b712d747162 > kexi/plugins/forms/widgets/kexidbautofield.cpp > daa3c2ee730bd232a7ff656d6a3d00c2d87007cf > kexi/plugins/forms/widgets/kexidbcommandlinkbutton.h > 39a68c8c43c912985992c389b88bd0c49aa7f703 > kexi/plugins/forms/widgets/kexidbcommandlinkbutton.cpp > 1592d2e0ba04a24cd856519fe4d988dd25eef5b9 > kexi/plugins/forms/widgets/kexidbpushbutton.h PRE-CREATION > kexi/plugins/forms/widgets/kexidbpushbutton.cpp PRE-CREATION > kexi/plugins/forms/widgets/kexipushbutton.h > c3b9113f0839a704c0807e70afff9a5bdf232d50 > kexi/plugins/forms/widgets/kexipushbutton.cpp > 0cfe327c83f6abc4597826456bed6f6bbabe7dbd > > Diff: http://git.reviewboard.kde.org/r/108677/diff/ > > > Testing > ------- > > > Thanks, > > Oleg Kukharchuk > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
