RE: Does it ever load?

2015-03-05 Thread matus uzak
Hey, anything special about the document? Or a deadlock in the layout engine? :) On Mar 4, 2015 3:04 PM, "C. Boemann" wrote: > It probably doesn't load if it has been stuck that long - feel free to > mail me the file privately if you want me to take a look and possibly fix it > > -Original M

Re: Review Request 111734: add test for ppt conversion

2013-07-27 Thread Matus Uzak
sentations/ |-import/powerpoint/ |-import/share/bin/runtests.sh |-import/share/xsl/sharedtemplates.xsl - Matus Uzak On July 26, 2013, 8:41 p.m., Jos van den Oever wrote: > > --- > This is an automatically generated e-

Re: Review Request 111264: fix unwanted changing of m_name in DocxXmlStylesReader::read_style()

2013-06-28 Thread Matus Uzak
the class but if it would be used, then it must have the same value as was assigned to the styleName variable. Both should contain the same style name with spaces replaced by an underscore. - Matus Uzak On June 26, 2013, 9:22 p.m., Friedrich W. H. Kossebau wrote

Re: a new library for traversing odf files and a new export filter

2013-03-26 Thread matus . uzak
> > See also somewhat related XmlWriteBuffer in > filters/libmsooxml/MsooXmlUtils.h which is used "when information that has > to be written in advance is based on XML elements parsed later. In such > case the information cannot be saved in one pass" for OOXML=>ODF. > The worst thing is relative l

Re: a new library for traversing odf files and a new export filter

2013-03-26 Thread matus . uzak
Hi, I would like to add that Theme Colors from MSOOXML are causing us big problems (invisible text mostly) because named styles and MasterSlide/SlideLayout styles (PPTX) are based on them. The color map might change with each slide/section of a document. At the moment we calculate the color for

Re: a new library for traversing odf files and a new export filter

2013-03-25 Thread matus . uzak
code in XSLT using XPath, it could be Ok. But not that Ok in means of performance. br, Matus Uzak ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 109370: Support same style names in different families

2013-03-09 Thread Matus Uzak
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109370/#review28847 --- Ship it! Ship It! - Matus Uzak On March 9, 2013, 12:43 p.m

Re: Review Request 109370: Support same style names in different families

2013-03-09 Thread Matus Uzak
ttp://git.reviewboard.kde.org/r/109370/#comment21597> This is always a paragraph style. - Matus Uzak On March 9, 2013, 12:43 p.m., Thorsten Zachmann wrote: > > --- > This is an automatically generated e-mail. To reply

calligra sprint - need a lift from Wetter (Ruhr)

2013-03-06 Thread matus . uzak
Hi, anybody going by car? I could use a lift from Wetter [1]. :) [1] Stadt Wetter (Ruhr) 58300 Wetter, Germany br, Matus ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Questions on POLE library (and HancomWord support)

2013-01-06 Thread matus . uzak
Hi, compared to the latest version found at [1], the version of POLE inside libmso includes a number of bug fixes and code to detect invalid and corrupt files in the Windows Compound Binary File Format. It's not maintained as a separate library, It's simply part of libmso. And you should know it

Re: Review Request: Fixed ' may be used uninitialized' warnings

2012-08-02 Thread Matus Uzak
ce m_svgChHeight is in class scope it should be > initialized in the ctor. having initializing in more than one place would be > error prone. > > The idea of these macros is apparently that the destination variables are > initialized (once) anyway, possibly in place where th

Re: Review Request: Fixed ' may be used uninitialized' warnings

2012-07-31 Thread Matus Uzak
/#review15973 --- On July 11, 2012, 9:43 p.m., Jarosław Staniek wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105519/ >

Re: Mac OS X - quo vadis calligra, calligraconverter

2012-05-31 Thread matus . uzak
.. well if you are a designer working on Mac and prepare or modify presentation templates for both Mac and MS Office users in MS Formats then it matters a lot. Also many users still don't export presentations to pdf and if they are forced to use a local MS Windows/GNU Linux machine for their presen

Re: Mac OS X - quo vadis calligra, calligraconverter

2012-05-31 Thread matus . uzak
yes, I noticed a number of issues on ODP files created by our filters in OOo/LO and both the ppt and the pptx filter have to be fine tuned. Unfortunately there are no bug reports. If we would encourage users to use the calligraconverter -> OOo/LO -> ODF/MSFormats approach, bug reports would arrive

Re: Mac OS X - quo vadis calligra, calligraconverter

2012-05-31 Thread matus . uzak
Hi, > Based on my experience, people use mostly iWork for Keynote, which is supposed > to be the best thing to make presentations. Yes, might be. But is it the best thing if you must retain compatibility with MS Office? And by package I mean binary package with filters as libraries or compiled

Re: Mac OS X - quo vadis calligra, calligraconverter

2012-05-30 Thread matus . uzak
Hi again, > And iWork sucks at that? After all they claim support*. Or is too expensive? I > would have guessed that iWork (Pages, Numbers, Keynote) is the natural choice > on OS X. Hm, all already 3 years old? So I guess they just suck to a degree :) > Or have a too unfamiliar interface/UX, compa

Mac OS X - quo vadis calligra, calligraconverter

2012-05-30 Thread matus . uzak
and increase the number of bug reports. [1] http://www.calligra.org/get-calligra/ br, -matus uzak ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Position of text:p inside draw:custom-shape - validation issue

2012-05-25 Thread matus . uzak
Hi, the ordered sequence complicates things in filters a lot. There is a predefined sequence of containers in MS-ODRAW and OOXML but it's almost a wonder if a file follows it 100%. Another example where we don't follow the schema I found recently is , which should come before columns and cells.

Position of text:p inside draw:custom-shape - validation issue

2012-05-24 Thread matus . uzak
Hi, I'm getting the following validation result. Does the position of text:p inside draw:custom-shape really matters? Seems there's a requirement it can not be the last child element. $ validateODF.py custom_shape_test.ods tmp/tmp60j5s1_content.xml:240:42: error: element "text:p" not allowed

File->Save As - not functional ?

2012-05-24 Thread matus . uzak
Hi, anyone else having problems with File->Save As functionality? (I did not use it for a longer while) Any hints? words(25969)/koffice (filter manager) KoFilterEntry::query: KoFilterEntry::query( "" ) words(25969)/koffice (filter manager) ::buildGraph: Filter: "CSV Import Filter for KSpread"

Review Request: Let's use draw:opacity instead of draw:transparency.

2012-05-24 Thread Matus Uzak
info got lost at save time. :( Thanks, Matus Uzak ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: - ODF usability limitation / current support

2012-05-23 Thread matus . uzak
h OOo/LO. > And to make a aproposal to the ODF TC to update the usability > limitation for . > > 14.1 > > The element is usable within the following elements: > 9.1.5, 9.1.4, 6.1.8, > 5.1.2, 6.1.9, 7.5.19, 5.1.3, > 6.4.2 and 6.1.7. > > br, > > -m

- ODF usability limitation / current support

2012-05-23 Thread matus . uzak
create them to maintain interoperability with OOo/LO. And to make a aproposal to the ODF TC to update the usability limitation for . 14.1 The element is usable within the following elements: 9.1.5, 9.1.4, 6.1.8, 5.1.2, 6.1.9, 7.5.19, 5.1.3, 6.4.2 and 6.1.7. br, -matus uzak

Re: calligratests/interoperability - XSL templates and makefiles, were are you?

2012-05-21 Thread matus . uzak
calligratests/import which use the same approach. For inspiration. :) Can we also include those to tests on the build server? br, -matus uzak On Fri, May 18, 2012 at 1:50 PM, wrote: > Hi, > > I noticed lately that the directory structure and directory names in > calligratests/interoper

calligratests/interoperability - XSL templates and makefiles, were are you?

2012-05-18 Thread matus . uzak
Hi, I noticed lately that the directory structure and directory names in calligratests/interoperability were changed. What happened to the accompanying XSL templates and makefiles? -matus uzak ___ calligra-devel mailing list calligra-devel@kde.org

Re: Fix ODF attributes style:wrap-contour-mode, style:wrap-contour and style:leader-text in docx filter.

2012-05-15 Thread matus . uzak
.. I checked again and I think it can stay as it is. On Mon, May 14, 2012 at 10:12 PM, Jos van den Oever wrote: > On Monday 14 May 2012 15:08:12 PM matus.u...@gmail.com wrote: >> Hi Jos, >> >> in ODF the default value of style:leader-text is “ “ (U+0020).  Docx: >> if there's no leader text speci

Re: fo:font-size may not be 0

2012-05-14 Thread matus . uzak
.. and one more comment. According to the MS-PPT spec. fontSize MUST be greater than or equal to 1 and less than or equal to 4000. Please send me any test file you have, there's something wrong going on in the filter when fontSize=0. I have to find the correct fontSize, else the application defa

Re: text:outline-level must be larger than 0.

2012-05-14 Thread matus . uzak
Hello again Jos, do you have any test files, where text:outline-level is set to zero? That means no paragraph styles to format TOC were found. And I would like to fix that. -cwriter->addAttribute("text:outline-level", levels); +if (levels > 0) { +cwriter->addAttribute

Re: Fix ODF attributes style:wrap-contour-mode, style:wrap-contour and style:leader-text in docx filter.

2012-05-14 Thread matus . uzak
Hi Jos, in ODF the default value of style:leader-text is “ “ (U+0020). Docx: if there's no leader text specified or it is "none", then there should be no space. The invisible space QChar(0x200B) solution as used for the text:bullet-char by Zagge would be fine. --- a/filters/words/docx/DocxXmlDoc

Re: calligra-devel Digest, Vol 19, Issue 67

2012-05-14 Thread matus . uzak
{yes, not}. Lightproof seems to be rule based. And rule based systems have strong maintainability drawbacks. A combination of a rule based system with Bayes sounds promising. That would enable something like context based grammar checking. br, -matus uzak On Sat, May 12, 2012 at 9:33 PM, Garima Joshi

Re: meta:comments ?

2012-05-03 Thread matus . uzak
.. but where did come from? it's not part of ODF 1.2. Should we replace it by in UI? I could then take care of filters to use instead of . On Thu, May 3, 2012 at 1:25 PM, C. Boemann wrote: > On Thursday 03 May 2012 13:18:40 Thorsten Zachmann wrote: >> On Thursday, May 03, 2012 11:41:34 AM m

meta:comments ?

2012-05-03 Thread matus . uzak
Hi, why do we use the el. across filters and support it in KoDocumentInfo.cpp and friends? LO and MSOffice use the el. instead and it's content seems to be unused in calligra. -matus uzak ___ calligra-devel mailing list calligra-devel@kde.org

Re: Input for ODF plugfest/TC call

2012-04-20 Thread Matus Uzak
core for each product. That is however quite some > work. > We have some tests in calligra, that would be better to have outside > Calligra. > > A good idea might be to organize a sprint to make such a system. The sprint > should have coders that are involved in the unit testing of t

Re: Words filter compiler error with GCC 4.7

2012-03-26 Thread Matus Uzak
; KDE Quality Team > > ___ > > calligra-devel mailing list > > calligra-devel@kde.org > > https://mail.kde.org/mailman/listinfo/calligra-devel > > > > -- > Best Regards, > Yue Liu > ___ > calligra

Re: warning C4129: '%' : unrecognized character escape sequence

2012-03-19 Thread Matus Uzak
Hi, I did not catch the irc conversation. The backslash in "\%" seems to be ignored internally. I don't think it's an undocumented escape sequence understood by QString, so I would remove it. Any objections from sebsauer and LukasT who were using those? -matus On Sun, Mar 18, 2012 at 4:52 AM,

Re: Review Request: KoXmlWriter - don't add control codes not accepted in XML 1.0 documents.

2012-03-15 Thread Matus Uzak
. Diffs (updated) - libs/odf/KoXmlWriter.cpp d51c61f Diff: http://git.reviewboard.kde.org/r/104288/diff/ Testing --- Usual round with cstrunner on binary file formats. A test file which contains a NAK: http://neuron.tuke.sk/~uzak/calligra/test-flipr-ses-2-5072.doc Thanks, Matus Uzak

Review Request: KoXmlWriter - don't add control codes not accepted in XML 1.0 documents.

2012-03-15 Thread Matus Uzak
://git.reviewboard.kde.org/r/104288/diff/ Testing --- Usual round with cstrunner on binary file formats. A test file which contains a NAK: http://neuron.tuke.sk/~uzak/calligra/test-flipr-ses-2-5072.doc Thanks, Matus Uzak ___ calligra-devel mailing list calligra

Re: [calligra] filters: libmsooxml: parse and use line styles from the DrawingML theme properly

2012-03-12 Thread Matus Uzak
902d6ed38dceee4f5f > > > > > > Great work the documents looks much better with this fixes in. > > > > > > I have them locally backported so I can commit if you want or we need > to > > > hurry due to tagging. > > > > I'd say, push them along -- th

Re: [calligra] filters: libmsooxml: parse and use line styles from the DrawingML theme properly

2012-03-09 Thread Matus Uzak
Hi, yes, my this week's commits should be backported to 2.4, because previously missing content gets displayed. Do I have to make review requests or are we fine with those? On Fri, Mar 9, 2012 at 2:02 PM, Boudewijn Rempt wrote: > On Thursday 08 March 2012 Mar, Matus Uzak wrote: > &

Re: Review Request: line heights of empty lines

2012-01-12 Thread Matus Uzak
not check the code itself, but it should be Ok according to tests result. [1] http://quickgit.kde.org/index.php?p=calligra.git&a=commit&h=d539c669c79eb83caa827025eabd1ef737eb85b5 - Matus Uzak On Jan. 9, 2012, 11:27 p.m., C. Boema

Re: Review Request: Added clearProperties function to the KoGenStyle class.

2011-11-16 Thread Matus Uzak
eviewboard.kde.org/r/103147/#review8216 --- On Nov. 15, 2011, 7:01 p.m., Matus Uzak wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103147/ > ---

Review Request: Added clearProperties function to the KoGenStyle class.

2011-11-15 Thread Matus Uzak
s/odf/KoGenStyle.h 5f50dd0 Diff: http://git.reviewboard.kde.org/r/103147/diff/diff Testing --- Tested in libmsooxml. Thanks, Matus Uzak ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Review Request: Added the removeAttribute/removeProperty pair to the KoGenStyle class.

2011-11-10 Thread Matus Uzak
removeAttribute/removeProperty pair to the KoGenStyle class as discussed in the mailing list. Diffs - libs/odf/KoGenStyle.h 986a23e Diff: http://git.reviewboard.kde.org/r/103107/diff/diff Testing --- Tested in libmsooxml. Thanks, Matus Uzak

Re: Review Request: Removing lbgsf dependency

2011-10-06 Thread Matus Uzak
sword-odf/wv2/src/parser9x.cpp <http://git.reviewboard.kde.org/r/102790/#comment6249> I must have removed this by an accident, thanks! :) - Matus Uzak On Oct. 6, 2011, 1:11 p.m., Stuart Dickson wrote: > > --- > This is

Re: Review Request: Fix crashes in the DOC filter

2011-09-06 Thread Matus Uzak
eview request for Calligra and Matus Uzak. > > > Summary > --- > > Attached patch fixes the both crash bugs > https://bugs.kde.org/show_bug.cgi?id=281112 and > https://bugs.kde.org/show_bug.cgi?id=281164 . > > I know it is a rather dirty way (see comments I add

Re: Review Request: Some dead code I do not know how to handle

2011-07-01 Thread Matus Uzak
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101803/#review4290 --- filters/words/msword-odf/wv2/src/ustring.cpp

Re: Review Request: one memory leak, 7 exceptions and two comparations.

2011-06-23 Thread Matus Uzak
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101730/#review4089 --- Please revert the changes committed to both ParsedPresentation.c

Re: Review Request: Lists bug fixes and enhancement

2011-04-11 Thread Matus Uzak
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100918/#review2557 --- plugins/textshape/TextShapeLayout.cpp

Re: Review Request: Lists bug fixes and enhancement

2011-04-07 Thread Matus Uzak
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100918/#review2454 --- libs/kotext/styles/KoListLevelProperties.cpp

Re: Review Request: Lists bug fixes and enhancement

2011-04-02 Thread Matus Uzak
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100918/#review2308 --- libs/kotext/styles/KoListLevelProperties.cpp

Re: Review Request: Fixes bug 264143

2011-02-22 Thread Matus Uzak
> On Feb. 22, 2011, 4:13 p.m., Boudewijn Rempt wrote: > > Quick note: it seems to improve the bullets in an odt imported from > > oowriter as well. They were too big, and look fine with the patch. Sure it did, we were using the default KoCharacterStyle in many cases because we are not loading

Re: Review Request: Fixes bug 264143

2011-02-22 Thread Matus Uzak
> On Feb. 21, 2011, 1:09 p.m., Matus Uzak wrote: > > plugins/textshape/Layout.cpp, line 1984 > > <http://git.reviewboard.kde.org/r/100679/diff/1/?file=9483#file9483line1984> > > > > Both MS Office and TeX use minimum here. > > Gopalakrishna Bhat wro

Re: Review Request: Fixes bug 264143

2011-02-21 Thread Matus Uzak
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100679/#review1553 --- Please sync with Lukas Tvrdy, he has already a patch for loading

Re: Review Request: Added creation and processing of a text style to format the number/bullet of a list.

2011-01-09 Thread Matus Uzak
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100306/ --- (Updated Jan. 9, 2011, 10:11 p.m.) Review request for Calligra. Changes

Re: Review Request: Added creation and processing of a text style to format the number/bullet of a list.

2011-01-09 Thread Matus Uzak
uses one local variable of type QString and 4 constant strings. Your uses 9 constant strings. Isn't memory allocated for each constant string? - Matus --- This is an automatically generated e-mail. To reply, vis

Re: Review Request: Added creation and processing of a text style to format the number/bullet of a list.

2011-01-08 Thread Matus Uzak
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100306/ --- (Updated Jan. 8, 2011, 8:13 p.m.) Review request for Calligra. Changes -

Re: Review Request: Added creation and processing of a text style to format the number/bullet of a list.

2011-01-07 Thread Matus Uzak
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100306/ --- (Updated 2011-01-07 13:05:58.101875) Review request for Calligra. Change

Re: Review Request: Added creation and processing of a text style to format the number/bullet of a list.

2011-01-07 Thread Matus Uzak
#x27;s better to not check for null strings only. - Matus ------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100306/#review745 --

Review Request: Added creation and processing of a text style to format the number/bullet of a list.

2011-01-05 Thread Matus Uzak
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100306/ --- Review request for Calligra. Summary --- Filter changes: * Let's use