> On Nov. 15, 2011, 8:28 p.m., Jarosław Staniek wrote:
> > libs/odf/KoGenStyle.h, line 318
> > <http://git.reviewboard.kde.org/r/103147/diff/1/?file=41105#file41105line318>
> >
> >     removeAllProperties() is more in sync with Qt (which has over 15 
> > removeAll*() methods)

Yes, removeAllProperties() is a much better name in a project using Qt.


- Matus


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103147/#review8216
-----------------------------------------------------------


On Nov. 15, 2011, 7:01 p.m., Matus Uzak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103147/
> -----------------------------------------------------------
> 
> (Updated Nov. 15, 2011, 7:01 p.m.)
> 
> 
> Review request for Calligra, Jarosław Staniek and C. Boemann.
> 
> 
> Description
> -------
> 
> Let's provide a function that clears properties of the defined type.  For 
> example text-properties from a paragraph style to maintain compatibility with 
> LO/OOo in specific cases.  There are use cases in libmsooxml at the moment, 
> where this could be very useful.
> 
> 
> Diffs
> -----
> 
>   libs/odf/KoGenStyle.h 5f50dd0 
> 
> Diff: http://git.reviewboard.kde.org/r/103147/diff/diff
> 
> 
> Testing
> -------
> 
> Tested in libmsooxml.
> 
> 
> Thanks,
> 
> Matus Uzak
> 
>

_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Reply via email to