----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104288/ -----------------------------------------------------------
(Updated March 15, 2012, 3:42 p.m.) Review request for Calligra, Thorsten Zachmann and C. Boemann. Changes ------- Comments addressed. Description ------- We already skip those codes in the addTextSpan function but not in the escapeForXML function called by addTextNode. Especially binary data (doc/ppt/xls) can contain those, most often the NAK control code. Diffs (updated) ----- libs/odf/KoXmlWriter.cpp d51c61f Diff: http://git.reviewboard.kde.org/r/104288/diff/ Testing ------- Usual round with cstrunner on binary file formats. A test file which contains a NAK: http://neuron.tuke.sk/~uzak/calligra/test-flipr-ses-2-5072.doc Thanks, Matus Uzak
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
