Re: Anatomy of the style manager

2013-05-30 Thread Pierre Stirnweiss
Hello Elvis, I am unfortunately kept away from coding by non hobby stuff at the moment. I have been working for quite a while on a new style manager. The current style manager is a mix of several partial rewrites on top of each other. I have started from scratch completely, using a QAbstractModel

Re: Review Request 109651: Refactor style manager

2013-03-26 Thread Pierre Stirnweiss
ed long paragraphStyleId = (paragraphStyle) ? > reinterpret_cast(paragraphStyle) : 0L; > > paragraphStyleId seems a misnomer now > > > - C. > > On March 25th, 2013, 5:28 a.m. UTC, Thorsten Zachmann wrote: > Review request for Calligra and Pierre Stirnweiss. > By Thorsten Zachmann. &g

Re: next release and release pace in general

2013-01-26 Thread Pierre Stirnweiss
On Fri, Jan 25, 2013 at 6:16 PM, Yuë Liu wrote: > We talked about having a testing branch before commit into master > branch last year. We can restrict commit right to master, let the > features committed to and tested in testing branch thoroughly. So > master will always keep stable. > > I don't

Re: next release and release pace in general

2013-01-24 Thread Pierre Stirnweiss
On Wed, Jan 23, 2013 at 8:07 PM, C. Boemann wrote: > On Wednesday 23 January 2013 18:25:59 Inge Wallin wrote: > > On Wednesday, January 23, 2013 12:05:43 C. Boemann wrote: > > > Hi > > > > > > I'm worried about our release pace. For 2.6 Words was able to make > > > exactly 0 new features. Sure we

Review Request 108532: Fix crash in krita master on style combo

2013-01-21 Thread Pierre Stirnweiss
plugins/textshape/dialogs/DockerStylesComboModel.cpp 472f8b4 plugins/textshape/dialogs/StylesModel.cpp a264855 Diff: http://git.reviewboard.kde.org/r/108532/diff/ Testing --- Thanks, Pierre Stirnweiss ___ calligra-devel mailing list calligra

Re: Review Request 108444: Fix cash on creating new character style

2013-01-18 Thread Pierre Stirnweiss
plugins/textshape/dialogs/StylesModel.cpp 80ea48d Diff: http://git.reviewboard.kde.org/r/108444/diff/ Testing --- Thanks, Pierre Stirnweiss ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 108444: Fix cash on creating new character style

2013-01-17 Thread Pierre Stirnweiss
not apply cleanly for me > against 2.6 at least. > > > - Friedrich W. H. > > On January 16th, 2013, 8:45 p.m. UTC, Pierre Stirnweiss wrote: > Review request for Calligra and Friedrich W. H. Kossebau. > By Pierre Stirnweiss. > > *Updated Jan. 16, 2013, 8:45 p.m.*

Review Request 108444: Fix cash on creating new character style

2013-01-16 Thread Pierre Stirnweiss
--- Thanks, Pierre Stirnweiss ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Review Request 108379: Fix merging style to caret

2013-01-13 Thread Pierre Stirnweiss
a style to the caret was not effective when the caret had no selection. This change correct that bug. Ok to backport? Diffs - libs/kotext/KoTextEditor_format.cpp 5a35fe8 Diff: http://git.reviewboard.kde.org/r/108379/diff/ Testing --- Thanks, Pierre Stirnweiss

Review Request: Fix crash on empty style list in StyleManager dialog

2013-01-11 Thread Pierre Stirnweiss
--- Thanks, Pierre Stirnweiss ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Review Request: Fix wrong style applied when backspace

2013-01-05 Thread Pierre Stirnweiss
://git.reviewboard.kde.org/r/108199/diff/ Testing --- Thanks, Pierre Stirnweiss ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: Fix applying style to a caret without a selection

2013-01-04 Thread Pierre Stirnweiss
and eventually the character style (if we set one). Ok to backport? Diffs - libs/kotext/KoTextEditor_format.cpp 7bd345b Diff: http://git.reviewboard.kde.org/r/108191/diff/ Testing --- Thanks, Pierre Stirnweiss ___ calligra-dev

Review Request: Fix applying style to a caret without a selection

2013-01-04 Thread Pierre Stirnweiss
(if we set one). Ok to backport? Diffs - libs/kotext/KoTextEditor_format.cpp 7bd345b Diff: http://git.reviewboard.kde.org/r/108191/diff/ Testing --- Thanks, Pierre Stirnweiss ___ calligra-devel mailing list calligra-deve

Review Request: Merge textshape-stylesWidget-PierreSt in master

2013-01-01 Thread Pierre Stirnweiss
/ Testing --- Played around with the combo. Also fixed some issues spotted by Boemann earlier. Thanks, Pierre Stirnweiss ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Review Request: Remove the default paragraph style from user visible lists

2012-12-31 Thread Pierre Stirnweiss
ext/styles/KoStyleManager.cpp 480fa19 plugins/textshape/dialogs/StylesModel.cpp 0e33084 Diff: http://git.reviewboard.kde.org/r/108051/diff/ Testing --- Thanks, Pierre Stirnweiss ___ calligra-devel mailing list calligra-devel@kde.org https://ma

Re: Review Request: spellchecking changes

2012-12-31 Thread Pierre Stirnweiss
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108022/#review24325 --- Ship it! Ship It! - Pierre Stirnweiss On Dec. 31, 2012, 12

Review Request: Fix sorting of style names

2012-12-30 Thread Pierre Stirnweiss
natural order now. I could not test regressions where locale comparison would play a role however. But since KStringHandler's comparison uses the Qt one, I don't expect a regression there. Thanks, Pierre Stirnweiss ___ calligra-devel mailing lis

Review Request: Fix apply characterStyle to a caret without selection

2012-12-23 Thread Pierre Stirnweiss
cursor does not have a selection, the character style was not applied. Ok to backport? Diffs - libs/kotext/KoTextEditor_format.cpp d1f0694 Diff: http://git.reviewboard.kde.org/r/107878/diff/ Testing --- Thanks, Pierre Stirnweiss

Review Request: Fix clicking in selection does not update caret

2012-12-22 Thread Pierre Stirnweiss
http://git.reviewboard.kde.org/r/107849/diff/ Testing --- Now it works for me ;) Thanks, Pierre Stirnweiss ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: a new library

2012-12-19 Thread Pierre Stirnweiss
On Wed, Dec 19, 2012 at 1:19 PM, C. Boemann wrote: > On Wednesday 19 December 2012 13:11:51 Jaroslaw Staniek wrote: > > On 19 December 2012 12:59, C. Boemann wrote: > > > Yes i'm not attached to alpine in any way. I couldn't come up with a > > > generic name that describes the library very well

Re: a new library

2012-12-19 Thread Pierre Stirnweiss
On Wed, Dec 19, 2012 at 10:03 AM, Boudewijn Rempt wrote: > ** > > On Wednesday 19 December 2012 Dec, C. Boemann wrote: > > > Hi > > > > > > In an attempt to to rework the ui, we have run into a problem: > > > > > > KoCreatePathTool in libs/flake needs some widgets from libs/widgets > > > > > > ho

Review Request: Fix applying paragraphStyle

2012-12-06 Thread Pierre Stirnweiss
Diff: http://git.reviewboard.kde.org/r/107616/diff/ Testing --- Thanks, Pierre Stirnweiss ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Review Request: Fix next style appears as modified after new line on header style (bug 293378).

2012-12-01 Thread Pierre Stirnweiss
to work, and I have not spotted regressions. Thanks, Pierre Stirnweiss ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: Make it possible to override info from author profile via dbus/c++

2012-11-28 Thread Pierre Stirnweiss
<http://git.reviewboard.kde.org/r/107486/#comment17365> What is the difference between ActiveAuthorInfo and AuthorInfo? Perhaps a tad more verbose description. - Pierre Stirnweiss On Nov. 27, 2012, 12:14 p.m., C. Boemann

Re: Review Request: Sort styles according to usage in the docker's combos

2012-11-27 Thread Pierre Stirnweiss
the affair. There are a couple of glitches in handling styles, but these are also present in the current build. Thanks, Pierre Stirnweiss ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: Sort styles according to usage in the docker's combos

2012-11-27 Thread Pierre Stirnweiss
--- Playing around with it did not show regressions with current state of the affair. There are a couple of glitches in handling styles, but these are also present in the current build. Thanks, Pierre Stirnweiss ___ calligra-devel mailing list calligra

Re: Review Request: Sort styles according to usage in the docker's combos

2012-11-27 Thread Pierre Stirnweiss
-- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107445/#review22611 --- On Nov. 26, 2012, 9:27 p.m., Pierre Stirnweiss wrote: > > --

Re: Review Request: Sort styles according to usage in the docker's combos

2012-11-26 Thread Pierre Stirnweiss
--- Playing around with it did not show regressions with current state of the affair. There are a couple of glitches in handling styles, but these are also present in the current build. Thanks, Pierre Stirnweiss ___ calligra-devel mailing list calligra

Re: Review Request: Sort styles according to usage in the docker's combos

2012-11-26 Thread Pierre Stirnweiss
/#review22533 ------- On Nov. 24, 2012, 2:36 p.m., Pierre Stirnweiss wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde

Review Request: Sort styles according to usage in the docker's combos

2012-11-24 Thread Pierre Stirnweiss
glitches in handling styles, but these are also present in the current build. Thanks, Pierre Stirnweiss ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: Introduce KoTextRange instead of inline characters

2012-10-25 Thread Pierre Stirnweiss
On Thu, Oct 25, 2012 at 9:39 AM, Inge Wallin wrote: >This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106983/ > > Ship it! > > Looks good now. > > Only thing was that copyright notice is still missing in some files and some > files still have cod

Re: Distraction free writing mode

2012-09-10 Thread Pierre Stirnweiss
> > > > There is perhaps a way, that i started to explore for change tracking > > without much success (but i didn't pursue this very long). It seems > > possible to specify additional formatting at layout stage (QTextLayout > > class I think). I don't know how usable this is. Camilla should know m

Re: Distraction free writing mode

2012-09-07 Thread Pierre Stirnweiss
Time to involve the whole devel list I think: Here is roughly where we stand in a discussion (between Inge and me, with some public) about distraction free mode. I think it is becoming concrete enough and will be of interest for others in the ML. Pierre On Fri, Sep 7, 2012 at 10:16 AM, Inge Wal

Re: Review Request: fix writing of text:time values

2012-07-07 Thread Pierre Stirnweiss
> On July 7, 2012, 4:50 p.m., Pierre Stirnweiss wrote: > > plugins/variables/DateVariable.cpp, line 126 > > <http://git.reviewboard.kde.org/r/105463/diff/3/?file=71690#file71690line126> > > > > Won't this create a round-trip problem? > > The

Re: Review Request: fix writing of text:time values

2012-07-07 Thread Pierre Stirnweiss
ttp://git.reviewboard.kde.org/r/105463/#comment12140> Won't this create a round-trip problem? The loaded file haven't got a date. On saving it will have currentDate, or have I missed something? - Pierre Stirnweiss On July 7, 2012, 10:16 a.m., Friedrich W. H

Re: Preview of white font on... white background... what to do?

2012-06-04 Thread Pierre Stirnweiss
On Mon, Jun 4, 2012 at 2:30 PM, C. Boemann wrote: > On Monday 04 June 2012 14:21:07 Friedrich W. H. Kossebau wrote: > > Hi, > > > > a problem with the otherwise great text style previews in the style > > selectors is that they fail if the color of the style is the same as the > > background in th

Re: Review Request: renaming style and add new style

2012-05-23 Thread Pierre Stirnweiss
Something like AddUnvalidatedStyle or AddDraftStyle. I'll post some more if I think of anything else On Wed, May 23, 2012 at 3:46 PM, C. Boemann wrote: > On Wednesday 23 May 2012 15:41:43 Pierre Stirnweiss wrote: > > And since this list uses the styleModel, I see the use case now

Re: Review Request: renaming style and add new style

2012-05-23 Thread Pierre Stirnweiss
less generic name and friend the appropriate classes? On Wed, May 23, 2012 at 3:28 PM, C. Boemann wrote: > On Wednesday 23 May 2012 15:25:26 Pierre Stirnweiss wrote: > > But is this to be used only in the styleManager dialog then? What for, > the > > preview? > Yes for the

Re: Review Request: renaming style and add new style

2012-05-23 Thread Pierre Stirnweiss
But is this to be used only in the styleManager dialog then? What for, the preview? On Wed, May 23, 2012 at 2:52 PM, C. Boemann wrote: > On Wednesday 23 May 2012 14:42:52 Pierre Stirnweiss wrote: > > I am not now in a position to do a proper review for the moment. However > a &

Re: Review Request: renaming style and add new style

2012-05-23 Thread Pierre Stirnweiss
I am not now in a position to do a proper review for the moment. However a couple of questions: - what is it you are trying to do with these "other" paragraph styles? - why inserting them is not done through the kotext's styleManager like the "standard" paragraph styles and directly into the model

Re: Review Request: Fix wrongly always present dot behind bullet in preview of the Paragraph dialog

2012-03-26 Thread Pierre Stirnweiss
done here is to replace the whole preview with a thumbnail created by the KoStyleThumbnailer (in the textlayout lib). That way, the preview is really using the same layout/drawing stuff as the shapes. Now it is all done specific to this preview. - Pierre Stirnweiss On March 26, 2012, 6:52 a.m

Re: Dedicating Krita 2.4 to Moebius

2012-03-13 Thread Pierre Stirnweiss
Being a real fan of the "Bande désinée" and an admirer of Moebius' art, I wholeheartedly support this. PierreSt On Tue, Mar 13, 2012 at 11:30 AM, Boudewijn Rempt wrote: > Hi, > > I would like to add the attached patch to the 2.4 release. It dedicates > this release of Krita to the memory of Je

Re: release plan and request for merge

2012-02-23 Thread Pierre Stirnweiss
When I checked out the branch yesterday evening, the KoTextEditor_format.cpp file was missing. This also meant that I couldn't test the trick for the insertTable method. It wouldn't compile. Pierre On Thu, Feb 23, 2012 at 10:27 AM, C. Boemann wrote: > Hi all > > So the minisprint on undo in Wor

mapShape/mapTool causing a crash

2012-01-16 Thread Pierre Stirnweiss
Hello, I have a crash on startup because of the mapShape it seems (see backtrace below). I actually have disabled the comiplation of both maps and mapshape. Untill yesterday, everything was fine. However now i get a crash on startup in words. PierreSt Application: Words (calligrawords), signal:

Re: Setting a final release schedule

2012-01-16 Thread Pierre Stirnweiss
Oh, you've merged the branch already? Arf, I was looking forward doing this myself, sort of a good conclusion to a long time spent. Well,... I've seen also that you changed the textTool to use a blank character style as a base of the newly created style (if there isn't a base character style). Isn

Re: Review Request: Replace the current half baked style selection widgets with a home brewed comboBox

2012-01-16 Thread Pierre Stirnweiss
the branch compiles and run without major problems. I think a complete merge is the safest thing to do. - Pierre ------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103677/#review9852 --

Re: Review Request: Replace the current half baked style selection widgets with a home brewed comboBox

2012-01-16 Thread Pierre Stirnweiss
> On Jan. 15, 2012, 8:17 p.m., C. Boemann wrote: > > plugins/textshape/dialogs/SimpleCharacterWidget.cpp, line 131 > > <http://git.reviewboard.kde.org/r/103677/diff/4/?file=46799#file46799line131> > > > > = block.charformat > > > > Pierre Stir

Re: Review Request: Replace the current half baked style selection widgets with a home brewed comboBox

2012-01-15 Thread Pierre Stirnweiss
- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103677/#review9842 --- On Jan. 15, 2012, 7:41 p.m., Pierre Stirnweiss wrote: > >

Re: Review Request: Replace the current half baked style selection widgets with a home brewed comboBox

2012-01-15 Thread Pierre Stirnweiss
sively linked to the comboBox seems to be working properly. Some defects have been identified (like no paragraph style is selected at startup), but these are actually outside the scope of this widget and affecting the current widget also. Thanks

Re: Review Request: Replace the current half baked style selection widgets with a home brewed comboBox

2012-01-15 Thread Pierre Stirnweiss
> On Jan. 12, 2012, 8:01 a.m., Thorsten Zachmann wrote: > > plugins/textshape/TextTool.cpp, lines 1803-1810 > > <http://git.reviewboard.kde.org/r/103677/diff/1/?file=46464#file46464line1803> > > > > How about intializing charStyle with style? > > Pie

Re: Review Request: Replace the current half baked style selection widgets with a home brewed comboBox

2012-01-15 Thread Pierre Stirnweiss
ted at startup), but these are actually outside the scope of this widget and affecting the current widget also. Thanks, Pierre Stirnweiss ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: Replace the current half baked style selection widgets with a home brewed comboBox

2012-01-15 Thread Pierre Stirnweiss
7/diff/diff > > > Testing > --- > > The functionality exclusively linked to the comboBox seems to be working > properly. Some defects have been identified (like no paragraph style is > selected at startup), but these are actually outside the scope of this widget > and affecting the current widget also. > > > Thanks, > > Pierre Stirnweiss > > ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: Replace the current half baked style selection widgets with a home brewed comboBox

2012-01-15 Thread Pierre Stirnweiss
current widget also. Thanks, Pierre Stirnweiss ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: Replace the current half baked style selection widgets with a home brewed comboBox

2012-01-14 Thread Pierre Stirnweiss
27;t find this discrepancy logical. - Pierre --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103677/#review9762 ------- On Jan

Review Request: Replace the current half baked style selection widgets with a home brewed comboBox

2012-01-11 Thread Pierre Stirnweiss
t these are actually outside the scope of this widget and affecting the current widget also. Thanks, Pierre Stirnweiss ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: text:id is deprecated

2012-01-05 Thread Pierre Stirnweiss
You either call KoTextEditor->beginEditBlock before doing all the operations (ie, before deleting the shape and the anchor), and call textEditor->endEditBlock(), or alternatively you create a KUndo2Command and call KoTextEditor->addCommand(yourCommand). I think the second method is better as it all

Re: Working on deleting anchored objects in Words

2012-01-04 Thread Pierre Stirnweiss
Indeed, the change tracking system needs to know about it. And secondly, if you remove a character from the QTextDocument, Qt will create an undo/redo command internally. If you do not have a corresponding command on your application undoStack, you'll be out of sync with QTextDocument internal und

Re: Marketing Message for Calligra

2011-12-23 Thread Pierre Stirnweiss
On Fri, Dec 23, 2011 at 12:32 PM, Inge Wallin wrote: > On Thursday, December 22, 2011 20:18:48 Cyrille Berger Skott wrote: > > On Thursday 22 December 2011, Inge Wallin wrote: > > > On Thursday, December 22, 2011 17:47:54 Cyrille Berger Skott wrote: > > > > You can make all the fun you want of Li

Re: Marketing Message for Calligra

2011-12-22 Thread Pierre Stirnweiss
wrote: > On Thursday 22 December 2011, Pierre Stirnweiss wrote: > > Also, the web site says beta 5 as title, whereas the text underneath > speaks > > about the fourth beta being released and a fifth one eventually coming. > Did > > I miss something? > I did miss it

Re: Marketing Message for Calligra

2011-12-22 Thread Pierre Stirnweiss
Perhaps something like: Calligra Suite applications are built on a very flexible yet powerful engine. This allows Calligra Suite applications to be developed specifically for very broad range of devices, in particular to mobile appliances, as opposed to being merely tweaked and squeezed to fit an

Re: Marketing Message for Calligra

2011-12-22 Thread Pierre Stirnweiss
22, 2011 at 11:30 AM, Jaroslaw Staniek wrote: > On 22 December 2011 11:13, Pierre Stirnweiss > wrote: > > I have to say I agree with Cyrille here. It always made me laugh when i > was > > in purchasing, to see our supplier's commercial guy starting his speech > w

Re: Marketing Message for Calligra

2011-12-22 Thread Pierre Stirnweiss
I have to say I agree with Cyrille here. It always made me laugh when i was in purchasing, to see our supplier's commercial guy starting his speech with "we are leader in our market". To which I always answered by asking to define me precisely what their market was (because their competitor, which

Re: Help regarding project

2011-12-19 Thread Pierre Stirnweiss
I'd like to point to this thread regarding kde on windows and poppler (by the way is there a way in Googlemail to refer to a thread without copy/paste it?): From: *Pierre Stirnweiss* Date: Sun, Mar 20, 2011 at 9:26 AM To: Calligra Suite developers and users mailing list Just something to

Re: Review Request: Show recent news in the startup screen

2011-12-10 Thread Pierre Stirnweiss
the left pane? It looks like it is part of the "custom document" options. Maybe have the pane take the whole width of the dialog? PierreSt - Pierre Stirnweiss On Dec. 10, 2011, 10:33 a.m., Boudewijn Rempt wrote: > >

Re: results from

2011-11-21 Thread Pierre Stirnweiss
urther the possibility of reusing the name. PierreSt On Mon, Nov 21, 2011 at 3:05 PM, C. Boemann wrote: > On Monday 21 November 2011 14:58:18 you wrote: > > On 11/21/2011 02:03 PM, C. Boemann wrote: > > > On Monday 21 November 2011 13:50:38 Pierre Stirnweiss wrote: > > >&

Re: results from

2011-11-21 Thread Pierre Stirnweiss
> > 1. Abacus (Condorcet winner: wins contests with all other choices) > > Even if it won the competition it is a bad choice as there is already a > spreadsheet application out there with this name. See > http://www.freebsdsoftware.org/deskutils/abacus.html > > If there is already a spreadsheet ap

Re: Calligra Words mission statement and roadmap (1st draft)

2011-11-14 Thread Pierre Stirnweiss
> > Background: I indeed think that is a rather important feature > cause it's the only way to get content into a document that > can be in a centralized way edited/updated. Means you for > example a document describing the features of Calligra as > released and then add a user-variable field for t

Re: Review Request: Partly fixed rect position returned to input method through TextTool::InputMethodQuery.

2011-11-09 Thread Pierre Stirnweiss
IIRC, the spell-checking in words was (is still?) "swallowing" repeated white spaces. I don't know if there is a relation or not. PierreSt On Wed, Nov 9, 2011 at 9:57 AM, Yue Liu wrote: >This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103091/

Brainstorming about textshape/textlayout/kotext structure

2011-11-07 Thread Pierre Stirnweiss
At the sprint, I'll be animating a brainstorming session about the structure of the text handling in calligra. This is about the structure we want to have for the current textshape/textlayout/kotext triplet. So I can organise a bit myself, and also for everyone to have a clear picture of who is int

Qt Fragment visibility

2011-10-21 Thread Pierre Stirnweiss
Hello, With Qt Project announced and Qt5 coming, I had a thought on our previously unsuccessfull go at fragment visibility. Now that BIC isn't an issue anymore and Qt is more opened to change, wouldn't it be a good time to move forward with QTextFragment visibility? That would allow a lot with the

Re: on Words

2011-10-11 Thread Pierre Stirnweiss
> > kotext, textlayout, textshape, words division of responsibilities >> --**--** >> --- >> We should come up with a plan for how we want the code structured in the >> long >> run. We've come a long way already, but we shou

Re: on Words

2011-10-07 Thread Pierre Stirnweiss
On Fri, Oct 7, 2011 at 1:39 PM, C. Boemann wrote: > Hi fellow Words developers > > The sprint is nearing and I think it's time to start thinking about what we > should do. The following is up for discussion at the sprint but I'd like to > get a head start: > > Mission statement >

Re: compile error

2011-10-03 Thread Pierre Stirnweiss
gt; > From: calligra-devel-boun...@kde.org [calligra-devel-boun...@kde.org] on > behalf of Boudewijn Rempt [b...@valdyas.org] > Sent: Monday, October 03, 2011 9:13 AM > To: Calligra Suite developers and users mailing list > Subject: Re: compile

compile error

2011-10-01 Thread Pierre Stirnweiss
Looks like there is again a export problem in ooxml filter: Linking CXX shared module ..\..\..\bin\docximport.dll Creating library ..\..\..\bin\docximport.lib and object ..\..\..\bin\docximport.exp DocxXmlDocumentReader.obj : error LNK2019: unresolved external symbol "__declspec(dllimport) pub

Re: Review Request: Move several commands from TextTool to the KoTextEditor interface

2011-09-23 Thread Pierre Stirnweiss
ight direction? > > > > On Friday 23 September 2011 09:56:00 Pierre Stirnweiss wrote: > > I thought we had planned to discuss the kotext/textlayout/textshape > > architecture at the sprint. > > > > Pierre > > > > On Thu, Sep 22, 2011 at 10:08 PM, C. Boem

Re: Review Request: Move several commands from TextTool to the KoTextEditor interface

2011-09-23 Thread Pierre Stirnweiss
I thought we had planned to discuss the kotext/textlayout/textshape architecture at the sprint. Pierre On Thu, Sep 22, 2011 at 10:08 PM, C. Boemann wrote: >This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102679/ > > In general quite nice. A f

Re: Questions about Words

2011-07-10 Thread Pierre Stirnweiss
I have tried at one point to do the same, so I may also be able to help a bit in this. In between quite a lot has changed in the text layout field, so I am not sure how actual is my recollection of the code. PierreSt On Thu, Jul 7, 2011 at 10:38 PM, Steven Kakoczky wrote: > Hi all, > I'm trying

Re: [calligra] plugins/textshape/dialogs: Don't crash if there is no style set.

2011-06-28 Thread Pierre Stirnweiss
Just for information so there is no duplication of efforts: I am hitting a number of assert linked to the style previewing. I am currently investigating them (they are linked apparently to lists in paragraph styles). PierreSt On Tue, Jun 28, 2011 at 10:05 AM, Boudewijn Rempt wrote: > On Tuesday

Re: Proposal: Promote svg support

2011-06-27 Thread Pierre Stirnweiss
On a general note, I'm pretty much a supporter of the line "we need to keep KoShape as slim as up to nearly impossible". So anything which on the one hand is not of a complete universal use and on the other hand could be implemented outside should in my opinion be left outside. PierreSt On Tue,

Re: Creating a branch

2011-06-21 Thread Pierre Stirnweiss
Have you added the folder in the calligra/filters/words CMakeList.txt file? Pierre On Tue, Jun 21, 2011 at 5:06 PM, Diego Turcios wrote: > Hi guys I am going to begin working on the pdf import/export filter. > The first think I should do its to create my branch. (I did it ) > Later I created my

Re: Using ODF Relax NG schema to generate easier XML writing classes

2011-06-09 Thread Pierre Stirnweiss
I like the idea. On the headerWriter example you give, the end-element is written when the Writer gets out of scope. We'd need to verify that all our start/end element couples are within the same scope however. Pierre On Fri, Jun 10, 2011 at 8:22 AM, Jos van den Oever < jos.van.den.oe...@kogmbh.

Re: KDE git workflow

2011-06-09 Thread Pierre Stirnweiss
On Thu, Jun 9, 2011 at 1:13 PM, Cyrille Berger wrote: > On Wed, Jun 08, 2011 at 11:01:13PM +0200, Jos van den Oever wrote: > > On Wednesday, June 08, 2011 21:18:49 PM Pierre Stirnweiss wrote: > > > Well, sounds really really familiar. They could have attended our > sprint

Re: KDE git workflow

2011-06-08 Thread Pierre Stirnweiss
On Wed, Jun 8, 2011 at 9:30 PM, Aaron J. Seigo wrote: > On Wednesday, June 8, 2011 21:18:49 Pierre Stirnweiss wrote: > > Well, sounds really really familiar. They could have attended our sprint > and > > spared the discussion time, couldn't they? ;) > > if someone ha

Re: KDE git workflow

2011-06-08 Thread Pierre Stirnweiss
Well, sounds really really familiar. They could have attended our sprint and spared the discussion time, couldn't they? ;) IIRC this very workflow was already discussed in Oslo. PierreSt On Wed, Jun 8, 2011 at 7:38 PM, Boudewijn Rempt wrote: > fyi > -- > Boudewijn Rempt | http://www.valdyas

Re: arbitration decision

2011-05-30 Thread Pierre Stirnweiss
i'd like to see it please. Pierre On Mon, May 30, 2011 at 10:01 AM, Boudewijn Rempt wrote: > Hi, > > The arbitrator has prepared a final draft of his decision. It is not yet > public. I already mailed it to a number of people who I knew were > interested. If you have not had this mail, please m

krita compile fail on windows

2011-05-24 Thread Pierre Stirnweiss
[ 47%] Building CXX object krita/ui/CMakeFiles/kritaui.dir/dialogs/kis_dlg_preferences.obj cd C:\Users\pierre\shared\Hacking\calligra_build\krita\ui C:\PROGRA~1\MICROS~1.0\VC\bin\cl.exe @C:\Users\pierre\AppData\Local\Temp\nmC757.tmp kis_dlg_preferences.cc c:\users\pierre\shared\hack

Re: Windows compilation error

2011-05-23 Thread Pierre Stirnweiss
> Marijn > > On Sunday, May 22, 2011 01:00:28 pm Pierre Stirnweiss wrote: > > While compiling on windows, i get the following error: > > > > > > [ 9%] Building CXX object > > libs/main/CMakeFiles/komain.dir/KoRecentDocumentsPane.obj > >

Windows compilation error

2011-05-22 Thread Pierre Stirnweiss
While compiling on windows, i get the following error: [ 9%] Building CXX object libs/main/CMakeFiles/komain.dir/KoRecentDocumentsPane.obj KoRecentDocumentsPane.cpp C:\Users\pierre\shared\Hacking\calligra\libs\main\KoRecentDocumentsPane.cpp(125) : error C2665: 'KIO::filePreview' : none of the 2

styles docker

2011-05-12 Thread Pierre Stirnweiss
i am trying to debug the styles docker in words. when clicked it should display a list of available styles, written with the corresponding character style. This preview is actually a pixmap generated as follow: a text document is used to apply the character style on the name of the style. This docu

Re: Calligra on windows

2011-05-11 Thread Pierre Stirnweiss
On Wed, May 11, 2011 at 5:08 PM, Gopalakrishna Bhat wrote: > Hi, > > The previous post in the mailing list made me ask this question, is > Calligra installable on Windows. > > On looking through the archive I found out that Pierre Stirnweiss was able > to get it working.

Re: test server is back, now with calligra

2011-05-11 Thread Pierre Stirnweiss
Also that the subject of test server is on again. Is a windows test setup still planned? If there is need for help, please tell me what I can do. I am still compiling the whole calligra and fixing compilation errors when I encounter any. However it is consuming a large part of my coding time. Pier

Re: The state of Calligra Words (a call for testing)

2011-05-11 Thread Pierre Stirnweiss
Well, the style selection widget is still work in progress. The reason why it is not displaying the preview is still eluding me. It was before the re-factoring of the layout, but I don't have nailed down where exactly the problem lies. I'll work more on it this evening. However, I don't know if it

Re: Text layout has landed

2011-04-28 Thread Pierre Stirnweiss
> > I'm sorry, but I actually see no other way than what I did, but I do > apologize > for not having waited longer. > > Although I think that the new text layout should be included in the snapshot, I do agree with Thorsten here that the branch should have got a better review process. Basically say

Re: The snapshot and the new text layout code.

2011-04-28 Thread Pierre Stirnweiss
I also agree. If it really is a matter of days rather than weeks. It really would be a shame to miss one of the biggest and most noticeable change in words. Not to mention missing the whole application, which would in my opinion be a big problem PR wise. Pierre On Thu, Apr 28, 2011 at 11:38 AM, E

Re: Google Summer of Code Projects

2011-04-08 Thread Pierre Stirnweiss
> > I've worked a lot with C/C++ and Java and have dabbled in Qt, but I've > done > > GUI design with Java Swing. The project that really interested me was > > Implementing notes-support because I use notes/comments a lot in other > > software that I use and think that it is a project within my exp

Re: #warning for msvc

2011-04-06 Thread Pierre Stirnweiss
This is what I have used to fix all the #warning I encountered. Didn't realise it was actually kde defined. Apparently it is defined in kdewin_export.h. On Wed, Apr 6, 2011 at 9:20 PM, Jaroslaw Staniek wrote: > Just a note, for handy WARNING macro please look at > kexi/kexidb/kexidb_global.h (#w

Re: [calligra] kplato/libs/kernel/tests: Add unit tests for kptcommand, calendar commands.

2011-03-27 Thread Pierre Stirnweiss
Actually it does not seem so, and it compiles fine here (on windows). I don't really understand what the problem is here. Pierre On Sun, Mar 27, 2011 at 6:36 PM, Cyrille Berger Skott wrote: > Hi, > > On Saturday 26 March 2011, Pierre Stirnweiss wrote:

Re: PDF-Import and/or PDF-Export

2011-03-20 Thread Pierre Stirnweiss
cf my remark on the GSOC2011 thread about libpoppler on windows MSVC. Pierre On Sun, Mar 20, 2011 at 9:06 AM, Boudewijn Rempt wrote: > On Saturday 19 March 2011 Mar, Diego Turcios wrote: > > Hi I was looking at the KDE Wiki, and I have interest in the PDF-Import > > and/or PDF-Export project.

Re: GSoC 2011

2011-03-20 Thread Pierre Stirnweiss
Just something to keep in mind: on windows MSVC, libpoppler is a static library ("because poppler does not have import/export thing for the core(private) api" dixit pinotree). Libpoppler is not meant to be used directly. For the karbon pdf filter this is however what we do. This means that: -either

Re: "Post-it" area + notes as a GSOC?

2011-02-27 Thread Pierre Stirnweiss
. Pierre On Sat, Feb 26, 2011 at 9:52 PM, Sebastian Sauer wrote: > On Saturday 26 February 2011 12:38:40 Pierre Stirnweiss wrote: > > Do you think that the following would be a good GSOC subject? > > > > - implement the "post-it" area. inspiration: > > http://wik

  1   2   >