> On Nov. 26, 2012, 9:51 p.m., C. Boemann wrote: > > plugins/textshape/CMakeLists.txt, line 37 > > <http://git.reviewboard.kde.org/r/107445/diff/2/?file=96351#file96351line37> > > > > should we remove these completely or are they also leftover?
Well, I didn't want to remove the files until all the dialog files are cleared up (StyleManager,...). > On Nov. 26, 2012, 9:51 p.m., C. Boemann wrote: > > plugins/textshape/TextTool.cpp, line 2081 > > <http://git.reviewboard.kde.org/r/107445/diff/2/?file=96352#file96352line2081> > > > > hmm why this Now, I have connected each Ko*Style applyStyle to the KoStyleManager, which emits a signal. I have not removed completely these lines, just for security. I'll revisit this later, when I am finished with the styles stuff. > On Nov. 26, 2012, 9:51 p.m., C. Boemann wrote: > > plugins/textshape/dialogs/DockerStylesComboModel.cpp, line 139 > > <http://git.reviewboard.kde.org/r/107445/diff/2/?file=96356#file96356line139> > > > > should we maybe have an enum for this rather than hardcoded value This is a consequence of the whole architecture of the StylesModel, which uses the styleId as internalId. I am not sure I understand really what you are suggesting with an enum. > On Nov. 26, 2012, 9:51 p.m., C. Boemann wrote: > > plugins/textshape/dialogs/StylesCombo.cpp, line 65 > > <http://git.reviewboard.kde.org/r/107445/diff/2/?file=96362#file96362line65> > > > > really? Yes, we use the delegate's clickedInItem signal. I had a double emission. I have not removed the lines completely for safety reasons. - Pierre ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107445/#review22611 ----------------------------------------------------------- On Nov. 26, 2012, 9:27 p.m., Pierre Stirnweiss wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107445/ > ----------------------------------------------------------- > > (Updated Nov. 26, 2012, 9:27 p.m.) > > > Review request for Calligra, Inge Wallin and C. Boemann. > > > Description > ------- > > This introduces sorting of the styles in the combos according to usage. > This is a first step into revamping the styles handling. > > > Diffs > ----- > > libs/kotext/KoTextEditor.h 64f47bb > libs/kotext/KoTextEditor_format.cpp 8985fcc > libs/kotext/styles/KoCharacterStyle.h 765f49e > libs/kotext/styles/KoCharacterStyle.cpp fcb20fd > libs/kotext/styles/KoParagraphStyle.h 7ee1787 > libs/kotext/styles/KoParagraphStyle.cpp f8bffb6 > libs/kotext/styles/KoStyleManager.h ae2e720 > libs/kotext/styles/KoStyleManager.cpp 2aa74fe > plugins/textshape/CMakeLists.txt 6253323 > plugins/textshape/TextTool.cpp 207dfd9 > plugins/textshape/dialogs/AbstractStylesModel.h PRE-CREATION > plugins/textshape/dialogs/AbstractStylesModel.cpp PRE-CREATION > plugins/textshape/dialogs/DockerStylesComboModel.h PRE-CREATION > plugins/textshape/dialogs/DockerStylesComboModel.cpp PRE-CREATION > plugins/textshape/dialogs/SimpleCharacterWidget.h d14007c > plugins/textshape/dialogs/SimpleCharacterWidget.cpp a7feb89 > plugins/textshape/dialogs/SimpleParagraphWidget.h a7d7f52 > plugins/textshape/dialogs/SimpleParagraphWidget.cpp 6fd2f67 > plugins/textshape/dialogs/StylesCombo.h 484b8fc > plugins/textshape/dialogs/StylesCombo.cpp a5e7172 > plugins/textshape/dialogs/StylesFilteredModelBase.h PRE-CREATION > plugins/textshape/dialogs/StylesFilteredModelBase.cpp PRE-CREATION > plugins/textshape/dialogs/StylesModel.h 7096d53 > plugins/textshape/dialogs/StylesModel.cpp 64767f8 > plugins/textshape/dialogs/ValidParentStylesProxyModel.h PRE-CREATION > plugins/textshape/dialogs/ValidParentStylesProxyModel.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/107445/diff/ > > > Testing > ------- > > Playing around with it did not show regressions with current state of the > affair. There are a couple of glitches in handling styles, but these are also > present in the current build. > > > Thanks, > > Pierre Stirnweiss > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
