Re: Re: [Maniphest] [Commented On] T665: Show default (empty) document on startup in document-based Calligra apps

2016-01-18 Thread C. Boemann
On Monday 18 January 2016 11:28:17 René J.V. Bertin wrote: > On Monday January 18 2016 10:05:32 boemann wrote: > >One thing tohugh - it shouldn't be an empty document - I wan to get away > >from this as we need all sorts ofinitial setup, and i want to remove the > >custom dialog for the same reaso

Re: Re: ChangeListLevelCommand bug?

2015-11-19 Thread C. Boemann
On Sunday 04 October 2015 14:59:21 David Faure wrote: > On Sunday 04 October 2015 14:52:54 Camilla Boemann wrote: > > Could look like that yes - unfortunately the guy who were most into this > > have not been active for over a year so i think the best way to know for > > sure is to debug it - all i

Re: Many questions for Stage

2015-10-02 Thread C. Boemann
On Friday 02 October 2015 09:54:59 David Faure wrote: > Here are some questions to ensure I won't change behavior that was there on > purpose, or that I didn't miss something obvious: > > * Shape animations: Move up / Move down doesn't move the setting "start on > mouse click / start after previou

Re: [calligracommon] [Bug 346421] Calligra 2.9.2 build fails (fwd)

2015-09-09 Thread C. Boemann
It's in debian testing so okay with me On Tuesday 08 September 2015 10:08:57 Boudewijn Rempt wrote: > Is it okay to update to libwps 0.4? Or should we stay with 0.3 for now, > or would it make sense to check the version and make the code conditional? > > This is the patch they're talking about i

Re: Re: Big reformat of sources before unfreeze of master (was: Re: Schedule to switch back to master for feature development)

2015-09-01 Thread C. Boemann
On Monday 31 August 2015 11:24:48 Friedrich W. H. Kossebau wrote: > Am Freitag, 28. August 2015, 19:18:18 schrieb Friedrich W. H. Kossebau: > > Am Freitag, 28. August 2015, 15:48:39 schrieb Boudewijn Rempt: > > > On Thu, 27 Aug 2015, Friedrich W. H. Kossebau wrote: > > > > * after that: > > > > 2.

Re: Let's use 3.0 only for next real release (was: Re: After 2.9.7)

2015-08-27 Thread C. Boemann
+ 1 On Thursday 27 August 2015 14:22:19 Friedrich W. H. Kossebau wrote: > Hi, > > Am Donnerstag, 27. August 2015, 09:57:32 schrieb Boudewijn Rempt: > > I think that the frameworks branch is now ready to be called 3.0. It's > > obviously not ready to release to end users, but we should make it the

Re: Re: Re: [calligra/calligra/2.9] libs/flake: Update tooltips to include keyboard shortcut.

2015-08-19 Thread C. Boemann
On Wednesday 19 August 2015 20:19:10 Boudewijn Rempt wrote: > On Wed, 19 Aug 2015, C. Boemann wrote: > > Yeah well it is used as a label in words, stage, sheets and flow, so > > adding > > extra text makes it spill over and possibly even becoming unreadable > > (de

Re: Re: [calligra/calligra/2.9] libs/flake: Update tooltips to include keyboard shortcut.

2015-08-19 Thread C. Boemann
sers have been asking for since > 2006 or so, asking for an immediate revert without explaining what the > problem is goes way too far. > > On Wed, 19 Aug 2015, C. Boemann wrote: > > please revert or make it conditional for krita only ASAP > > > > And in the future ple

Re: Increasing Calligra minimum CMake version required

2015-08-16 Thread C. Boemann
On Sunday 16 August 2015 16:30:31 Stefano Bonicatti wrote: > Hello, would it be a big issue to increase the minimum CMake version > required from 2.8.0 to at least 2.8.12 or even 3.0? > We have a little issue in Krita where using > add_definitions(${KDE4_ENABLE_EXCEPTIONS}) gives an error when comp

Re: Calligra Icons

2015-07-27 Thread C. Boemann
On Monday 27 July 2015 00:51:55 Ken Vermette wrote: > 'Ello Calligra devs; > > This is Ken Vermette from the VDG. > > We're working to better round out application icons for the upcoming 5.4 > release, and we've produced two sets of icons for Calligra applications. > One set is "libre-like" in be

Re: Re: Proposal: standardized (subdir) names for 3rdparty/generated code

2015-03-05 Thread C. Boemann
> filters/words/msword-odf/wv2 > from what I heard this can be considered a fork already. > but for now I would still treat it as 3rdparty lib, > until the further fate of this lib has been discussed > -> filters/words/msword-odf/3rdparty/wv2 it's very much a fork or rather a takeover and will rema

Re: RE: Does it ever load?

2015-03-05 Thread C. Boemann
I got the document and it loaded in 3 seconds - so don't really know what it was about On Thursday 05 March 2015 22:29:48 matus uzak wrote: > Hey, anything special about the document? Or a deadlock in the layout > engine? :) > > On Mar 4, 2015 3:04 PM, "C. Boemann&qu

Re: Re: Preview of astyle-kdelibs changes up in a branch (was: Re: [Port blocker] Re: [Kexi-devel] RFC: plan for starting the Qt5/KF5 port)

2015-03-04 Thread C. Boemann
On Thursday 05 March 2015 02:56:11 Friedrich W. H. Kossebau wrote: > Am Mittwoch, 4. März 2015, 12:42:59 schrieb Boudewijn Rempt: > > Here's a scratchpad to note problems that might have to be solved: > > > > https://docs.google.com/document/d/1jhq6oXuXKvTilJhcoS6FVKO7yYRu2yCgBS9ojh > > c2 QRU/edi

Re: Re: Preview of astyle-kdelibs changes up in a branch (was: Re: [Port blocker] Re: [Kexi-devel] RFC: plan for starting the Qt5/KF5 port)

2015-03-04 Thread C. Boemann
On Thursday 05 March 2015 02:56:11 Friedrich W. H. Kossebau wrote: > * also patched with astyle_comma.diff (not part of provided spec.diff) so what does that patch do - what should we look for ___ calligra-devel mailing list calligra-devel@kde.org https:

RE: Does it ever load?

2015-03-04 Thread C. Boemann
It probably doesn't load if it has been stuck that long - feel free to mail me the file privately if you want me to take a look and possibly fix it -Original Message- From: calligra-devel [mailto:calligra-devel-boun...@kde.org] On Behalf Of John Culleton Sent: Wednesday, March 4, 2015 13

Re: Preview of astyle-kdelibs changes up in a branch (was: Re: [Port blocker] Re: [Kexi-devel] RFC: plan for starting the Qt5/KF5 port)

2015-03-04 Thread C. Boemann
On Wednesday 04 March 2015 12:23:41 Friedrich W. H. Kossebau wrote: > Am Mittwoch, 4. März 2015, 00:10:28 schrieb Friedrich W. H. Kossebau: > > Am Dienstag, 3. März 2015, 23:37:02 schrieb Jaroslaw Staniek: > > > First let's verify if astyle-kdelibs changes only whitespace. > > > > Okay, I propose

Re: Re: RFC: plan for starting the Qt5/KF5 port

2015-02-27 Thread C. Boemann
On Friday 27 February 2015 01:21:56 Friedrich W. H. Kossebau wrote: > Am Mittwoch, 25. Februar 2015, 15:41:33 schrieb Boudewijn Rempt: > > On Wed, 25 Feb 2015, Dmitry Kazakov wrote: > > > Hi! > > > > > > My 2 cents :) > > > > > > 1) astyle > > > > > > Last time astyle was applied to Krita code (

Re: Re: Re: [Kexi-devel] RFC: plan for starting the Qt5/KF5 port

2015-02-25 Thread C. Boemann
On Wednesday 25 February 2015 10:18:19 Boudewijn Rempt wrote: > On Wed, 25 Feb 2015, C. Boemann wrote: > > On Wednesday 25 February 2015 10:01:16 Boudewijn Rempt wrote: > >> > Applying full astyle is IMHO not OK, and even against efforts of > >> > everyone who

Re: Re: [Kexi-devel] RFC: plan for starting the Qt5/KF5 port

2015-02-25 Thread C. Boemann
On Wednesday 25 February 2015 10:01:16 Boudewijn Rempt wrote: > > Applying full astyle is IMHO not OK, and even against efforts of > > everyone who keeps eye on proper coding style while doing code > > reviews. > > Sorry, our current code base is a mess. I don't care about kexi, and I > won't tou

Re: What to do with "kword" bugs at bugzilla?

2015-02-04 Thread C. Boemann
On Thursday 05 February 2015 00:08:23 Christoph Feck wrote: > Hi, > > currently there are over 100 open bugs/suggestions for kword. Does > someone from the Calligra Words team volunteer to check which of them > applies to Calligra? If not, I can close them as "unmaintained", and > ask reporters to

RE: 2.9 final release date

2015-02-03 Thread C. Boemann
+1 -Original Message- From: calligra-devel-boun...@kde.org [mailto:calligra-devel-boun...@kde.org] On Behalf Of Boudewijn Rempt Sent: Tuesday, February 3, 2015 9:57 To: calligra-devel@kde.org Subject: 2.9 final release date Hi, While there are still about 150 open bugs for Krita, my feel

Re: Re: Merge window before the port starts

2015-01-25 Thread C. Boemann
On Sunday 25 January 2015 14:26:01 Inge Wallin wrote: > So let's have a short window before the porting starts then. > Could people please reply with what stuff they would like in at that point. For my own part I have nothing. ___ calligra-devel mailing

Re: Merge window before the port starts

2015-01-25 Thread C. Boemann
On Sunday 25 January 2015 11:59:39 Inge Wallin wrote: > Hi, > > As you have probably seen I have two patches that I deem mature on the > review board right now. These are branches that have been Ok'ed and are > ready to merge. And I know that there are others with similar branches > laying around.

Re: KoPathShape saveOdf and loadOdf oddities

2015-01-17 Thread C. Boemann
On Saturday 17 January 2015 09:58:28 Stefano Bonicatti wrote: > Hello, we have a problem in Krita with drawing a polygon or a bezier curve > (or basicly anything that uses KoPathShape) in a vector layer, then > transform it so that the lines increase their thickness, then save the file > in .kra fo

Re: Re: How to deal with typo "2" instead of "2.1" for "GNU Lesser General Public" in headers?

2015-01-04 Thread C. Boemann
I'm normally really cautious about such changes but yes since 2.0 doesn't exist I'd say it's a no-brainer that it's just a typo. I for one might have made that typo many times myself so please go ahead On Sunday 04 January 2015 19:18:10 Boudewijn Rempt wrote: > On Sun, 4 Jan 2015, Friedrich W

Re: Words - how to add a way for users to change page styles ?

2014-10-19 Thread C. Boemann
On Monday 20 October 2014 00:35:47 Pierre wrote: > Hi all > > Right now, words implement most features regarding page styles in ODF, but > our user interface lacks far behind, allowing users to apply only one style > to the whole document. > This creates confusion and is a huge feature gap that re

Re: Re: How to get all characters on a page in Words and their position

2014-09-30 Thread C. Boemann
On Tuesday 30 September 2014 08:04:44 Pierre wrote: > On Monday, September 29, 2014 11:22:48 PM Friedrich W. H. Kossebau wrote: > > Hi, > > > > I would like to create a list of all characters (visible) on a given page > > and their position relativ to that page's borders. > > > > How do I do that

Re: Sad news

2014-08-26 Thread C. Boemann
On Wednesday 27 August 2014 00:04:43 Mehrdad Momeny wrote: > Hi Calligra developers, > I hope you are all fine. > > I guess some of you should know Mojtaba Shahi, He was working on some parts > of Calligra as I know. I have a really sad news for those of you, it's yet > unbelievable for myself. >

Interactive stuff on canvas. Was: spreadsheets with control thingies

2014-07-04 Thread C. Boemann
Hi This is actually a variation of an issue that has come up several times over the years Be it buttons to control videoplayback, buttons to delete a note/annotation, radiobuttons to control the content of spreadsheets. The common thing here is that the buttons are sor of part of the content,

sprint preparations on standby

2014-02-17 Thread C. Boemann
Hi I'm sorry but I don't have the time and energy to take care of organizing the sprint. Hope someone else will be able to take over. I'm really sorry Camilla ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/

Re: Review Request 114435: Turn off anti-aliasing when painting Karbon page rect / margins

2013-12-16 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114435/#review45829 --- Ship it! there are no maintainer, but the code is ok - C

Re: Review Request 114434: Consistent style for tool tooltips

2013-12-16 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114434/#review45828 --- Ship it! Ship It! - C. Boemann On Dec. 16, 2013, 8:06 a.m

Re: Calligra Sprint 2015

2013-12-14 Thread C. Boemann
On Saturday 30 November 2013 21:39:28 C. Boemann wrote: > Hi > > From our doodle poll it seems May 30th 2014 is the ideal date for our sprint > > Please add your travel costs for getting to Copenhagen > > Also: Do we maybe want to have the sprint one day longer , and i

Re: Review Request 114434: Consistent style for tool tooltips

2013-12-13 Thread C. Boemann
ry.cpp <http://git.reviewboard.kde.org/r/114434/#comment32599> maybe "Draw path" - C. Boemann On Dec. 13, 2013, 1:17 p.m., Elvis Stansvik wrote: > > --- > This is an automatically generated e-mail. To reply, visi

Re: Review Request 114243: Don't print annotations

2013-12-01 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114243/#review44960 --- Ship it! Ship It! - C. Boemann On Dec. 1, 2013, 8:40 p.m

Re: Calligra 2.8 branch and changelog (please answer :) )

2013-12-01 Thread C. Boemann
On Sunday 01 December 2013 19:16:35 Cyrille Berger Skott wrote: > Hi, > > Calligra has now been branched into "calligra/2.8", for some > exciting bug fixing times until early January ! > > Now we need to do some release work, and for this, we > require your help, especially with respect to the ch

Re: Review Request 110821: Pasting of text when text tool is not active, and of images when default tool is not active. Etc

2013-11-30 Thread C. Boemann
Diff: http://git.reviewboard.kde.org/r/110821/diff/ Testing --- Thanks, C. Boemann ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Calligra Sprint 2015

2013-11-30 Thread C. Boemann
Hi >From our doodle poll it seems May 30th 2014 is the ideal date for our sprint Please add your travel costs for getting to Copenhagen Also: Do we maybe want to have the sprint one day longer , and if so would arriving thursday or leaving monday be prefered. Not saying we should do it but it'

Re: Review Request 111914: Add support for annotations, a.k.a. notes, to Words and Author

2013-11-29 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111914/#review44846 --- uhm please hold the merge until the scrollbar is fixed - C

Re: Review Request 111914: Add support for annotations, a.k.a. notes, to Words and Author

2013-11-29 Thread C. Boemann
discussed on irc you may squash-merge - C. Boemann On Nov. 29, 2013, 8:56 p.m., Inge Wallin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: Review Request 110821: Pasting of text when text tool is not active, and of images when default tool is not active. Etc

2013-11-19 Thread C. Boemann
b299234 Diff: http://git.reviewboard.kde.org/r/110821/diff/ Testing --- Thanks, C. Boemann ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 110821: Pasting of text when text tool is not active, and of images when default tool is not active. Etc

2013-11-19 Thread C. Boemann
xec() () from > > /usr/lib64/libQtCore.so.4 > > #36 0x7f1674309afa in kdemain (argc=, argv= > out>) at /home/boud/kde/src/calligra/krita/main.cc:99 > > #37 0x7f166b4c0a15 in __libc_start_main () from /lib64/libc.so.6 > > #38 0x0000004009e1 in

Re: Review Request 110821: Pasting of text when text tool is not active, and of images when default tool is not active. Etc

2013-11-18 Thread C. Boemann
/kotext/opendocument/KoTextSharedLoadingData.cpp d9a73e9 Diff: http://git.reviewboard.kde.org/r/110821/diff/ Testing --- Thanks, C. Boemann ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra

Calligra Spring Sprint 2014

2013-11-18 Thread C. Boemann
It's time to think about the next Calligra sprint. I've discussed a bit with Inge and Friedrich, and we are talking about Copenhagen in mid April or May. Where TIvoli (beautyful looking amusement park) is open, and the weather is nice. Naturally the point of the sprint is to discuss and hack on

Re: Review Request 113783: fix tests on provided area rect in TestDocumentLayout.cpp

2013-11-10 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113783/#review43320 --- Ship it! thanks, yes your fixes makes sense - C. Boemann

Re: Review Request 113261: Port KoRdfFoaF & KoRdfCalendarEvent to Akonadi

2013-11-03 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113261/#review42910 --- Ship it! weee, great job - let's get it in - C. Boemann

Re: Review Request 113588: Create plugin system for semantic items, turn before hardcoded contact, event & location items into plugins

2013-11-03 Thread C. Boemann
http://git.reviewboard.kde.org/r/113588/#comment31013> spaces - C. Boemann On Nov. 3, 2013, 6:29 p.m., Friedrich W. H. Kossebau wrote: > > --- > This is an automatically generated e-mail. To repl

Re: Review Request 111545: Port komain away from KParts

2013-10-20 Thread C. Boemann
ing in the qt5 branch fo quite a while (where it has been merged in for more than a month), and - C. Boemann On Oct. 18, 2013, 10:17 a.m., Boudewijn Rempt wrote: > > --- > This is an automatically generated e-mail. To r

Re: Review Request 109907: Use platform native file dialogs

2013-09-24 Thread C. Boemann
ow.cpp <http://git.reviewboard.kde.org/r/109907/#comment29963> seems to be one of the features that we loose, but is it really not possible to recreate the effect? - C. Boemann On Sept. 23, 2013, 3:01 a.m., Yue Liu wrote: > >

Re: Review Request 112573: fix support for thumbnailer & Co.

2013-09-07 Thread C. Boemann
onflict in our huge branches that points towards the future. - C. Boemann On Sept. 7, 2013, 12:59 a.m., Friedrich W. H. Kossebau wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.review

Re: Review Request 112131: Make it possible for tools to report that they can work with more than one shape

2013-09-04 Thread C. Boemann
is for the activationId of toolfactories to be a comma seperated list of shape ids Diffs - libs/flake/KoToolManager.cpp 6134099 Diff: http://git.reviewboard.kde.org/r/112131/diff/ Testing --- i've tested it in the annotation branch where it works flawlessly Thanks, C. Bo

Re: Review Request 111914: Add support for annotations, a.k.a. notes, to Words and Author

2013-08-29 Thread C. Boemann
ttp://git.reviewboard.kde.org/r/111914/#comment28723> fixed - C. Boemann On Aug. 24, 2013, 5:38 a.m., Inge Wallin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboar

Re: Review Request 112131: Make it possible for tools to report that they can work with more than one shape

2013-08-28 Thread C. Boemann
> On Aug. 28, 2013, 7:17 a.m., C. Boemann wrote: > > could someone please review > > Boudewijn Rempt wrote: > did you also test with krita? this is a scary part of calligra... I did, and I furthermore don't see how it could be affected - it's actually a rather

Re: Review Request 111747: stage uses modebox, modebox capable of horizontal mode, various fixes

2013-08-28 Thread C. Boemann
stage/part/KPrView.cpp 6ec2402 stage/part/dockers/KPrPageLayoutDocker.h ed7a547 stage/part/dockers/KPrPageLayoutDocker.cpp 8348e2c Diff: http://git.reviewboard.kde.org/r/111747/diff/ Testing --- just working with it, and fixing the reviews from the earlier review Thanks, C. Boemann

Re: Review Request 112131: Make it possible for tools to report that they can work with more than one shape

2013-08-28 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112131/#review38774 --- could someone please review - C. Boemann On Aug. 17, 2013

Re: Review Request 111747: stage uses modebox, modebox capable of horizontal mode, various fixes

2013-08-28 Thread C. Boemann
the earlier review Thanks, C. Boemann ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 111747: stage uses modebox, modebox capable of horizontal mode, various fixes

2013-08-20 Thread C. Boemann
---------- On July 30, 2013, 2:48 p.m., C. Boemann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111747/ > ---

Review Request 112131: Make it possible for tools to report that they can work with more than one shape

2013-08-17 Thread C. Boemann
- libs/flake/KoToolManager.cpp 6134099 Diff: http://git.reviewboard.kde.org/r/112131/diff/ Testing --- i've tested it in the annotation branch where it works flawlessly Thanks, C. Boemann ___ calligra-devel mailing list calligra-

Re: Review Request 111960: Patch to support single layered grayscale photoshop documents

2013-08-11 Thread C. Boemann
making an extra review over - C. Boemann On Aug. 11, 2013, 5:22 a.m., Siddharth Sharma wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: Review Request 111990: make calligra plugins kxmlguiclient instead of kpart

2013-08-11 Thread C. Boemann
> On Aug. 11, 2013, 4 a.m., Friedrich W. H. Kossebau wrote: > > braindump/plugins/quickstates/BraindumpQuickStatesPlugin.h, line 25 > > > > > > What about adding a class CalligraPlugin : public QObject, public > >

Re: Review Request 111990: make calligra plugins kxmlguiclient instead of kpart

2013-08-11 Thread C. Boemann
code - C. Boemann On Aug. 10, 2013, 1:36 p.m., Boudewijn Rempt wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: Review Request 111960: Patch to support single layered grayscale photoshop documents

2013-08-09 Thread C. Boemann
glitches krita/plugins/formats/psd/psd_image_data.cpp <http://git.reviewboard.kde.org/r/111960/#comment27670> coding style krita/plugins/formats/psd/psd_image_data.cpp <http://git.reviewboard.kde.org/r/111960/#comment27671> coding style - C. Boemann On Aug. 9, 201

Re: Review Request 111914: Add support for annotations, a.k.a. notes, to Words and Author

2013-08-06 Thread C. Boemann
<http://git.reviewboard.kde.org/r/111914/#comment27547> yes probably to the annotationlayoutmanager words/part/KWDocument.cpp <http://git.reviewboard.kde.org/r/111914/#comment27548> again a constant - C. Boemann On Aug. 6, 2013, 4:59 p.m., Inge Wallin wrote: > >

Re: Review Request 111747: stage uses modebox, modebox capable of horizontal mode, various fixes

2013-07-30 Thread C. Boemann
/frames/KWFrameLayout.cpp d778e1e Diff: http://git.reviewboard.kde.org/r/111747/diff/ Testing --- just working with it, and fixing the reviews from the earlier review Thanks, C. Boemann ___ calligra-devel mailing list calligra-devel@kde.org

Re: Review Request 111747: stage uses modebox, modebox capable of horizontal mode, various fixes

2013-07-30 Thread C. Boemann
/KPrPageLayoutDocker.h ed7a547 stage/part/dockers/KPrPageLayoutDocker.cpp 8348e2c words/part/frames/KWFrameLayout.cpp d778e1e Diff: http://git.reviewboard.kde.org/r/111747/diff/ Testing --- just working with it, and fixing the reviews from the earlier review Thanks, C. Boemann

Re: Review Request 111044: Implement borders for shapes

2013-07-30 Thread C. Boemann
> On July 29, 2013, 2:06 p.m., C. Boemann wrote: > > The patch makes visual changes to more than 1000 files, but most are small > > offset problems, due to us adding 0.0 when there is no border. This can't > > be helped and is irrelevant anyway. > > > &g

Re: Review Request 111044: Implement borders for shapes

2013-07-30 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111044/#review36813 --- Ship it! Ship It! - C. Boemann On July 19, 2013, 6:26 a.m

Re: Calligra 3.0 for Qt 5.1?

2013-07-30 Thread C. Boemann
The choice is rather clear to me. Jolla is sponsoring a substantial porting effort - just for them or for us as well - do we really want to let that disappear into just an experiment - it will take us years to port at another time if done as a community effort. yes we would want to have kf5 tec

Re: Review Request 111044: Implement borders for shapes

2013-07-29 Thread C. Boemann
> On July 29, 2013, 2:06 p.m., C. Boemann wrote: > > The patch makes visual changes to more than 1000 files, but most are small > > offset problems, due to us adding 0.0 when there is no border. This can't > > be helped and is irrelevant anyway. > > > &g

Re: Review Request 111044: Implement borders for shapes

2013-07-29 Thread C. Boemann
t be there www.businesslink.gov.uk%2FEmploying_People_files%2FForm_FWE_%30712%306_new.doc - same issue www.e-assess.co.uk%2Fabout_assessment_tomororw_and_its_directors.doc - same issue and a few more - C. Boemann On July 19, 2013, 6:26 a.m., Inge Wa

Re: Calligra 3.0 for Qt 5.1?

2013-07-29 Thread C. Boemann
On Monday 29 July 2013 12:11:25 Boudewijn Rempt wrote: > I want to propose that we start porting Calligra to Qt 5.1 now that 2.7 is > released. Jolla is funding KO GmbH to work on porting the core, so this is > a good moment to get started. On the other hand, we're in the middle of > gsoc and users

Re: Review Request 111321: Solve bug 283164: delete key doesn't delete multiple cells

2013-07-29 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111321/#review36720 --- Ship it! Ok, enough time waiting for this - C. Boemann On

Re: Review Request 109907: Use native file dialog instead of kfiledialog, kofiledialog, etc.

2013-07-29 Thread C. Boemann
. Thanks - C. Boemann On April 8, 2013, 4:18 a.m., Yue Liu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: Review Request 111615: Wrap KoShapeBackground in QSharedPointer

2013-07-29 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111615/#review36715 --- Ship it! Ship It! - C. Boemann On July 29, 2013, 8:33 a.m

Re: Review Request 111615: Wrap KoShapeBackground in QSharedPointer

2013-07-28 Thread C. Boemann
g/r/111615/#comment27042> shouldn't be in this commit right libs/flake/KoShape.cpp <http://git.reviewboard.kde.org/r/111615/#comment27043> uhm why these changes - it looks seriously wrong - C. Boemann On July 28, 2013, 9:46 a.m., Boud

Re: Review Request 111747: stage uses modebox, modebox capable of horizontal mode, various fixes

2013-07-27 Thread C. Boemann
- C. Boemann On July 27, 2013, 5:50 p.m., C. Boemann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Review Request 111747: stage uses modebox, modebox capable of horizontal mode, various fixes

2013-07-27 Thread C. Boemann
--- just working with it, and fixing the reviews from the earlier review Thanks, C. Boemann ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: HUGE regression in sheets

2013-07-25 Thread C. Boemann
I have a fix :) On Friday 19 July 2013 08:36:25 Inge Wallin wrote: > I have found a huge regression in sheets. > > I and Cyrille wanted to release 2.7.0 on monday. I have set aside time > during the weekend for the announcement and a visual changelog. > > But I have found a huge regression in s

Re: Review Request 111321: Solve bug 283164: delete key doesn't delete multiple cells

2013-06-30 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111321/#review35315 --- has my backing :) - C. Boemann On June 30, 2013, 2:55 a.m

Re: Review Request 111044: Implement borders for shapes

2013-06-29 Thread C. Boemann
visit: > http://git.reviewboard.kde.org/r/111044/ > --- > > (Updated June 22, 2013, 6:28 a.m.) > > > Review request for Calligra, C. Boemann, Boudewijn Rempt, and Thorsten > Zachmann. > > > Description > --- > > This

Re: Review Request 111305: "ko"-prefix installed, but so far namespace-less libs: msooxml, odfreader, vectorimage, textlayout

2013-06-29 Thread C. Boemann
prefix is something we have to endure with librarynames. - C. Boemann On June 29, 2013, 12:40 a.m., Friedrich W. H. Kossebau wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboa

Re: Review Request 111286: Remove useless textvariableplugin.desktop

2013-06-28 Thread C. Boemann
ed in plugins/variables Thanks for catching it - C. Boemann On June 27, 2013, 9:40 p.m., Friedrich W. H. Kossebau wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard

Re: Review Request 111031: rename all filter modules to calligra_filter_formatx2formaty (instead of current namespaceless names)

2013-06-25 Thread C. Boemann
scan - looks simple enought - C. Boemann On June 18, 2013, 10:32 p.m., Friedrich W. H. Kossebau wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard

Re: Review Request 110821: Pasting of text when text tool is not active, and of images when default tool is not active. Etc

2013-06-23 Thread C. Boemann
y generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110821/#review34895 ------- On June 3, 2013, 6:05 p.m., C. Boemann wrote: > > --- > This is an autom

Re: Review Request 111147: Rename KoCanvasResourceManager::resourceChanged

2013-06-20 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/47/#review34739 --- Ship it! Ship It! - C. Boemann On June 20, 2013, 8:53 a.m

Re: Plan, Karbon: Disable the "Maintainer wanted" splashscreen for release branches?

2013-06-18 Thread C. Boemann
On Tuesday 18 June 2013 01:41:50 Elvis Stansvik wrote: > 2013/6/18 Friedrich W. H. Kossebau > > > Hi, > > > > I wonder if it is a go idea to have the "Maintainer wanted" splashscreen > > in Plan and Karbon also enabled in the 2.7 releases. People who still > > see some use in either programs sur

Re: Review Request 111031: rename all filter modules to calligra_filter_formatx2formaty (instead of current namespaceless names)

2013-06-16 Thread C. Boemann
filter can support more than one conversion? - C. Boemann On June 14, 2013, 11:08 p.m., Friedrich W. H. Kossebau wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: Review Request 111044: Implement borders for shapes

2013-06-16 Thread C. Boemann
omment25278> in particular this else should not be there but i'm not sure removing it is enough, because on one level only i belive border has precedence over border-xyz libs/odf/KoBorder.cpp <http://git.reviewboard.kde.org/r/111044/#comment25279> same about this else - C

Re: Review Request 110928: Always save the position of a shape

2013-06-15 Thread C. Boemann
> On June 10, 2013, 5:52 p.m., C. Boemann wrote: > > I still don't see the relation to the bug nor do I understand why we need > > to save 0,0 > > Inge Wallin wrote: > Ah, now I understand why everybody focusses on the bug. I was unclear in > my

Re: Review Request 110949: Renaming "Page Borders" to "Page Markers" in Calligra Sheets

2013-06-10 Thread C. Boemann
you should be able to change that by replacing in the diff file and applying the diff to a clean tree) - C. Boemann On June 11, 2013, 5:24 a.m., Jigar Raisinghani wrote: > > --- > This is an automatically generated e-mail. To r

Re: Review Request 110928: Always save the position of a shape

2013-06-10 Thread C. Boemann
stand why we need to save 0,0 - C. Boemann On June 10, 2013, 5:37 p.m., Inge Wallin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard

Re: Review Request 110928: Always save the position of a shape

2013-06-10 Thread C. Boemann
asked to (by setting the OdfPosition flag) I'm not even sure why not saving 0,0 is wrong? But the way you solve it looks wrong to me. - C. Boemann On June 10, 2013, 8:13 a.m., Inge Wallin wrote: > > --- > This is an automa

Re: Review Request 110821: Pasting of text when text tool is not active, and of images when default tool is not active. Etc

2013-06-03 Thread C. Boemann
) has the wrong position (too much to the right) pasting of url of an image (using toolproxy) is not yet implemented. Most often seen when dragging an image from a webbrowser - C. Boemann On June 3, 2013, 6:05 p.m., C. Boemann wrote

Review Request 110821: Pasting of text when text tool is not active, and of images when default tool is not active. Etc

2013-06-03 Thread C. Boemann
/110821/diff/ Testing --- Thanks, C. Boemann ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 110593: Check for null image in drop event

2013-06-03 Thread C. Boemann
to be unrelated so please commit - C. Boemann On May 22, 2013, 1:39 p.m., Elvis Stansvik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard

Re: Review Request 110723: Add tests for adding applied styles and applying added styles

2013-05-30 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110723/#review33443 --- Ship it! Ship It! - C. Boemann On May 30, 2013, 1:30 p.m

Re: Anatomy of the style manager

2013-05-30 Thread C. Boemann
On Thursday 30 May 2013 14:19:24 Pierre Stirnweiss wrote: > PierreSt, who is actually still alive good to hear :) ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 110700: Remove unused storage/API from StyleManager

2013-05-30 Thread C. Boemann
> On May 30, 2013, 6:44 a.m., C. Boemann wrote: > > it looks okay and as such is committable, but I would prefer we have the > > followup solution before actually merging to master, so please in a local > > branch where you work on the next steps. When time comes this co

Re: Review Request 110700: Remove unused storage/API from StyleManager

2013-05-29 Thread C. Boemann
o the final merge to master can be done in a clean way - C. Boemann On May 28, 2013, 8:18 p.m., Elvis Stansvik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard

Re: Review Request 110708: Add some basic unit tests for the style manager

2013-05-29 Thread C. Boemann
on this - C. Boemann On May 29, 2013, 11:04 a.m., Elvis Stansvik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

  1   2   3   4   5   6   7   8   9   10   >