> On July 29, 2013, 2:06 p.m., C. Boemann wrote: > > The patch makes visual changes to more than 1000 files, but most are small > > offset problems, due to us adding 0.0 when there is no border. This can't > > be helped and is irrelevant anyway. > > > > But I did notice that > > > > www1.mville.edu%2FAdministration%2Fstaff%2FJeff_Rosedale%2FEResinfo.doc > > - gains a border on the smaller images that shouldn't be there > > www.businesslink.gov.uk%2FEmploying_People_files%2FForm_FWE_%30712%306_new.doc > > - same issue > > www.e-assess.co.uk%2Fabout_assessment_tomororw_and_its_directors.doc - same > > issue > > and a few more
or just start words with the blank template - the text area shouldn't have a border but with this patch it does looks like some default value is wrong - C. ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111044/#review36747 ----------------------------------------------------------- On July 19, 2013, 6:26 a.m., Inge Wallin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111044/ > ----------------------------------------------------------- > > (Updated July 19, 2013, 6:26 a.m.) > > > Review request for Calligra, C. Boemann, Boudewijn Rempt, and Thorsten > Zachmann. > > > Description > ------- > > This patch implements loading, saving and painting of borders for shapes in > general. It also implements calls to actually paint borders in particular for > the picture shape and text shape. > > At the same time I moved border painting from KWCanvasBase to KoBorder, which > I announced some weeks ago that I wanted to do. > > A patch this deep in the libraries should not go in without a run of > cstester. I would be glad for help with this since I only have a semi-weak > laptop. > > > Diffs > ----- > > libs/flake/KoShape.h fe6cc3f > libs/flake/KoShape.cpp 6d14a8c > libs/flake/KoShape_p.h aa6633c > libs/odf/KoBorder.h bdbf86e > libs/odf/KoBorder.cpp 58f8e45 > libs/textlayout/FloatingAnchorStrategy.h eb0ff6b > libs/textlayout/FloatingAnchorStrategy.cpp 465f149 > libs/textlayout/KoTextDocumentLayout.cpp 70f4ccd > libs/textlayout/KoTextLayoutRootAreaProvider.h d8c7ac3 > libs/textlayout/KoTextShapeData.cpp 1b424b7 > plugins/pictureshape/PictureShape.cpp 976fadd > plugins/textshape/SimpleRootAreaProvider.h 62534a6 > plugins/textshape/SimpleRootAreaProvider.cpp 63f1898 > plugins/textshape/TextShape.cpp b230f0a > words/part/KWCanvasBase.cpp 7d12890 > words/part/KWRootAreaProvider.h 45b4870 > words/part/KWRootAreaProvider.cpp fc8660d > > Diff: http://git.reviewboard.kde.org/r/111044/diff/ > > > Testing > ------- > > Tested with all the files with the string "border" in it in the test suite. > > > Thanks, > > Inge Wallin > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
