----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111615/#review36644 -----------------------------------------------------------
cmake/modules/FindVc.cmake <http://git.reviewboard.kde.org/r/111615/#comment27042> shouldn't be in this commit right libs/flake/KoShape.cpp <http://git.reviewboard.kde.org/r/111615/#comment27043> uhm why these changes - it looks seriously wrong - C. Boemann On July 28, 2013, 9:46 a.m., Boudewijn Rempt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111615/ > ----------------------------------------------------------- > > (Updated July 28, 2013, 9:46 a.m.) > > > Review request for Calligra and Jan Hambrecht. > > > Description > ------- > > This patch wraps KoShapeBackground in a QPointer instead of doing manual > refcounting. Bug 321714 shows, imo, that the manual refcounting is fragile > and sometimes breaks. I don't remember why we weren't supposed to use > QPointer (other than that it gets a little ugly with subclassing), but it > seems a good fit here. > > There are other classes that do manual refcounting, and I think those should > be converted, too -- but in another patch. > > > This addresses bug 321714. > http://bugs.kde.org/show_bug.cgi?id=321714 > > > Diffs > ----- > > CMakeLists.txt 38c3f62 > cmake/modules/FindVc.cmake bb9823f > filters/karbon/wmf/WmfExport.cpp bf0aa85 > karbon/plugins/tools/CalligraphyTool/KarbonCalligraphicShape.cpp e9921b8 > karbon/plugins/tools/CalligraphyTool/KarbonCalligraphyTool.cpp 2517164 > karbon/plugins/tools/KarbonGradientEditStrategy.cpp 0bf30d1 > karbon/plugins/tools/KarbonGradientTool.cpp 79d4fde > karbon/plugins/tools/KarbonPatternEditStrategy.h b66b78d > karbon/plugins/tools/KarbonPatternEditStrategy.cpp 1b4e0c0 > karbon/plugins/tools/KarbonPatternTool.cpp 5c0ac36 > karbon/ui/KarbonView.cpp 7e54ede > karbon/ui/widgets/KarbonPaletteBarWidget.cpp 5898872 > karbon/ui/widgets/KarbonSmallStylePreview.cpp f6d76cf > krita/ui/flake/kis_shape_selection_model.cpp 4c59ad0 > krita/ui/opengl/kis_opengl_canvas2.cpp 1674ab4 > krita/ui/tool/kis_tool_shape.cc aab57dd > krita/ui/widgets/kis_floating_message.cpp d53e133 > libs/flake/KoConnectionShape.cpp 09af2dd > libs/flake/KoOdfWorkaround.h 5faa268 > libs/flake/KoOdfWorkaround.cpp 8a5b593 > libs/flake/KoShape.h fe6cc3f > libs/flake/KoShape.cpp 6d14a8c > libs/flake/KoShapeBackground.h 33253a8 > libs/flake/KoShapeBackground.cpp 9d6b29e > libs/flake/KoShapeBackground_p.h 92acc36 > libs/flake/KoShape_p.h aa6633c > libs/flake/commands/KoShapeBackgroundCommand.h bee749d > libs/flake/commands/KoShapeBackgroundCommand.cpp f4acd2c > libs/flake/svg/SvgParser.cpp 6898ffc > libs/flake/svg/SvgStyleWriter.h 1327e27 > libs/flake/svg/SvgStyleWriter.cpp 8be614a > libs/flake/tests/TestShapeBackgroundCommand.cpp e0b69ba > libs/kopageapp/KoPAPageBase.cpp d56c7fe > libs/kopageapp/KoPAView.cpp 58b4940 > libs/kopageapp/tools/backgroundTool/KoPABackgroundToolWidget.cpp c0c5afa > libs/widgets/KoFillConfigWidget.h 4d71718 > libs/widgets/KoFillConfigWidget.cpp d086eb7 > libs/widgets/KoResourcePopupAction.h 91031e4 > libs/widgets/KoResourcePopupAction.cpp 2d873ca > plugins/artistictextshape/ArtisticTextShapeFactory.cpp 37552b8 > plugins/chartshape/ChartShape.cpp 55d5eb8 > plugins/dockers/styledocker/StrokeFillWidget.h 212eaa0 > plugins/dockers/styledocker/StrokeFillWidget.cpp d67cabf > plugins/dockers/styledocker/StyleDocker.h 2408188 > plugins/dockers/styledocker/StyleDocker.cpp 052b2ee > plugins/dockers/styledocker/StylePreview.h db33b3f > plugins/dockers/styledocker/StylePreview.cpp 39f8b42 > plugins/pathshapes/ellipse/EllipseShapeFactory.cpp 0a4c68d > plugins/pathshapes/enhancedpath/EnhancedPathParameter.cpp 29d2ad2 > plugins/pathshapes/enhancedpath/EnhancedPathShapeFactory.cpp f1e3974 > plugins/pathshapes/rectangle/RectangleShapeFactory.cpp 689abfe > plugins/pathshapes/star/StarShapeFactory.cpp dd34c06 > plugins/textshape/TextShape.cpp b230f0a > stage/part/KPrEndOfSlideShowPage.cpp 061aa58 > words/part/KWPageStyle.h b2eeb43 > words/part/KWPageStyle.cpp f53dab5 > words/part/KWPageStyle_p.h 356af3a > words/part/frames/KWFrameLayout.cpp 6b2a31e > > Diff: http://git.reviewboard.kde.org/r/111615/diff/ > > > Testing > ------- > > > Thanks, > > Boudewijn Rempt > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
