Re: Review Request 119527: Added feature of creating report's items of specific size at adding time

2014-08-10 Thread Wojciech Kosowicz
> On July 29, 2014, 4:19 p.m., Jarosław Staniek wrote: > > libs/koreport/items/image/KoReportDesignerItemImage.cpp, line 67 > > > > > > setSceneRect() not needed here? Im not sure if I fixed it. If you find it pl

Re: Review Request 119527: Added feature of creating report's items of specific size at adding time

2014-08-10 Thread Wojciech Kosowicz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119527/ --- (Updated Aug. 10, 2014, 8:28 p.m.) Review request for Calligra, Adam Pigg

Re: Review Request 119222: Make labels inline-editable

2014-08-10 Thread Adam Pigg
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119222/ --- (Updated Aug. 10, 2014, 7:37 p.m.) Review request for Calligra and Jarosł

Re: Review Request 118643: Create an export filter for Wiki pages

2014-08-10 Thread Camilla Boemann
> On Aug. 10, 2014, 4:07 p.m., Camilla Boemann wrote: > > As long as it builds and and is marked as experimental (in the gui strings) > > I am fine with it getting merged. This is not a review though. I'll let > > someone else do that if they want to. > > Inge Wallin wrote: > It's not real

Re: Review Request 118643: Create an export filter for Wiki pages

2014-08-10 Thread Inge Wallin
> On Aug. 10, 2014, 4:07 p.m., Camilla Boemann wrote: > > As long as it builds and and is marked as experimental (in the gui strings) > > I am fine with it getting merged. This is not a review though. I'll let > > someone else do that if they want to. It's not really experimental. It's just n

Re: Review Request 118643: Create an export filter for Wiki pages

2014-08-10 Thread Camilla Boemann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118643/#review64181 --- As long as it builds and and is marked as experimental (in the

Re: Review Request 118643: Create an export filter for Wiki pages

2014-08-10 Thread Inge Wallin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118643/ --- (Updated Aug. 10, 2014, 4:02 p.m.) Review request for Calligra, Camilla B

Re: Review Request 119579: In docx import filter handle outline level of paragraphs

2014-08-10 Thread Friedrich W. H. Kossebau
> On Aug. 10, 2014, 10:18 vorm., Inge Wallin wrote: > > filters/words/docx/import/DocxXmlDocumentReader.cpp, line 3792 > > > > > > While this is correct (according to the comment, didn't read the spec), > > wou

Re: Review Request 119579: In docx import filter handle outline level of paragraphs

2014-08-10 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119579/ --- (Updated Aug. 10, 2014, 1:54 p.m.) Status -- This change has been ma

Re: Review Request 119609: Animation support in Krita

2014-08-10 Thread Sven Langkamp
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119609/#review64171 --- There are still some rough edges and some stuff that I would l

Re: Review Request 119579: In docx import filter handle outline level of paragraphs

2014-08-10 Thread Inge Wallin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119579/#review64146 --- Ship it! Looks good. I commented on a trivial readability is

Re: Review Request 119677: Show the Cursor Pos and FG Color in statusbar

2014-08-10 Thread Dmitry Kazakov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119677/#review64141 --- Hi, Latte! Your patch is really cool, but there is one issue