Re: Review Request: Add support for dr3d:scene and its children

> On June 19, 2012, 4:53 a.m., Thorsten Zachmann wrote: > > plugins/staging/threedshape/Objects.h, lines 47-48 > > > > > > Please move the implementation to the cpp file. > > Inge Wallin wrote: > This code is on

Re: Review Request: Support for path-stretchpoint-x and path-stretchpoint-y

> On May 13, 2012, 7:36 p.m., Inge Wallin wrote: > > I have a feeling that this is a case of the perfect being the enemy of the > > good. I think we should ship this patch and then open new bugs for the > > issues that you found, Zagge. > > Thorsten Zachmann wrote: > There is no hurry to

Re: Review Request: fix the "Print" services for Dolphin/Konqueror

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105363/#review15997 --- Ship it! I actually think that a change like this doesn't real

Re: Review Request: Perspective grid feature moved to Perspective Assistant

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105559/#review15995 --- Ship it! Please remove the assimp parts from the patch -- then

Re: Review Request: Save anchors that refer to internal points as anchors and not as bookmarks

> On July 16, 2012, 5:58 p.m., C. Boemann wrote: > > Not so much a regression as a change of how to click > > > > All jump-to--links are now activated with ctrl+click > > This does not work. - Thorsten --- This is an automatically gene

Re: Review Request: fixes writing of "text:index-source-style_s_" instead of "text:index-source-style"

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105541/#review15980 --- This review has been submitted with commit 2abdcd81439faec5183

Re: Review Request: fixes writing of "text:index-source-style_s_" instead of "text:index-source-style"

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105541/#review15979 --- This review has been submitted with commit fb30b5dd65e18273c00

Re: Review Request: fixes writing of "text:index-source-style_s_" instead of "text:index-source-style"

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105541/#review15978 --- Ship it! - Smit Patel On July 12, 2012, 11:44 p.m., Friedric

Re: Review Request: Save anchors that refer to internal points as anchors and not as bookmarks

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105592/#review15977 --- Not so much a regression as a change of how to click All jump-

Re: Review Request: Save anchors that refer to internal points as anchors and not as bookmarks

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105592/#review15976 --- This review has been submitted with commit a0f2309f4ac5453d78c

Re: Review Request: Save anchors that refer to internal points as anchors and not as bookmarks

> On July 16, 2012, 4:51 p.m., Thorsten Zachmann wrote: > > The patch looks good and also the saved documents are valid now. However I > > noticed that clicking on links in TOC does not jump tp the selected index. > > This seems to be a regression to 2.5. If that is not related to your patch >

Re: Review Request: Fixed ' may be used uninitialized' warnings

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105519/#review15973 --- I wonder if it would no be a better fix to add a parameter for

Re: Review Request: Save anchors that refer to internal points as anchors and not as bookmarks

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105592/#review15971 --- The patch looks good and also the saved documents are valid now

Re: Review Request: rename the app icon of Calligra sheets from kspread to sheets

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105583/#review15969 --- This review has been submitted with commit a9289bea24ab314eca8

Re: Review Request: rename the app icon of Calligra sheets from kspread to sheets

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105583/#review15968 --- This review has been submitted with commit 3f3fba30acdc9d66a89

Re: Review Request: rename the app icon of Calligra sheets from kspread to sheets

> On July 16, 2012, 11:13 a.m., Marijn Kruisselbrink wrote: > > Sorry that I missed this review request. Looks good to me, indeed please > > backport too. Why missed? Has been just a day old, so you did a quite quick review :) - Friedrich W. H. --

Review Request: Save anchors that refer to internal points as anchors and not as bookmarks

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105592/ --- Review request for Calligra. Description --- Currently we save all th

Re: Review Request: rename the app icon of Calligra sheets from kspread to sheets

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105583/#review15950 --- Ship it! Sorry that I missed this review request. Looks good t

Re: Review Request: Fix loading of embedded svg graphics.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105589/#review15947 --- Looks sane to me. I would be all for a backport too - C. Boema

Re: Review Request: Fix loading of embedded svg graphics.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105589/ --- (Updated July 16, 2012, 10:19 a.m.) Review request for Calligra and Jan Ha

Review Request: Fix loading of embedded svg graphics.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105589/ --- Review request for Calligra and Jan Hambrecht. Description --- This f