----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105541/#review15980 -----------------------------------------------------------
This review has been submitted with commit 2abdcd81439faec51832efec4292c279baf9ebed by Friedrich W. H. Kossebau to branch calligra/2.5. - Commit Hook On July 12, 2012, 11:44 p.m., Friedrich W. H. Kossebau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105541/ > ----------------------------------------------------------- > > (Updated July 12, 2012, 11:44 p.m.) > > > Review request for Calligra, C. Boemann and Smit Patel. > > > Description > ------- > > What a difference a "s" makes :) In IndexSourceStyle::saveOdf(...) at least > the singular is wanted, the plural is correctly used by > IndexSourceStyles::saveOdf(...). > > Not sure if the loading code should have a workaround to also detect > "text:index-source-styles" where just "text:index-source-style" is to be > expected? Is that generated text, so skipping the reading due to broken token > names is okay? How many documents have been generated with the bad token > names? > > Okay to backport to 2.5? > > > Diffs > ----- > > libs/kotext/ToCBibGeneratorInfo.cpp 1d65790 > > Diff: http://git.reviewboard.kde.org/r/105541/diff/ > > > Testing > ------- > > > Thanks, > > Friedrich W. H. Kossebau > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
