> On May 13, 2012, 7:36 p.m., Inge Wallin wrote: > > I have a feeling that this is a case of the perfect being the enemy of the > > good. I think we should ship this patch and then open new bugs for the > > issues that you found, Zagge. > > Thorsten Zachmann wrote: > There is no hurry to rush anything in. We have enough time to fix it > properly and then commit. Only by doing it that way we always have a > releasable master and that is what we want.
Yes... But is it a net improvement? Are more documents fixed than broken? I know that having three regressions is bad, but on the other hand, having no improvements is bad too, and this patch seems abandoned. - Boudewijn ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104804/#review13788 ----------------------------------------------------------- On May 8, 2012, 11:20 a.m., Elvis Stansvik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104804/ > ----------------------------------------------------------- > > (Updated May 8, 2012, 11:20 a.m.) > > > Review request for Calligra, Matus Hanzes, Thorsten Zachmann, and C. Boemann. > > > Description > ------- > > This patch adds support for path-stretchpoint-x and path-stretchpoint-y to > the enhanced path shape. All credit for the patch goes to Matus. I simply > found it at [1] where it seems to have been forgotten (filed against KOffice > by mistake?). > > [1] https://svn.reviewboard.kde.org/r/5978 > > > This addresses bug 258267. > http://bugs.kde.org/show_bug.cgi?id=258267 > > > Diffs > ----- > > plugins/pathshapes/enhancedpath/EnhancedPathShape.h 1919bb1 > plugins/pathshapes/enhancedpath/EnhancedPathShape.cpp dc29c3a > > Diff: http://git.reviewboard.kde.org/r/104804/diff/ > > > Testing > ------- > > I tested it with the document in bug 258267. > > > Thanks, > > Elvis Stansvik > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
