----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105559/#review15995 -----------------------------------------------------------
Ship it! Please remove the assimp parts from the patch -- then you can merge to master. Nice work! I think we should now also remove the perpspective grid, right? cmake/modules/FindAssImp.cmake <http://git.reviewboard.kde.org/r/105559/#comment12596> This doesn't belong in this diff; until we use assimp, it shouldn't go to master. krita/plugins/assistants/RulerAssistant/CMakeLists.txt <http://git.reviewboard.kde.org/r/105559/#comment12597> Ditto krita/plugins/assistants/RulerAssistant/CMakeLists.txt <http://git.reviewboard.kde.org/r/105559/#comment12598> Ditto krita/plugins/assistants/RulerAssistant/kis_ruler_assistant_tool.h <http://git.reviewboard.kde.org/r/105559/#comment12599> Nice, clear comments! krita/plugins/assistants/RulerAssistant/kis_ruler_assistant_tool.h <http://git.reviewboard.kde.org/r/105559/#comment12600> In a later refactoring, we probably should unify this list and have handle sport a property to check whether it's a corner or a side handle. That's not necessary for now. krita/plugins/assistants/RulerAssistant/kis_ruler_assistant_tool.cc <http://git.reviewboard.kde.org/r/105559/#comment12601> Spaces around the == please. krita/plugins/tools/tool_perspectivegrid/kis_tool_perspectivegrid.cc <http://git.reviewboard.kde.org/r/105559/#comment12602> Don't make this whitespace change. krita/ui/kis_painting_assistant.cc <http://git.reviewboard.kde.org/r/105559/#comment12603> I'm fairly sure we can simplify this code -- but let's do that later on. - Boudewijn Rempt On July 13, 2012, 6:10 p.m., Shivaraman Aiyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105559/ > ----------------------------------------------------------- > > (Updated July 13, 2012, 6:10 p.m.) > > > Review request for Calligra. > > > Description > ------- > > The feature of creating a new grid by pulling the side handles in the > Perspective grid which was lacking in the Perspective Assistant has been > copied into the Assistant in this commit. > > > Diffs > ----- > > cmake/modules/FindAssImp.cmake PRE-CREATION > krita/plugins/assistants/RulerAssistant/CMakeLists.txt 957fb4f > krita/plugins/assistants/RulerAssistant/kis_ruler_assistant_tool.h 12f0335 > krita/plugins/assistants/RulerAssistant/kis_ruler_assistant_tool.cc 7439511 > krita/plugins/tools/tool_perspectivegrid/kis_tool_perspectivegrid.cc > df9b75e > krita/ui/kis_painting_assistant.h 2fb513c > krita/ui/kis_painting_assistant.cc 1f619f2 > krita/ui/kis_painting_assistants_manager.cc b030aa2 > krita/ui/kra/kis_kra_saver.cpp 28d2707 > > Diff: http://git.reviewboard.kde.org/r/105559/diff/ > > > Testing > ------- > > Basic preliminary testing done include: > 1) Test if rest of the Assistants are working - done, passed > 2) Test the working of the side handles - done, passed > 3) Test if all the assistants working together - done, passed > > > Thanks, > > Shivaraman Aiyer > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
