Re: Review Request: Move core parts of KexiDB lib to libcalligradb

2012-07-06 Thread Jarosław Staniek
> On July 7, 2012, 6:11 a.m., C. Boemann wrote: > > It seems like you have forgotton to add any new files Reviewboard only let me to upload 25% of the patch. Please see the full patch file attached above... - Jarosław --- This is an au

Re: Review Request: Move core parts of KexiDB lib to libcalligradb

2012-07-06 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105464/#review15488 --- It seems like you have forgotton to add any new files CMakeLi

Re: Review Request: fix writing of text:time values

2012-07-06 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105463/#review15486 --- plugins/variables/DateVariable.h

Re: Review Request: fix writing of text:time values

2012-07-06 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105463/ --- (Updated July 7, 2012, 2:05 a.m.) Review request for Calligra and Thorsten

Re: Review Request: Move core parts of KexiDB lib to libcalligradb

2012-07-06 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105464/ --- (Updated July 7, 2012, 12:34 a.m.) Review request for Calligra, Adam Pigg,

Review Request: Move core parts of KexiDB lib to libcalligradb

2012-07-06 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105464/ --- Review request for Calligra, Adam Pigg, C. Boemann, Smit Patel, Dimitrios T

Re: Review Request: QIcon'ize KoRecentDocumentsPane, fetch big previews only on demand (save memory)

2012-07-06 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105428/#review15484 --- Ship it! Ship It! - Jarosław Staniek On July 5, 2012, 1:18

Review Request: fix writing of text:time values

2012-07-06 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105463/ --- Review request for Calligra and Thorsten Zachmann. Description --- Th

Re: Review Request: QIcon'ize KoRecentDocumentsPane, fetch big previews only on demand (save memory)

2012-07-06 Thread Friedrich W. H. Kossebau
> On July 6, 2012, 9:08 p.m., Jarosław Staniek wrote: > > libs/main/KoDetailsPane.h, line 36 > > > > > > If this is in public API used outside of the lib, I would suggest > > changing to static method (the same appl

Re: Review Request: QIcon'ize KoRecentDocumentsPane, fetch big previews only on demand (save memory)

2012-07-06 Thread Jarosław Staniek
> On July 6, 2012, 9:08 p.m., Jarosław Staniek wrote: > > libs/main/KoDetailsPane.h, line 36 > > > > > > If this is in public API used outside of the lib, I would suggest > > changing to static method (the same appl

Re: Review Request: QIcon'ize KoRecentDocumentsPane, fetch big previews only on demand (save memory)

2012-07-06 Thread Friedrich W. H. Kossebau
> On July 6, 2012, 9:08 p.m., Jarosław Staniek wrote: > > libs/main/KoDetailsPane.h, line 36 > > > > > > If this is in public API used outside of the lib, I would suggest > > changing to static method (the same appl

Re: Review Request: QIcon'ize KoRecentDocumentsPane, fetch big previews only on demand (save memory)

2012-07-06 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105428/#review15479 --- libs/main/KoDetailsPane.h

Re: Review Request: KoPageFormat: add getter for list of non-localized page sizes

2012-07-06 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105434/#review15477 --- Ship it! OK (please fix at line 168) libs/odf/KoPageFormat.c

Re: Review Request: GSoC: Stage: Shape animations docker with no editable information (yet) and shape animations preview

2012-07-06 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105213/#review15474 --- could you please close the review as dismissed The reviewboard

Re: Review Request: QIcon'ize KoRecentDocumentsPane, fetch big previews only on demand (save memory)

2012-07-06 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105428/#review15473 --- This review has been submitted with commit 4b2680796bc9b81ae38

Re: Review Request: QIcon'ize KoRecentDocumentsPane, fetch big previews only on demand (save memory)

2012-07-06 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105428/#review15471 --- This review has been submitted with commit 83e7c1bc026c03a06f8

Re: Review Request: [kofficetests-odt/odf/odt/parag-decorations.odt] fixes wrong writing of double-border style also with a non-double border

2012-07-06 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105431/#review15470 --- This review has been submitted with commit 302162a6b604cd0b5b3

Re: Review Request: [kofficetests-odt/odf/odt/parag-decorations.odt] fixes wrong writing of double-border style also with a non-double border

2012-07-06 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105431/#review15469 --- This review has been submitted with commit 4ec5156f204933980ff

Re: Review Request: Improve painting of stretched pattern background

2012-07-06 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105458/#review15468 --- This review has been submitted with commit 96dcc1ea759fb84dafe

Re: Review Request: Improve painting of stretched pattern background

2012-07-06 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105458/#review15467 --- This review has been submitted with commit f1003bd710c27bc79af

Re: Review Request: [kofficetests-odt/odf/odt/parag-decorations.odt] fixes wrong writing of double-border style also with a non-double border

2012-07-06 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105431/#review15466 --- Ship it! good work and yes please backport - C. Boemann On

Re: Review Request: [calligratests] fix table cell style code wrongly saving/loading draw:opacity with ODF

2012-07-06 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105444/#review15465 --- Hmm not sure here. Iirc someone worked on this, knowing full we

Re: Review Request: QIcon'ize KoRecentDocumentsPane, fetch big previews only on demand (save memory)

2012-07-06 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105428/#review15464 --- Ship it! I'm okay with this change, and yes let's backport too

Re: Review Request: Improve painting of stretched pattern background

2012-07-06 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105458/#review15463 --- Ship it! Nice work, and ok to backport to 2.5 too - C. Boeman

Review Request: Improve painting of stretched pattern background

2012-07-06 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105458/ --- Review request for Calligra. Description --- For page backgrounds it

Re: Fwd: Regarding GSoC

2012-07-06 Thread Jaroslaw Staniek
On 6 July 2012 11:26, Sune Vuorela wrote: > On 2012-07-06, Smit Patel wrote: >> unix/windows/symbian. [2]. I added qjson dependency in my branch. I am not >> familiar with possible packaing issues. Do we make a separate package or >> copy the source inside our source? > > Copying the source insi

Re: Fwd: Regarding GSoC

2012-07-06 Thread Sune Vuorela
On 2012-07-06, Smit Patel wrote: > unix/windows/symbian. [2]. I added qjson dependency in my branch. I am not > familiar with possible packaing issues. Do we make a separate package or > copy the source inside our source? Copying the source inside the calligra source will make the majority of di