----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105464/#review15488 -----------------------------------------------------------
It seems like you have forgotton to add any new files CMakeLists.txt <http://git.reviewboard.kde.org/r/105464/#comment12103> should probably say something more than just kexi then - C. Boemann On July 7, 2012, 12:34 a.m., Jarosław Staniek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105464/ > ----------------------------------------------------------- > > (Updated July 7, 2012, 12:34 a.m.) > > > Review request for Calligra, Adam Pigg, C. Boemann, Smit Patel, Dimitrios > Tanis, and Oleg Kukharchuk. > > > Description > ------- > > Move core parts of KexiDB lib from kexi/kexidb to calligra/libs/db > (libcalligradb) for reuse by Word's Biblio module and possibly other places > in Calligra. > > Details at http://community.kde.org/Kexi/KexiDB#libCalligraDB > > * GUI- or Kexi-related bits such as validators are still in Kexi > * Only the SQLite3 driver is moved to libcalligradb, others stay within Kexi > ** thus, calligra libs depend on the driver, i.e. depend on SQLite3 (this was > the case already for Words and Kexi) > ** calligra libs depend on ICU as well for proper unicode handling (which is > dependency of Qt 5 anyway) > * Predicate library, as a Qt-only component, will replace functionality of > the calligradb lib > * sqlitedump tool used for database for interactive database compacting stays > in Kexi; if needed could be moved to libs/ too > * a few functions from libkexiutils moved to libcalligradb, so libkexiutils > is not dependency > * for simplicity/API stability, namespace stays as KexiDB > * README.PACKAGERS file updated > > > Diffs > ----- > > CMakeLists.txt 33cdabb > README.PACKAGERS 277d0e7 > cmake/modules/FindCalligraSqlite.cmake be39e5f > kexi/CMakeLists.txt a724a34 > kexi/core/CMakeLists.txt 2b2a0bb > kexi/core/KexiMainWindowIface.h 797c2cb > kexi/core/KexiRecentProjects.cpp d3e9921 > kexi/core/KexiView.cpp fd32219 > kexi/core/KexiWindow.cpp 5b3bc11 > kexi/core/kexi.h b6eb4a3 > kexi/core/kexi.cpp 4408e8b > kexi/core/kexiblobbuffer.cpp 37ede52 > kexi/core/kexidbconnectionset.h e47eaa3 > kexi/core/kexidbshortcutfile.cpp 95c499b > kexi/core/kexiguimsghandler.h 91c6a2c > kexi/core/kexiguimsghandler.cpp c1c2b80 > kexi/core/kexiinternalpart.cpp 13a834a > kexi/core/kexipart.h ad12383 > kexi/core/kexipart.cpp 7ffe8896 > kexi/core/kexipartinfo.cpp a89cd38 > kexi/core/kexipartmanager.h 474fb31c > kexi/core/kexipartmanager.cpp 050b051 > kexi/core/kexiproject.h e9e366b > kexi/core/kexiproject.cpp 1ce37ad > kexi/core/kexiprojectconnectiondata.h a165bfe > kexi/core/kexiprojectconnectiondata.cpp 67cba7d > kexi/core/kexiprojectdata.h 49fbe74 > kexi/core/kexiprojectdata.cpp 774e2e2 > kexi/core/kexiprojectset.h 0c281dc > kexi/core/kexiprojectset.cpp 2ae1c2b > kexi/core/kexisearchandreplaceiface.h ca99062 > kexi/core/kexistartupdata.cpp 74a81e4 > kexi/core/kexitabledesignerinterface.h 5859ee6 > kexi/core/kexitemplateloader.cpp 901994c > kexi/core/kexitextmsghandler.cpp 31f1d0b > kexi/formeditor/CMakeLists.txt bd5ca24 > kexi/formeditor/WidgetInfo.h 8b66912 > kexi/formeditor/form.cpp 5746780 > kexi/formeditor/kexiformeventhandler.cpp 195a63f > kexi/kexidb/CMakeLists.txt 37ea839 > kexi/kexidb/RecordData.h 074d3ba > kexi/kexidb/RecordData.cpp 03a6ddb > kexi/kexidb/admin.h af28574 > kexi/kexidb/admin.cpp 2e9e981 > kexi/kexidb/alter.h 1d3d26e > kexi/kexidb/alter.cpp 784b93b > kexi/kexidb/common.pro 18235e2 > kexi/kexidb/connection.h e77d840 > kexi/kexidb/connection.cpp a81f4c1 > kexi/kexidb/connection_p.h b882267 > kexi/kexidb/connectiondata.h be7f472 > kexi/kexidb/connectiondata.cpp 4c75f5c > kexi/kexidb/cursor.h 0dfdb17 > kexi/kexidb/cursor.cpp d7450a3 > kexi/kexidb/cursor_p.h 16083e7 > kexi/kexidb/dbobjectnamevalidator.h fd3d763 > kexi/kexidb/dbobjectnamevalidator.cpp 1d79c87 > kexi/kexidb/dbproperties.h 69f718b > kexi/kexidb/dbproperties.cpp 2ee7fa4 > kexi/kexidb/driver.h d51a870 > kexi/kexidb/driver.cpp 8ece2aa > kexi/kexidb/driver_p.h 67f312c > kexi/kexidb/driver_p.cpp af400c6 > kexi/kexidb/drivermanager.h 140be5c > kexi/kexidb/drivermanager.cpp 08729ab > kexi/kexidb/drivermanager_p.h 28eff57 > kexi/kexidb/drivers/CMakeLists.txt 9e48942 > kexi/kexidb/drivers/mySQL/CMakeLists.txt 747c337 > kexi/kexidb/drivers/mySQL/mysqlconnection.h cd69b53 > kexi/kexidb/drivers/mySQL/mysqlconnection.cpp dac326d > kexi/kexidb/drivers/mySQL/mysqlconnection_p.h b29e721 > kexi/kexidb/drivers/mySQL/mysqlconnection_p.cpp 98f7985 > kexi/kexidb/drivers/mySQL/mysqlcursor.h b3a8dcd > kexi/kexidb/drivers/mySQL/mysqlcursor.cpp 5e302db > kexi/kexidb/drivers/mySQL/mysqldriver.h afab017 > kexi/kexidb/drivers/mySQL/mysqldriver.cpp 90408b9 > kexi/kexidb/drivers/mySQL/mysqlpreparedstatement.h d2cba87 > kexi/kexidb/drivers/odbc/kodbcdriver.h 03e0fb1 > kexi/kexidb/drivers/odbc/kodbcdriver.cpp f375e47 > kexi/kexidb/drivers/odbc/odbcconnection.h cd97d2c > kexi/kexidb/drivers/odbc/odbcconnection.cpp 300fde9 > kexi/kexidb/drivers/odbc/odbcconnection_p.h 6124d9b > kexi/kexidb/drivers/odbc/odbcconnection_p.cpp 2ffbaa5 > kexi/kexidb/drivers/odbc/odbccursor.h afdaedd > kexi/kexidb/drivers/odbc/odbccursor.cpp 8fd2c7b > kexi/kexidb/drivers/odbc/odbcdriver.h a9a1b8b > kexi/kexidb/drivers/odbc/odbcdriver.cpp c7653af > kexi/kexidb/drivers/odbc/odbcpreparedstatement.h 1cb02dd > kexi/kexidb/drivers/oracle/oracleconnection.h 1dc9589 > kexi/kexidb/drivers/oracle/oracleconnection_p.h 3c31c8c > kexi/kexidb/drivers/oracle/oracleconnection_p.cpp 22ff9fc > kexi/kexidb/drivers/oracle/oraclecursor.h 332b464 > kexi/kexidb/drivers/oracle/oraclecursor.cpp ebfce51 > kexi/kexidb/drivers/oracle/oracledriver.h 0589f37 > kexi/kexidb/drivers/oracle/oracledriver.cpp 0f7cb29 > kexi/kexidb/drivers/oracle/oraclepreparedstatement.h e09ffa6 > kexi/kexidb/drivers/pqxx/CMakeLists.txt 06ed2ff > kexi/kexidb/drivers/pqxx/pqxxconnection.h 2f6d6e9 > kexi/kexidb/drivers/pqxx/pqxxconnection.cpp 700b195 > kexi/kexidb/drivers/pqxx/pqxxconnection_p.h 9e66343 > kexi/kexidb/drivers/pqxx/pqxxcursor.h 8858b3f > kexi/kexidb/drivers/pqxx/pqxxcursor.cpp 0086305 > kexi/kexidb/drivers/pqxx/pqxxdriver.h c50b065 > kexi/kexidb/drivers/pqxx/pqxxdriver.cpp 3a47cf8 > kexi/kexidb/drivers/pqxx/pqxxpreparedstatement.h ba0f860 > kexi/kexidb/drivers/sqlite/CMakeLists.txt 6933562 > kexi/kexidb/drivers/sqlite/dump/CMakeLists.txt bf982f8 > kexi/kexidb/drivers/sqlite/dump/README ba4c33f > kexi/kexidb/drivers/sqlite/dump/main.cpp 98abfeb > kexi/kexidb/drivers/sqlite/dump/shell.c d10d436 > kexi/kexidb/drivers/sqlite/icu/CMakeLists.txt fa81579 > kexi/kexidb/drivers/sqlite/icu/README.txt 01291e6 > kexi/kexidb/drivers/sqlite/icu/icu.c 60799c4 > kexi/kexidb/drivers/sqlite/icu/sqliteicu.h 4c9a4f9 > kexi/kexidb/drivers/sqlite/kexidb_sqlite3driver.desktop 4ff6cb7 > kexi/kexidb/drivers/sqlite/sqliteadmin.h 1a232c1 > kexi/kexidb/drivers/sqlite/sqliteadmin.cpp 8715d12 > kexi/kexidb/drivers/sqlite/sqlitealter.cpp 30c5ba0 > kexi/kexidb/drivers/sqlite/sqliteconnection.h 9d20806 > kexi/kexidb/drivers/sqlite/sqliteconnection.cpp 4877506 > kexi/kexidb/drivers/sqlite/sqliteconnection_p.h ae701a2 > kexi/kexidb/drivers/sqlite/sqlitecursor.h 5860794 > kexi/kexidb/drivers/sqlite/sqlitecursor.cpp cfc6102 > kexi/kexidb/drivers/sqlite/sqlitedriver.h b745dfc > kexi/kexidb/drivers/sqlite/sqlitedriver.cpp 7124ba9 > kexi/kexidb/drivers/sqlite/sqlitekeywords.cpp 735f446 > kexi/kexidb/drivers/sqlite/sqlitepreparedstatement.h 8411dfe > kexi/kexidb/drivers/sqlite/sqlitepreparedstatement.cpp ffb751e > kexi/kexidb/drivers/sqlite/sqlitevacuum.h d9a8cfd > kexi/kexidb/drivers/sqlite/sqlitevacuum.cpp 5c20482 > kexi/kexidb/drivers/sybase/CMakeLists.txt 66c2c56 > kexi/kexidb/drivers/sybase/sybaseconnection.h 876ed88 > kexi/kexidb/drivers/sybase/sybaseconnection.cpp 2064afe > kexi/kexidb/drivers/sybase/sybaseconnection_p.h 8b50690 > kexi/kexidb/drivers/sybase/sybaseconnection_p.cpp aef7afb > kexi/kexidb/drivers/sybase/sybasecursor.h 3f1b200 > kexi/kexidb/drivers/sybase/sybasecursor.cpp 29e3870 > kexi/kexidb/drivers/sybase/sybasedriver.cpp 6262f83 > > Diff: http://git.reviewboard.kde.org/r/105464/diff/ > > > Testing > ------- > > Kexi and kexidbtest runs properly > > > Thanks, > > Jarosław Staniek > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
