----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105458/ -----------------------------------------------------------
Review request for Calligra. Description ------- For page backgrounds it happens that the image gets shown quite badly when in stretch mode is used. See bug report. When tesing the fix I found out that this effects quite a lot presentations. Not all as bad as in the bug report. With the patch all the images improve nicely. Problem was that the images generated for the pattern background did not generate a image as big as needed but some fixed one that resulted in not so good looking background images. The patch is quite big as 2 new parameters (KoViewConverter and KoShapePaintingContext) are added to the KoShapeBackground::paint method. The KoShapePaintingContext is not yet used but this is needed for animations in stage that change the background color and as I was already at it I added it too. OK to backport to 2.5? Diffs ----- karbon/ui/widgets/KarbonSmallStylePreview.cpp fb00a2c kexi/plugins/shapes/relationdesign/kexirelationdesignshape.h 9cac7b9 kexi/plugins/shapes/relationdesign/kexirelationdesignshape.cpp eba6931 libs/flake/KoColorBackground.h 6cf70d3 libs/flake/KoColorBackground.cpp b400792 libs/flake/KoGradientBackground.h 5bbcc31 libs/flake/KoGradientBackground.cpp df74f6b libs/flake/KoOdfGradientBackground.h 89e12c0 libs/flake/KoOdfGradientBackground.cpp f1a0022 libs/flake/KoPathShape.h c2e3c19 libs/flake/KoPathShape.cpp 8c8167a libs/flake/KoPatternBackground.h f31b783 libs/flake/KoPatternBackground.cpp 13abc43 libs/flake/KoShapeBackground.h 7822c50 libs/flake/KoShapeManager.cpp eeb733b libs/flake/KoUnavailShape.h eb5889d libs/flake/KoUnavailShape.cpp 89b64fd libs/flake/tests/TestShapeBackgroundCommand.cpp 67b4717 libs/kopageapp/KoPAMasterPage.cpp 42e9065 libs/kopageapp/KoPAPage.h 6a81b04 libs/kopageapp/KoPAPage.cpp cd9c5f4 libs/kopageapp/KoPAPageBase.h b9a5961 libs/kopageapp/KoPAPageBase.cpp cd25030 libs/kopageapp/KoPAViewModeNormal.cpp 9212b8b plugins/artistictextshape/ArtisticTextShape.h 05af662 plugins/artistictextshape/ArtisticTextShape.cpp 193d618 plugins/chartshape/ChartShape.cpp e7a0954 plugins/chartshape/Legend.cpp e74a77f plugins/chartshape/PlotArea.cpp 8ec8274 plugins/dockers/styledocker/StylePreview.cpp 7ddee89 plugins/textshape/TextShape.cpp a292690 stage/part/KPrAnimationDirector.cpp 17cc62b words/part/frames/KWFrameLayout.cpp 8639a1b Diff: http://git.reviewboard.kde.org/r/105458/diff/ Testing ------- Tested with the full set of cstester documents and only improvements found. Thanks, Thorsten Zachmann
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
