----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105428/#review15471 -----------------------------------------------------------
This review has been submitted with commit 83e7c1bc026c03a06f8d7e32dfb0819e73211e90 by Friedrich W. H. Kossebau to branch master. - Commit Hook On July 5, 2012, 1:18 p.m., Friedrich W. H. Kossebau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105428/ > ----------------------------------------------------------- > > (Updated July 5, 2012, 1:18 p.m.) > > > Review request for Calligra. > > > Description > ------- > > Real reason for this patch is that KFileItem::pixmap(...) is broken for items > constructed with KFileItem(mode_t, mode_t, KUrl, bool) and no other mimetype > related call before the one to ::pixmap. It will always return a pixmap with > the "unknown" icon. > You can see this for files for which there is no preview created (for > whatever reason). > > But the patch fixes also the size mismatch between the fetched previews > (200x200) and the usual ODF preview of 128x128 as well as that the preview > just from the icon is set in size 128. And makes the code shorter. > > Also load the big previews only on-demand, not by default. Could spare up to > ~500 kB (10 files * (128*128 - 64*64) * 4 bytes) in theory, but I did not > measure what the real effect is. > > Also using KIcon instead of setting an own deep copy of the pixmap per each > KoFileListItem should spare even more memory, due to KIcon reusing existing > icon pixmaps. > > Okay to backport to 2.5 as well? > > > Diffs > ----- > > libs/main/KoDetailsPane.h 6da6133 > libs/main/KoDetailsPane.cpp 8aa5965 > libs/main/KoRecentDocumentsPane.h 98baeb8 > libs/main/KoRecentDocumentsPane.cpp 521c7e6 > libs/main/KoTemplatesPane.cpp cc76c05 > > Diff: http://git.reviewboard.kde.org/r/105428/diff/ > > > Testing > ------- > > Tried the recent template pane at least in Krita, Words, Sheets > > > Thanks, > > Friedrich W. H. Kossebau > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
