Re: Review Request: Added support for text:continue-list

2011-11-01 Thread Gopalakrishna Bhat
> On Nov. 1, 2011, 7:53 p.m., C. Boemann wrote: > > cstester shows a recurring problem: Just about all lists end up looking > > like: > > > > 1. yghygh > > 1. dstgufiug > > 1. yugyu If it the files that pass through the filter then this might be the problem https://bugs.kde.org/show_bug.cgi?i

Re: Review Request: Show/Hide Tabs when project is opened/closed

2011-11-01 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102993/#review7846 --- kexi/main/KexiMainWindow_p.h

Re: Review Request: Fix clone layers updating

2011-11-01 Thread Dmitry Kazakov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103021/#review7845 --- The bug is a really good catch! I didn't even think about it. =)

Re: Review Request: Final border refactoring : remove KoTableBorderStyle totally

2011-11-01 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102998/#review7841 --- I observed several changes in the following documents dpi.wi.go

Re: Review Request: Style inheritance

2011-11-01 Thread C. Boemann
> On Nov. 1, 2011, 8 p.m., Sebastian Sauer wrote: > > libs/kotext/styles/KoCharacterStyle.cpp, line 406 > > > > > > hmmm... does this mean we are applying the format way more often now? > > > > Consider; >

Re: Review Request: Style inheritance

2011-11-01 Thread Sebastian Sauer
> On Nov. 1, 2011, 8 p.m., Sebastian Sauer wrote: > > libs/kotext/KoTextEditor.cpp, line 796 > > > > > > KoParagraphStyle inherits from KoCharacterStyle so c-style cast not > > needed or? > > Ah, I see. They are n

Re: Review Request: Style inheritance

2011-11-01 Thread Sebastian Sauer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103017/#review7833 --- libs/kotext/KoTextEditor.cpp

Re: Review Request: Added support for text:continue-list

2011-11-01 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103019/#review7837 --- cstester shows a recurring problem: Just about all lists end up

Re: Review Request: Fix clone layers updating

2011-11-01 Thread Torio Mlshi
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103021/ --- (Updated Nov. 1, 2011, 7:25 p.m.) Review request for Calligra. Summary (

Review Request:

2011-11-01 Thread Torio Mlshi
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103021/ --- Review request for Calligra. Description --- This patch fixes issues,

Re: Review Request: Added support for text:continue-list

2011-11-01 Thread Pierre Ducroquet
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103019/#review7832 --- Same as Boemann : code looks good, ok to commit if there is no c

Re: Review Request: Final border refactoring : remove KoTableBorderStyle totally

2011-11-01 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102998/#review7831 --- It looks nice. But agree about the disabled tests. And we need

Re: Review Request: Added support for text:continue-list

2011-11-01 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103019/#review7829 --- I have no comment to the code - i think it looks very good! We

Re: Review Request: Final border refactoring : remove KoTableBorderStyle totally

2011-11-01 Thread Pierre Ducroquet
> On Nov. 1, 2011, 11:10 a.m., Sebastian Sauer wrote: > > libs/kotext/styles/KoTableCellStyle.cpp, line 1180 > > > > > > Just curious; is that correct? I mean top-right-bottom-left != > > bottom-left-top-right or?

Review Request: Added support for text:continue-list

2011-11-01 Thread Gopalakrishna Bhat
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103019/ --- Review request for Calligra and C. Boemann. Description --- This patc

Review Request: Style inheritance

2011-11-01 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103017/ --- Review request for Calligra. Description --- Fix inheritance in parag

Re: Review Request: Final border refactoring : remove KoTableBorderStyle totally

2011-11-01 Thread Sebastian Sauer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102998/#review7793 --- libs/kotext/opendocument/tests/TestLoading.cpp