----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102998/#review7793 -----------------------------------------------------------
libs/kotext/opendocument/tests/TestLoading.cpp <http://git.reviewboard.kde.org/r/102998/#comment6686> hmmm... why commenting that part of the test out rather then adopting so the tested cases are continued to be tested after the patch too? libs/kotext/styles/KoTableCellStyle.cpp <http://git.reviewboard.kde.org/r/102998/#comment6687> Just curious; is that correct? I mean top-right-bottom-left != bottom-left-top-right or? - Sebastian Sauer On Oct. 30, 2011, 10:49 p.m., Pierre Ducroquet wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102998/ > ----------------------------------------------------------- > > (Updated Oct. 30, 2011, 10:49 p.m.) > > > Review request for Calligra. > > > Description > ------- > > This ends the refactoring of KoTable*Style : now we got rid of > KoTableBorderStyle and lots of code duplication. > > > Diffs > ----- > > libs/kotext/CMakeLists.txt 03fd3dc > libs/kotext/KoTextDebug.cpp 45df678 > libs/kotext/opendocument/tests/TestLoading.cpp 222fb81 > libs/kotext/styles/KoTableBorderStyle.h 8a03ff2 > libs/kotext/styles/KoTableCellStyle.h f42c2a8 > libs/kotext/styles/KoTableCellStyle.cpp eb96cf9 > libs/kotext/styles/tests/TestTableCellStyle.cpp 9da63aa > libs/textlayout/KoTextLayoutCellHelper.cpp f1eb7fa > > Diff: http://git.reviewboard.kde.org/r/102998/diff/diff > > > Testing > ------- > > > Thanks, > > Pierre Ducroquet > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
