> On Nov. 1, 2011, 8 p.m., Sebastian Sauer wrote: > > libs/kotext/KoTextEditor.cpp, line 796 > > <http://git.reviewboard.kde.org/r/103017/diff/1/?file=40042#file40042line796> > > > > KoParagraphStyle inherits from KoCharacterStyle so c-style cast not > > needed or? > >
Ah, I see. They are not virtual... I hope you catched all places where calling the proper one was needed else we have new bugs. - Sebastian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103017/#review7833 ----------------------------------------------------------- On Nov. 1, 2011, 5:41 p.m., C. Boemann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103017/ > ----------------------------------------------------------- > > (Updated Nov. 1, 2011, 5:41 p.m.) > > > Review request for Calligra. > > > Description > ------- > > Fix inheritance in paragraph styles > introduce inheritance in character styles > > > Diffs > ----- > > libs/kotext/KoTextEditor.cpp 91dc334 > libs/kotext/opendocument/KoTextSharedLoadingData.cpp c1991bc > libs/kotext/opendocument/KoTextWriter_p.cpp 7b92403 > libs/kotext/styles/KoCharacterStyle.h 53e98a1 > libs/kotext/styles/KoCharacterStyle.cpp 665e066 > libs/kotext/styles/KoParagraphStyle.h 3f9f40c > libs/kotext/styles/KoParagraphStyle.cpp cdf16a4 > libs/kotext/styles/KoStyleManager.cpp fbbc4ee > libs/kotext/styles/tests/TestStyles.cpp ea7a434 > libs/textlayout/KoTextLayoutArea.cpp 28e4141 > plugins/textshape/TextTool.cpp e699319 > plugins/textshape/dialogs/StyleManager.cpp 6110044 > plugins/textshape/dialogs/StylesModel.cpp 168ef715 > tables/Cell.cpp 0a74d9f > tables/Map.cpp 956b3e1 > words/part/KWDocument.cpp 1941d7a > > Diff: http://git.reviewboard.kde.org/r/103017/diff/diff > > > Testing > ------- > > cstester, show some improvements and some regressions > > > Thanks, > > C. Boemann > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
