Re: [PATCH v2 1/3 hurd] xkb: Fix delete key in console

2024-10-28 Thread Samuel Thibault
Applied, thanks! Damien Zammit, le lun. 28 oct. 2024 08:09:05 +, a ecrit: > Adding the missing NULL sentinel pointer allows > delete key to function without crashing pc_kbd driver. > --- > console-client/xkb/xkb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) &g

[PATCH v2 1/3 hurd] xkb: Fix delete key in console

2024-10-28 Thread Damien Zammit
Adding the missing NULL sentinel pointer allows delete key to function without crashing pc_kbd driver. --- console-client/xkb/xkb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/console-client/xkb/xkb.c b/console-client/xkb/xkb.c index 31253f5c..8759c8bf 100644 --- a/console

Re: [PATCH 2/2 hurd] xkb: Fix delete key in graphical console

2024-10-27 Thread Samuel Thibault
Damien Zammit, le dim. 27 oct. 2024 09:38:08 +, a ecrit: > Commenting out this block of code allows > delete key to function without crashing pc_kbd driver. Is the xkb_state_mod_names_are_active call not just missing the NULL sentinel as documented in xkbcommon.h? > --- > consol

[PATCH 2/2 hurd] xkb: Fix delete key in graphical console

2024-10-27 Thread Damien Zammit
Commenting out this block of code allows delete key to function without crashing pc_kbd driver. --- console-client/xkb/xkb.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/console-client/xkb/xkb.c b/console-client/xkb/xkb.c index 31253f5c..08b875c9 100644 --- a/console-client/xkb/xkb.c

Re: [PATCH] console-client: use xkbcommon instead of x11 for xkb extended support

2024-03-09 Thread Etienne Brateau
if (key.repeat) > > + /* don’t allow repeated key */ > > + if (raw_keycode == prevkey) > > continue; > > You can move this above filling key. > > > -{"xkbdir", 'x', "DIR", 0, >

Re: [PATCH] console-client: use xkbcommon instead of x11 for xkb extended support

2024-03-09 Thread Samuel Thibault
t allow repeated key */ > + if (raw_keycode == prevkey) > continue; You can move this above filling key. > -{"xkbdir", 'x', "DIR", 0, > - "Directory containing the XKB configuration files" }, > -

Re: [PATCH 1/2] * console-client/xkb/kstoucs.c (find_ucs): assert precondition.

2015-06-05 Thread Justus Winter
Merged, thanks. I took the liberty of adding a subject line to the commit message. Quoting Diego Nieto Cid (2015-06-05 03:58:09) > --- > console-client/xkb/kstoucs.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/console-client/xkb/kstoucs.c b/console-client/xkb/ks

Re: [PATCH] Check AWK usability when XKB is enabled

2015-06-05 Thread Justus Winter
Quoting Diego Nieto Cid (2015-06-05 05:28:19) > * configure.ac: test whether AWK provides strtonum function. Merged, thanks! > --- > configure.ac | 8 > 1 file changed, 8 insertions(+) > > diff --git a/configure.ac b/configure.ac > index 71f3a0e..b03057b 100644 > --- a/configure.ac > +

[PATCH] Check AWK usability when XKB is enabled

2015-06-04 Thread Diego Nieto Cid
* configure.ac: test whether AWK provides strtonum function. --- configure.ac | 8 1 file changed, 8 insertions(+) diff --git a/configure.ac b/configure.ac index 71f3a0e..b03057b 100644 --- a/configure.ac +++ b/configure.ac @@ -292,6 +292,14 @@ PKG_CHECK_MODULES([X11], [x11 xproto],

[PATCH] Check AWK usability when XKB is enabled

2015-06-04 Thread Diego Nieto Cid
Hi, While compiling the Hurd in a freshly installed system I found out that the build failed because the awk command (in mawk package) did not implent strtonum function, which is required by a script in console-client. This patch checks whether awk provides such function, whenever XKB is enabled

[PATCH 1/2] * console-client/xkb/kstoucs.c (find_ucs): assert precondition.

2015-06-04 Thread Diego Nieto Cid
--- console-client/xkb/kstoucs.c | 4 1 file changed, 4 insertions(+) diff --git a/console-client/xkb/kstoucs.c b/console-client/xkb/kstoucs.c index 8471e94..fb62445 100644 --- a/console-client/xkb/kstoucs.c +++ b/console-client/xkb/kstoucs.c @@ -1,3 +1,5 @@ +#include + struct ksmap

Bug#734764: /usr/share/X11/xkb/compat/default was missing

2014-01-09 Thread Cong Zhang
Package: xkb-data Version: 2.10.1-1 Severity: important Tags: upstream After insall debian hurd from mini.iso in qemu with kvm enable, when system boot, it show can't open file compat/default, and X can't start. I copy one /usr/share/X11/xkb/compat/default from debian wheezy, and then

Re: [PATCH v2] config.make: Use more configure settings when building xkb-data

2013-08-16 Thread Samuel Thibault
Applied, thanks. Samuel

[PATCH v2] config.make: Use more configure settings when building xkb-data

2013-08-15 Thread David Michael
b/configure.ac index 31e48ef..b827536 100644 --- a/configure.ac +++ b/configure.ac @@ -246,8 +246,9 @@ PKG_CHECK_MODULES([X11], [x11 xproto], AS_IF([test $pkg_failed = no], [XKB_BASE="$pkg_cv_XKB_BASE" AC_MSG_RESULT([$XKB_BASE])], - [XKB_BASE="$datadir/s

[PATCH] config.make: Use more configure settings when building xkb-data

2013-08-15 Thread David Michael
+++ b/configure.ac @@ -246,7 +246,7 @@ PKG_CHECK_MODULES([X11], [x11 xproto], AS_IF([test $pkg_failed = no], [XKB_BASE="$pkg_cv_XKB_BASE" AC_MSG_RESULT([$XKB_BASE])], - [XKB_BASE="$datadir/share/X11/xkb" + [XKB_BASE="$datadir/X11/xkb" AC_

Re: console-client/xkb/compose.c (read_composefile): fclose

2013-06-01 Thread Samuel Thibault
Miguel Figueiredo, le Sat 01 Jun 2013 11:05:10 +0100, a écrit : > 2013-06-01 Miguel Figueiredo > > * console-client/xkb/compose.c (read_composefile): fclose > > iiuc parse_composefile always returns 0 and this makes the if(err) not > executing the fclose. > cppcheck reporte

console-client/xkb/compose.c (read_composefile): fclose

2013-06-01 Thread Miguel Figueiredo
2013-06-01 Miguel Figueiredo * console-client/xkb/compose.c (read_composefile): fclose iiuc parse_composefile always returns 0 and this makes the if(err) not executing the fclose. cppcheck reported this as memory leak. -- Melhores cumprimentos/Best regards, Miguel Figueiredo diff --git a

Re: [PATCH 0/8] Bring console-driver-xkb up to date

2012-06-30 Thread Samuel Thibault
Hello, I have fixed a few remaining bits, tested with success, and pushed it to master, thanks! Samuel

Re: [PATCH 0/8] Bring console-driver-xkb up to date

2010-08-18 Thread Samuel Thibault
thinks. I do too. Perhaps we should first wait for Marco's opinion on this. > The original xkb driver was just a tared up dump of Marco's code tree on > his homepage I believe, so there is no real upstream location AFAIK. Well, that's still an upstream location :) Samuel

Re: [PATCH 0/8] Bring console-driver-xkb up to date

2010-08-18 Thread Michael Banck
es were necesary to make > > it work again. > > Does anybody know whether / where we have an upstream repository where > to commit such patches? They should go into the Hurd codebase, methinks. The original xkb driver was just a tared up dump of Marco's code tree on his h

Re: [PATCH 0/8] Bring console-driver-xkb up to date

2010-08-17 Thread Samuel Thibault
Hello, Diego Nieto Cid, le Wed 04 Aug 2010 04:19:58 -0300, a écrit : >The past couple of weeks I've been packaging Marco's input driver > for Arch Hurd and I've found that some changes were necesary to make > it work again. Does anybody know whether / where we have an upstream repository wher

Re: [PATCH 0/8] Bring console-driver-xkb up to date

2010-08-15 Thread olafBuddenhagen
Hi, On Fri, Aug 13, 2010 at 03:13:36PM -0300, Diego Nieto Cid wrote: > At some point in it's history pc_kbd introduced support for GNU Mach > v2, Actually, it was probably the other way around: the console was originally written for oskit-mach (because it doesn't have a kernel console), and was

Re: [PATCH 0/8] Bring console-driver-xkb up to date

2010-08-13 Thread Diego Nieto Cid
Hi, 2010/8/13 : > > > Not sure what you are saying here. Do you mean that the xkb driver > misses some functionality the ordinary pc_kbd driver has? > At some point in it's history pc_kbd introduced support for GNU Mach v2, which is the oskit based kernel AFAIK. For that re

Re: [PATCH 0/8] Bring console-driver-xkb up to date

2010-08-13 Thread olafBuddenhagen
Hi, On Wed, Aug 11, 2010 at 06:55:25PM -0300, Diego Nieto Cid wrote: > 2010/8/9 : > > I'm not really familiar with the situation; but it sounds like xkb > > never should have been an extra driver, but rather just an update > > (perhaps on a development branch) o

[PATCH 5/5] Recreate xkb/keymap/hurd from xkeyboard-config-1.8's xfree86 keymap.

2010-08-11 Thread Diego Nieto Cid
modified: xkb/keymap/hurd * Don't include inexistant symbol file: pc104. * en_US was replaced by pc(pc105). * Append us layout by default as pc(pc105) no longer describes a full keyboard. --- xkb/keymap/hurd | 294 +++--

Re: [PATCH 0/8] Bring console-driver-xkb up to date

2010-08-11 Thread Diego Nieto Cid
> 2010/8/9 : > > Indeed. I'm not really familiar with the situation; but it sounds like > xkb never should have been an extra driver, but rather just an update > (perhaps on a development branch) of the normal pc_kbd driver -- with > the xkb code simply replacing the old ke

Re: [PATCH 0/8] Bring console-driver-xkb up to date

2010-08-11 Thread olafBuddenhagen
uilds, >though. > >BTW, I don't like this source code duplication. When I saw that >most of the input driver is the same as pc_kbd it came to mind this >should actually be a libxkb used by pc_kbd. But I wanted to have >something working first. :) Indeed. I

Re: [PATCH 1/8] Update the parser to work with current XKB files.

2010-08-11 Thread olafBuddenhagen
evel > numbers. > > * Skip to main file's default section when needed. > > * Update key type assigment routine. (Adds support for FOUR_LEVEL > keys) > > * Recreate xkb/keymap/hurd based on xkeyboard-config-1.8's xfree86 > keymap. > > m

[PATCH 0/8] Bring console-driver-xkb up to date

2010-08-04 Thread Diego Nieto Cid
've downloaded from ~thibault's tmp folder at dept-info.labri.fr The list of patches: 1. Update the parser to work with current XKB files. 2. Avoid hashing garbage for short keynames. 3. Rule vmod returns an int with the vmod's bit on. 4. Remove glue code and use

[PATCH 1/8] Update the parser to work with current XKB files.

2010-08-04 Thread Diego Nieto Cid
utine. (Adds support for FOUR_LEVEL keys) * Recreate xkb/keymap/hurd based on xkeyboard-config-1.8's xfree86 keymap. modified: xkb/keymap/hurd - Don't include inexistant symbol file: pc104. - en_US was replaced by pc(pc105). - Append us layout by defa

Re: xkb

2004-02-15 Thread Marco Gerards
Oh, nice. > also if I set --keymap=ru_RU.utf8 xkb fails with "unexpected end of file" What I meant was setting the locale to this. As keymap you should just use "ru". I think you can force dpkg to install the locale package or perhaps it works with the newest glibc Je

Re: xkb

2004-02-15 Thread Dmitry V. Zhulanov
05)+ru+hurd"}; > > xkb_geometry{ include "pc(pc102)" }; > > }; > > > > Although I have not tested this yet (at the moment I cannot test it, > > sorry), but this should work. > Hm anyway OQ OP OR instead alt-f1, alt-f2 ... S

Re: xkb

2004-02-15 Thread Dmitry V. Zhulanov
On Sun, Feb 15, 2004 at 04:37:06PM +0100, Marco Gerards wrote: > [EMAIL PROTECTED] (Dmitry V. Zhulanov) writes: > > >> To be honest, I do not know. What is the output of the locale > >> program? > > # locale > > LANG=POSIX > > LC_NUMERIC="ru_RU.KOI8-r" > > ... > > LC_ALL="ru_RU.KOI8-r" > > It is

Re: xkb

2004-02-15 Thread Marco Gerards
[EMAIL PROTECTED] (Dmitry V. Zhulanov) writes: >> To be honest, I do not know. What is the output of the locale >> program? > # locale > LANG=POSIX > LC_NUMERIC="ru_RU.KOI8-r" > ... > LC_ALL="ru_RU.KOI8-r" It is not an UTF-8 locale. Isn't there something like ru.UTF-8? >> Does it work exactly l

Re: xkb

2004-02-15 Thread Dmitry V. Zhulanov
e "ru" keymap in XFree? I tried testing > the "ru" keymaps but it could've been that I missed some things > because it does not make much sense to me. :) alt-F1..F6 doesn't work instead of it OP OQ .. printed in command line also russian letters display as questi

Re: xkb

2004-02-15 Thread Marco Gerards
> # console -d vga --font=8x13.bdf -d xkb --keymapfile=keymap/hurd > # --xkbdir=/etc/X11/xkb --keymap=ru /dev/vcs > console unrecognized option `--font=8x13.bdf' > Try `console --help' ... Try `--font 8x13.bdf' instead of `--font=8x13.bdf'. The argument parsing of t

Re: xkb

2004-02-15 Thread Dmitry V. Zhulanov
too? Yes, now cursor stay on correct position. > > >> The Compose file should not be copied to /etc/X11/xkb/symbols/compose, > >> those files are not compatible. Can you restore the old one? > > The old one does not exist when I copy Compose. I did that because, &g

Re: xkb

2004-02-15 Thread Marco Gerards
[EMAIL PROTECTED] (Dmitry V. Zhulanov) writes: >> console -d vga -d xkb --keymapfile=keymap/hurd --xkbdir=/etc/X11/xkb --keymap en_US >> /dev/vcs 2>/dev/null > It works! but cursor positioned bottom left coner, and show on right > position only while cursor moving or I prin

Re: xkb

2004-02-15 Thread Dmitry V. Zhulanov
On Sun, Feb 15, 2004 at 12:33:49PM +0100, Marco Gerards wrote: > [EMAIL PROTECTED] (Dmitry V. Zhulanov) writes: > > console -d vga -d xkb --keymapfile=keymap/hurd --xkbdir=/etc/X11/xkb --keymap en_US > /dev/vcs 2>/dev/null It works! but cursor positioned bottom left coner, an

Re: xkb

2004-02-15 Thread Marco Gerards
[EMAIL PROTECTED] (Dmitry V. Zhulanov) writes: > Hi! > I test xkb-0.3. Default directory as described in README is > /etc/X11/xkb, but xkb by default set it as /home/marco/src/xkb. > Starting console with > # console -d xkbd --keymapfile=/etc/X11/

xkb

2004-02-14 Thread Dmitry V. Zhulanov
Hi! I test xkb-0.3. Default directory as described in README is /etc/X11/xkb, but xkb by default set it as /home/marco/src/xkb. Starting console with # console -d xkbd --keymapfile=/etc/X11/xkb/keymap/hurd -xkbdir=/etc/X11/xkb /dev/vcs fails with

XKB plugin 0.001

2003-03-17 Thread M. Gerards
Hi, As I have mailed to this list before I planned to work on a XKB keymap plugin for the console-client. I have done this for a while. It is not finished yet and the code is really ugly, and it isn't intended for serious usage yet (If you are lucky it might work) But incase I get hit

Re: More about XKB

2002-11-14 Thread M. Gerards
> On Wed, Nov 13, 2002 at 10:52:53PM +0100, M. Gerards wrote: > > > Why discuss this with the X people? The need to be able to reuse the > Hurd > > > extensions to keymaps in X is absolutely zero. The Hurd driver should > > > (internally) preload the default Hurd extensions (like Alt+F1 sitch to

Re: More about XKB

2002-11-14 Thread Marcus Brinkmann
On Wed, Nov 13, 2002 at 10:52:53PM +0100, M. Gerards wrote: > > Why discuss this with the X people? The need to be able to reuse the Hurd > > extensions to keymaps in X is absolutely zero. The Hurd driver should > > (internally) preload the default Hurd extensions (like Alt+F1 sitch to VC1), > >

Re: More about XKB

2002-11-13 Thread M. Gerards
ompiled format should not be visible at all, even if it is > used internally. If a compiled format helps you writing a working > implementation because it makes it easier for you to load a keymap from > disk, then that's fine. But eventually I expect that the driver reads the > hum

Re: More about XKB

2002-11-13 Thread Marcus Brinkmann
can set the right priorities. > > I think this is very low priority. The separation in low level keycode > > driver and the generic xkb driver makes it painless to add such a feature > > later, if it is truly desired. I really think this can wait. > > It is low priority, I

Re: Console-client xkb keyboard plugin

2002-11-13 Thread M. Gerards
> On Wed, Nov 13, 2002 at 12:02:51AM +0100, M. Gerards wrote: > > I only support the compiled format. When a user wants to use the XKB format > the > > external xkbcomp program can be used to compile the keymap. This action > data > > structure can't be modif

Re: More about XKB

2002-11-13 Thread M. Gerards
t; > the console-client and the driver. XKB is the X Keyboard Extention, > > the X way to have amlost full control over your keyboard. It's more > > than a keyboard map. It has many accesibility features and actions > > that can be bound to keys. > > I think th

Re: Console-client xkb keyboard plugin

2002-11-12 Thread Marcus Brinkmann
On Wed, Nov 13, 2002 at 12:22:07AM +0100, Marcus Brinkmann wrote: > On Wed, Nov 13, 2002 at 12:02:51AM +0100, M. Gerards wrote: > > I only support the compiled format. When a user wants to use the XKB format the > > external xkbcomp program can be used to compile the keymap. T

Re: Console-client xkb keyboard plugin

2002-11-12 Thread Marcus Brinkmann
On Wed, Nov 13, 2002 at 12:02:51AM +0100, M. Gerards wrote: > I only support the compiled format. When a user wants to use the XKB format the > external xkbcomp program can be used to compile the keymap. This action data > structure can't be modified without losing compatibility. Th

Re: More about XKB

2002-11-12 Thread Marcus Brinkmann
On Tue, Nov 12, 2002 at 11:06:32PM +0100, M. Gerards wrote: > Before you can understand what it does you first have to know what it > is. This plugin is no driver (as it is now), but it is an additional layer between > the console-client and the driver. XKB is the X Keyboard Extention, &g

Re: Console-client xkb keyboard plugin

2002-11-12 Thread M. Gerards
Quoting Marcus Brinkmann <[EMAIL PROTECTED]>: > On Mon, Nov 11, 2002 at 02:49:33PM +0100, M. Gerards wrote: > > The first problem is the scancode to keycod translation. At the moment I've > > > hardcoded this translation (XKB also works like this.). I'm not h

More about XKB

2002-11-12 Thread M. Gerards
Hi, I've been working on the XKB console-client plugin for some weeks now. In this mail I will inform you what I have done, what needs to be done and how XKB globally works. This is a huge mail for something simple like a keyboard, but well... I hope many people understand more about keyb

Re: Console-client xkb keyboard plugin

2002-11-11 Thread Marcus Brinkmann
On Mon, Nov 11, 2002 at 02:49:33PM +0100, M. Gerards wrote: > The first problem is the scancode to keycod translation. At the moment I've > hardcoded this translation (XKB also works like this.). I'm not happy with this > because this will cause problems for exotic keyboards.

Console-client xkb keyboard plugin

2002-11-11 Thread M. Gerards
Hi, At the moment I'm working on a xkb keyboard plugin for the console-client. I encountered some problems. The first problem is the scancode to keycod translation. At the moment I've hardcoded this translation (XKB also works like this.). I'm not happy with this because

Console-client xkb keyboard plugin

2002-11-11 Thread M. Gerards
Hi, At the moment I'm working on a xkb keyboard plugin for the console-client. I encountered some problems. The first problem is the scancode to keycod translation. At the moment I've hardcoded this translation (XKB also works like this.). I'm not happy with this because

XKB support for the console

2002-10-08 Thread marco
Hi, I had a quick look today at what should happen to support xkb on the console. I think the easiest way to support xkb is by loading xkm files (X servers work like this). In a later stage an option can be added to load xkb configuration files. This can work the same way as X does: by executing