console-client/xkb/compose.c (read_composefile): fclose

[Miguel Figueiredo]

2013-06-01 Miguel Figueiredo <el...@debianpt.org>
* console-client/xkb/compose.c (read_composefile): fclose

iiuc parse_composefile always returns 0 and this makes the if(err) not 
executing the fclose.
cppcheck reported this as memory leak.

--
Melhores cumprimentos/Best regards,

Miguel Figueiredo
diff --git a/console-client/trans.c b/console-client/trans.c
index 6949af5..8219f97 100644
--- a/console-client/trans.c
+++ b/console-client/trans.c
@@ -844,7 +844,6 @@ console_unregister_consnode (consnode_t cn)
 error_t
 console_setup_node (char *path)
 {
-  mach_port_t underlying;
   mach_port_t bootstrap;
   error_t err;
   struct stat ul_stat;
@@ -874,7 +873,6 @@ console_setup_node (char *path)
   err = file_set_translator (node, 0, FS_TRANS_EXCL | FS_TRANS_SET, 0, 0, 0,
 			     right, MACH_MSG_TYPE_COPY_SEND); 
   mach_port_deallocate (mach_task_self (), right);
-  underlying = node;
   
   err = io_stat (node, &ul_stat);
   if (err)
diff --git a/console-client/xkb/compose.c b/console-client/xkb/compose.c
index 78bce7f..fb3f07c 100644
--- a/console-client/xkb/compose.c
+++ b/console-client/xkb/compose.c
@@ -586,8 +586,7 @@ read_composefile (char *composefn)
     return errno;
   
   err = parse_composefile (cf);
-  if (err)
-    fclose (cf);
+  fclose (cf);
   
   return err;
 }